linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer
@ 2021-09-14 18:23 trix
  2021-09-14 18:58 ` Greg KH
  0 siblings, 1 reply; 10+ messages in thread
From: trix @ 2021-09-14 18:23 UTC (permalink / raw)
  To: mfd, hao.wu, gregkh; +Cc: linux-kernel, linux-fpga, Tom Rix

From: Tom Rix <trix@redhat.com>

I am the maintainer of the fpga/ subsystem for both the kernel and
userspace for Red Hat.  I have been an active reviewer and contributor
on for public fpga/ subsystem for the last year.  I would like to
help out more.

Since I am paid to do this work, change the status to Supported.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 04fa4edf100b83..0443d7ab826659 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7353,9 +7353,9 @@ F:	include/uapi/linux/fpga-dfl.h
 
 FPGA MANAGER FRAMEWORK
 M:	Moritz Fischer <mdf@kernel.org>
-R:	Tom Rix <trix@redhat.com>
+M:	Tom Rix <trix@redhat.com>
 L:	linux-fpga@vger.kernel.org
-S:	Maintained
+S:	Supported
 W:	http://www.rocketboards.org
 Q:	http://patchwork.kernel.org/project/linux-fpga/list/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
-- 
2.26.3


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer
  2021-09-14 18:23 [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer trix
@ 2021-09-14 18:58 ` Greg KH
  2021-09-15 13:23   ` Tom Rix
  0 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2021-09-14 18:58 UTC (permalink / raw)
  To: trix; +Cc: mdf, hao.wu, linux-kernel, linux-fpga

[note, you got the maintainer's email address wrong on your cc: line
 I fixed it up...]

On Tue, Sep 14, 2021 at 11:23:33AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> I am the maintainer of the fpga/ subsystem for both the kernel and
> userspace for Red Hat.  I have been an active reviewer and contributor
> on for public fpga/ subsystem for the last year.  I would like to
> help out more.
> 
> Since I am paid to do this work, change the status to Supported.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 04fa4edf100b83..0443d7ab826659 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7353,9 +7353,9 @@ F:	include/uapi/linux/fpga-dfl.h
>  
>  FPGA MANAGER FRAMEWORK
>  M:	Moritz Fischer <mdf@kernel.org>
> -R:	Tom Rix <trix@redhat.com>
> +M:	Tom Rix <trix@redhat.com>
>  L:	linux-fpga@vger.kernel.org
> -S:	Maintained
> +S:	Supported
>  W:	http://www.rocketboards.org
>  Q:	http://patchwork.kernel.org/project/linux-fpga/list/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
> -- 
> 2.26.3
> 

Traditionally existing maintainers are the ones that add new
maintainers, it's not something that you just submit a patch for hoping
it will be accepted.

What has changed since the last time you asked to do this?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer
  2021-09-14 18:58 ` Greg KH
@ 2021-09-15 13:23   ` Tom Rix
  2021-09-15 14:04     ` Greg KH
  0 siblings, 1 reply; 10+ messages in thread
From: Tom Rix @ 2021-09-15 13:23 UTC (permalink / raw)
  To: Greg KH; +Cc: mdf, hao.wu, linux-kernel, linux-fpga


On 9/14/21 11:58 AM, Greg KH wrote:
> [note, you got the maintainer's email address wrong on your cc: line
>   I fixed it up...]
>
> On Tue, Sep 14, 2021 at 11:23:33AM -0700, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> I am the maintainer of the fpga/ subsystem for both the kernel and
>> userspace for Red Hat.  I have been an active reviewer and contributor
>> on for public fpga/ subsystem for the last year.  I would like to
>> help out more.
>>
>> Since I am paid to do this work, change the status to Supported.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>>   MAINTAINERS | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 04fa4edf100b83..0443d7ab826659 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -7353,9 +7353,9 @@ F:	include/uapi/linux/fpga-dfl.h
>>   
>>   FPGA MANAGER FRAMEWORK
>>   M:	Moritz Fischer <mdf@kernel.org>
>> -R:	Tom Rix <trix@redhat.com>
>> +M:	Tom Rix <trix@redhat.com>
>>   L:	linux-fpga@vger.kernel.org
>> -S:	Maintained
>> +S:	Supported
>>   W:	http://www.rocketboards.org
>>   Q:	http://patchwork.kernel.org/project/linux-fpga/list/
>>   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
>> -- 
>> 2.26.3
>>
> Traditionally existing maintainers are the ones that add new
> maintainers, it's not something that you just submit a patch for hoping
> it will be accepted.
>
> What has changed since the last time you asked to do this?

Because public and private requests have gone unanswered for so long, it 
is unclear if Moritz is still maintaining the subsystem.

The nearly year old xrt patchset has been pending for 6 weeks with minor 
changes to one patch out of 14 needing reviews.

The standard release patchset, which needs an opinion has on an api 
change, has been outstanding for 8 weeks.


If maintainership depends on an approving maintainter, what happens when 
the approving maintainer has left ?

Tom

>
> thanks,
>
> greg k-h
>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer
  2021-09-15 13:23   ` Tom Rix
@ 2021-09-15 14:04     ` Greg KH
  2021-09-15 16:12       ` Tom Rix
  0 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2021-09-15 14:04 UTC (permalink / raw)
  To: Tom Rix; +Cc: mdf, hao.wu, linux-kernel, linux-fpga

On Wed, Sep 15, 2021 at 06:23:16AM -0700, Tom Rix wrote:
> 
> On 9/14/21 11:58 AM, Greg KH wrote:
> > [note, you got the maintainer's email address wrong on your cc: line
> >   I fixed it up...]
> > 
> > On Tue, Sep 14, 2021 at 11:23:33AM -0700, trix@redhat.com wrote:
> > > From: Tom Rix <trix@redhat.com>
> > > 
> > > I am the maintainer of the fpga/ subsystem for both the kernel and
> > > userspace for Red Hat.  I have been an active reviewer and contributor
> > > on for public fpga/ subsystem for the last year.  I would like to
> > > help out more.
> > > 
> > > Since I am paid to do this work, change the status to Supported.
> > > 
> > > Signed-off-by: Tom Rix <trix@redhat.com>
> > > ---
> > >   MAINTAINERS | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 04fa4edf100b83..0443d7ab826659 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -7353,9 +7353,9 @@ F:	include/uapi/linux/fpga-dfl.h
> > >   FPGA MANAGER FRAMEWORK
> > >   M:	Moritz Fischer <mdf@kernel.org>
> > > -R:	Tom Rix <trix@redhat.com>
> > > +M:	Tom Rix <trix@redhat.com>
> > >   L:	linux-fpga@vger.kernel.org
> > > -S:	Maintained
> > > +S:	Supported
> > >   W:	http://www.rocketboards.org
> > >   Q:	http://patchwork.kernel.org/project/linux-fpga/list/
> > >   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
> > > -- 
> > > 2.26.3
> > > 
> > Traditionally existing maintainers are the ones that add new
> > maintainers, it's not something that you just submit a patch for hoping
> > it will be accepted.
> > 
> > What has changed since the last time you asked to do this?
> 
> Because public and private requests have gone unanswered for so long, it is
> unclear if Moritz is still maintaining the subsystem.

He is, as is evident by the patches I accept from him each merge.

> The nearly year old xrt patchset has been pending for 6 weeks with minor
> changes to one patch out of 14 needing reviews.

Code quality is not the maintainer's job, it's the developer's, so the
age and number of reviews is not any indication.

> The standard release patchset, which needs an opinion has on an api change,
> has been outstanding for 8 weeks.

Have a pointer to it?

> If maintainership depends on an approving maintainter, what happens when the
> approving maintainer has left ?

Vacations happen in the summer.  I've talked to Moritz many times, and
all is well here.

greg k-h

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer
  2021-09-15 14:04     ` Greg KH
@ 2021-09-15 16:12       ` Tom Rix
  2021-09-15 20:55         ` Moritz Fischer
  0 siblings, 1 reply; 10+ messages in thread
From: Tom Rix @ 2021-09-15 16:12 UTC (permalink / raw)
  To: Greg KH; +Cc: mdf, hao.wu, linux-kernel, linux-fpga


On 9/15/21 7:04 AM, Greg KH wrote:
> On Wed, Sep 15, 2021 at 06:23:16AM -0700, Tom Rix wrote:
>> On 9/14/21 11:58 AM, Greg KH wrote:
>>> [note, you got the maintainer's email address wrong on your cc: line
>>>    I fixed it up...]
>>>
>>> On Tue, Sep 14, 2021 at 11:23:33AM -0700, trix@redhat.com wrote:
>>>> From: Tom Rix <trix@redhat.com>
>>>>
>>>> I am the maintainer of the fpga/ subsystem for both the kernel and
>>>> userspace for Red Hat.  I have been an active reviewer and contributor
>>>> on for public fpga/ subsystem for the last year.  I would like to
>>>> help out more.
>>>>
>>>> Since I am paid to do this work, change the status to Supported.
>>>>
>>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>>> ---
>>>>    MAINTAINERS | 4 ++--
>>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 04fa4edf100b83..0443d7ab826659 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -7353,9 +7353,9 @@ F:	include/uapi/linux/fpga-dfl.h
>>>>    FPGA MANAGER FRAMEWORK
>>>>    M:	Moritz Fischer <mdf@kernel.org>
>>>> -R:	Tom Rix <trix@redhat.com>
>>>> +M:	Tom Rix <trix@redhat.com>
>>>>    L:	linux-fpga@vger.kernel.org
>>>> -S:	Maintained
>>>> +S:	Supported
>>>>    W:	http://www.rocketboards.org
>>>>    Q:	http://patchwork.kernel.org/project/linux-fpga/list/
>>>>    T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
>>>> -- 
>>>> 2.26.3
>>>>
>>> Traditionally existing maintainers are the ones that add new
>>> maintainers, it's not something that you just submit a patch for hoping
>>> it will be accepted.
>>>
>>> What has changed since the last time you asked to do this?
>> Because public and private requests have gone unanswered for so long, it is
>> unclear if Moritz is still maintaining the subsystem.
> He is, as is evident by the patches I accept from him each merge.
>
>> The nearly year old xrt patchset has been pending for 6 weeks with minor
>> changes to one patch out of 14 needing reviews.
> Code quality is not the maintainer's job, it's the developer's, so the
> age and number of reviews is not any indication.

https://lore.kernel.org/linux-fpga/20210802160521.331031-1-lizhi.hou@xilinx.com/

The review is needed because Moritz asked for the changes v8 here

https://lore.kernel.org/linux-fpga/YP42zE2ljx4hHj40@epycbox.lan/

When the maintainer asks for the changes, they are responsible for the 
followup.

>> The standard release patchset, which needs an opinion has on an api change,
>> has been outstanding for 8 weeks.
> Have a pointer to it?

This was a change you requested. the recent patchset is

https://lore.kernel.org/linux-fpga/20210914214327.94048-4-russell.h.weight@intel.com/

The discussion around the api change is

https://lore.kernel.org/linux-fpga/661d53d0-0ba4-d344-8da0-995a9b612905@redhat.com/

In these toss up's if the maintainer does not weigh in as the tie 
breaker, the patch stalls.

>
>> If maintainership depends on an approving maintainter, what happens when the
>> approving maintainer has left ?
> Vacations happen in the summer.  I've talked to Moritz many times, and
> all is well here.

Yes. in the xrt v9 patch Moritz announced late of a vacation with a 
return of 9/4.

It has been 11 days.


I have tried to reach him privately several times of the last 2 months 
without a response.

Publicly several folks and I have asked for a reply to move their 
patches along.

For a low volume list, it should be possible to clear outstanding 
requests at least weekly.

When that turns into months, that is a problem.


The subsystem needs at least a submaintainer.

Tom

> greg k-h
>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer
  2021-09-15 16:12       ` Tom Rix
@ 2021-09-15 20:55         ` Moritz Fischer
  2021-09-16 12:41           ` Tom Rix
  0 siblings, 1 reply; 10+ messages in thread
From: Moritz Fischer @ 2021-09-15 20:55 UTC (permalink / raw)
  To: Tom Rix; +Cc: Greg KH, mdf, hao.wu, linux-kernel, linux-fpga

On Wed, Sep 15, 2021 at 09:12:51AM -0700, Tom Rix wrote:
> 
> On 9/15/21 7:04 AM, Greg KH wrote:
> > On Wed, Sep 15, 2021 at 06:23:16AM -0700, Tom Rix wrote:
> > > On 9/14/21 11:58 AM, Greg KH wrote:
> > > > [note, you got the maintainer's email address wrong on your cc: line
> > > >    I fixed it up...]
> > > > 
> > > > On Tue, Sep 14, 2021 at 11:23:33AM -0700, trix@redhat.com wrote:
> > > > > From: Tom Rix <trix@redhat.com>
> > > > > 
> > > > > I am the maintainer of the fpga/ subsystem for both the kernel and
> > > > > userspace for Red Hat.  I have been an active reviewer and contributor
> > > > > on for public fpga/ subsystem for the last year.  I would like to
> > > > > help out more.
> > > > > 
> > > > > Since I am paid to do this work, change the status to Supported.
> > > > > 
> > > > > Signed-off-by: Tom Rix <trix@redhat.com>
> > > > > ---
> > > > >    MAINTAINERS | 4 ++--
> > > > >    1 file changed, 2 insertions(+), 2 deletions(-)
> > > > > 
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index 04fa4edf100b83..0443d7ab826659 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -7353,9 +7353,9 @@ F:	include/uapi/linux/fpga-dfl.h
> > > > >    FPGA MANAGER FRAMEWORK
> > > > >    M:	Moritz Fischer <mdf@kernel.org>
> > > > > -R:	Tom Rix <trix@redhat.com>
> > > > > +M:	Tom Rix <trix@redhat.com>
> > > > >    L:	linux-fpga@vger.kernel.org
> > > > > -S:	Maintained
> > > > > +S:	Supported
> > > > >    W:	http://www.rocketboards.org
> > > > >    Q:	http://patchwork.kernel.org/project/linux-fpga/list/
> > > > >    T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
> > > > > -- 
> > > > > 2.26.3
> > > > > 
> > > > Traditionally existing maintainers are the ones that add new
> > > > maintainers, it's not something that you just submit a patch for hoping
> > > > it will be accepted.
> > > > 
> > > > What has changed since the last time you asked to do this?
> > > Because public and private requests have gone unanswered for so long, it is
> > > unclear if Moritz is still maintaining the subsystem.
> > He is, as is evident by the patches I accept from him each merge.
> > 
> > > The nearly year old xrt patchset has been pending for 6 weeks with minor
> > > changes to one patch out of 14 needing reviews.
> > Code quality is not the maintainer's job, it's the developer's, so the
> > age and number of reviews is not any indication.
> 
> https://lore.kernel.org/linux-fpga/20210802160521.331031-1-lizhi.hou@xilinx.com/
> 
> The review is needed because Moritz asked for the changes v8 here
> 
> https://lore.kernel.org/linux-fpga/YP42zE2ljx4hHj40@epycbox.lan/
> 
> When the maintainer asks for the changes, they are responsible for the
> followup.
> 
> > > The standard release patchset, which needs an opinion has on an api change,
> > > has been outstanding for 8 weeks.
> > Have a pointer to it?
> 
> This was a change you requested. the recent patchset is
> 
> https://lore.kernel.org/linux-fpga/20210914214327.94048-4-russell.h.weight@intel.com/
> 
> The discussion around the api change is
> 
> https://lore.kernel.org/linux-fpga/661d53d0-0ba4-d344-8da0-995a9b612905@redhat.com/
> 
> In these toss up's if the maintainer does not weigh in as the tie breaker,
> the patch stalls.
> 
> > 
> > > If maintainership depends on an approving maintainter, what happens when the
> > > approving maintainer has left ?
> > Vacations happen in the summer.  I've talked to Moritz many times, and
> > all is well here.
> 
> Yes. in the xrt v9 patch Moritz announced late of a vacation with a return
> of 9/4.
> 
> It has been 11 days.

I had a family issue that was unforseen combined with an unusual high
post-vacation workload at $dayjob when I got back.

I'm still catching up, and will get to it when I can.
 
- Moritz

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer
  2021-09-15 20:55         ` Moritz Fischer
@ 2021-09-16 12:41           ` Tom Rix
  2021-09-16 12:49             ` Greg KH
  0 siblings, 1 reply; 10+ messages in thread
From: Tom Rix @ 2021-09-16 12:41 UTC (permalink / raw)
  To: Moritz Fischer; +Cc: Greg KH, hao.wu, linux-kernel, linux-fpga


On 9/15/21 1:55 PM, Moritz Fischer wrote:
> On Wed, Sep 15, 2021 at 09:12:51AM -0700, Tom Rix wrote:
>> On 9/15/21 7:04 AM, Greg KH wrote:
>>> On Wed, Sep 15, 2021 at 06:23:16AM -0700, Tom Rix wrote:
>>>> On 9/14/21 11:58 AM, Greg KH wrote:
>>>>> [note, you got the maintainer's email address wrong on your cc: line
>>>>>     I fixed it up...]
>>>>>
>>>>> On Tue, Sep 14, 2021 at 11:23:33AM -0700, trix@redhat.com wrote:
>>>>>> From: Tom Rix <trix@redhat.com>
>>>>>>
>>>>>> I am the maintainer of the fpga/ subsystem for both the kernel and
>>>>>> userspace for Red Hat.  I have been an active reviewer and contributor
>>>>>> on for public fpga/ subsystem for the last year.  I would like to
>>>>>> help out more.
>>>>>>
>>>>>> Since I am paid to do this work, change the status to Supported.
>>>>>>
>>>>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>>>>> ---
>>>>>>     MAINTAINERS | 4 ++--
>>>>>>     1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>> index 04fa4edf100b83..0443d7ab826659 100644
>>>>>> --- a/MAINTAINERS
>>>>>> +++ b/MAINTAINERS
>>>>>> @@ -7353,9 +7353,9 @@ F:	include/uapi/linux/fpga-dfl.h
>>>>>>     FPGA MANAGER FRAMEWORK
>>>>>>     M:	Moritz Fischer <mdf@kernel.org>
>>>>>> -R:	Tom Rix <trix@redhat.com>
>>>>>> +M:	Tom Rix <trix@redhat.com>
>>>>>>     L:	linux-fpga@vger.kernel.org
>>>>>> -S:	Maintained
>>>>>> +S:	Supported
>>>>>>     W:	http://www.rocketboards.org
>>>>>>     Q:	http://patchwork.kernel.org/project/linux-fpga/list/
>>>>>>     T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
>>>>>> -- 
>>>>>> 2.26.3
>>>>>>
>>>>> Traditionally existing maintainers are the ones that add new
>>>>> maintainers, it's not something that you just submit a patch for hoping
>>>>> it will be accepted.
>>>>>
>>>>> What has changed since the last time you asked to do this?
>>>> Because public and private requests have gone unanswered for so long, it is
>>>> unclear if Moritz is still maintaining the subsystem.
>>> He is, as is evident by the patches I accept from him each merge.
>>>
>>>> The nearly year old xrt patchset has been pending for 6 weeks with minor
>>>> changes to one patch out of 14 needing reviews.
>>> Code quality is not the maintainer's job, it's the developer's, so the
>>> age and number of reviews is not any indication.
>> https://lore.kernel.org/linux-fpga/20210802160521.331031-1-lizhi.hou@xilinx.com/
>>
>> The review is needed because Moritz asked for the changes v8 here
>>
>> https://lore.kernel.org/linux-fpga/YP42zE2ljx4hHj40@epycbox.lan/
>>
>> When the maintainer asks for the changes, they are responsible for the
>> followup.
>>
>>>> The standard release patchset, which needs an opinion has on an api change,
>>>> has been outstanding for 8 weeks.
>>> Have a pointer to it?
>> This was a change you requested. the recent patchset is
>>
>> https://lore.kernel.org/linux-fpga/20210914214327.94048-4-russell.h.weight@intel.com/
>>
>> The discussion around the api change is
>>
>> https://lore.kernel.org/linux-fpga/661d53d0-0ba4-d344-8da0-995a9b612905@redhat.com/
>>
>> In these toss up's if the maintainer does not weigh in as the tie breaker,
>> the patch stalls.
>>
>>>> If maintainership depends on an approving maintainter, what happens when the
>>>> approving maintainer has left ?
>>> Vacations happen in the summer.  I've talked to Moritz many times, and
>>> all is well here.
>> Yes. in the xrt v9 patch Moritz announced late of a vacation with a return
>> of 9/4.
>>
>> It has been 11 days.
> I had a family issue that was unforseen combined with an unusual high
> post-vacation workload at $dayjob when I got back.
>
> I'm still catching up, and will get to it when I can.

I almost never take vacation because of the post vacation workload.

You not having backup is a problem.

Please consider taking the help I am offering.

Tom

>   
> - Moritz
>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer
  2021-09-16 12:41           ` Tom Rix
@ 2021-09-16 12:49             ` Greg KH
  2021-09-17  0:21               ` Dave Airlie
  0 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2021-09-16 12:49 UTC (permalink / raw)
  To: Tom Rix; +Cc: Moritz Fischer, hao.wu, linux-kernel, linux-fpga

On Thu, Sep 16, 2021 at 05:41:35AM -0700, Tom Rix wrote:
> 
> On 9/15/21 1:55 PM, Moritz Fischer wrote:
> > On Wed, Sep 15, 2021 at 09:12:51AM -0700, Tom Rix wrote:
> > > On 9/15/21 7:04 AM, Greg KH wrote:
> > > > On Wed, Sep 15, 2021 at 06:23:16AM -0700, Tom Rix wrote:
> > > > > On 9/14/21 11:58 AM, Greg KH wrote:
> > > > > > [note, you got the maintainer's email address wrong on your cc: line
> > > > > >     I fixed it up...]
> > > > > > 
> > > > > > On Tue, Sep 14, 2021 at 11:23:33AM -0700, trix@redhat.com wrote:
> > > > > > > From: Tom Rix <trix@redhat.com>
> > > > > > > 
> > > > > > > I am the maintainer of the fpga/ subsystem for both the kernel and
> > > > > > > userspace for Red Hat.  I have been an active reviewer and contributor
> > > > > > > on for public fpga/ subsystem for the last year.  I would like to
> > > > > > > help out more.
> > > > > > > 
> > > > > > > Since I am paid to do this work, change the status to Supported.
> > > > > > > 
> > > > > > > Signed-off-by: Tom Rix <trix@redhat.com>
> > > > > > > ---
> > > > > > >     MAINTAINERS | 4 ++--
> > > > > > >     1 file changed, 2 insertions(+), 2 deletions(-)
> > > > > > > 
> > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > > > index 04fa4edf100b83..0443d7ab826659 100644
> > > > > > > --- a/MAINTAINERS
> > > > > > > +++ b/MAINTAINERS
> > > > > > > @@ -7353,9 +7353,9 @@ F:	include/uapi/linux/fpga-dfl.h
> > > > > > >     FPGA MANAGER FRAMEWORK
> > > > > > >     M:	Moritz Fischer <mdf@kernel.org>
> > > > > > > -R:	Tom Rix <trix@redhat.com>
> > > > > > > +M:	Tom Rix <trix@redhat.com>
> > > > > > >     L:	linux-fpga@vger.kernel.org
> > > > > > > -S:	Maintained
> > > > > > > +S:	Supported
> > > > > > >     W:	http://www.rocketboards.org
> > > > > > >     Q:	http://patchwork.kernel.org/project/linux-fpga/list/
> > > > > > >     T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
> > > > > > > -- 
> > > > > > > 2.26.3
> > > > > > > 
> > > > > > Traditionally existing maintainers are the ones that add new
> > > > > > maintainers, it's not something that you just submit a patch for hoping
> > > > > > it will be accepted.
> > > > > > 
> > > > > > What has changed since the last time you asked to do this?
> > > > > Because public and private requests have gone unanswered for so long, it is
> > > > > unclear if Moritz is still maintaining the subsystem.
> > > > He is, as is evident by the patches I accept from him each merge.
> > > > 
> > > > > The nearly year old xrt patchset has been pending for 6 weeks with minor
> > > > > changes to one patch out of 14 needing reviews.
> > > > Code quality is not the maintainer's job, it's the developer's, so the
> > > > age and number of reviews is not any indication.
> > > https://lore.kernel.org/linux-fpga/20210802160521.331031-1-lizhi.hou@xilinx.com/
> > > 
> > > The review is needed because Moritz asked for the changes v8 here
> > > 
> > > https://lore.kernel.org/linux-fpga/YP42zE2ljx4hHj40@epycbox.lan/
> > > 
> > > When the maintainer asks for the changes, they are responsible for the
> > > followup.
> > > 
> > > > > The standard release patchset, which needs an opinion has on an api change,
> > > > > has been outstanding for 8 weeks.
> > > > Have a pointer to it?
> > > This was a change you requested. the recent patchset is
> > > 
> > > https://lore.kernel.org/linux-fpga/20210914214327.94048-4-russell.h.weight@intel.com/
> > > 
> > > The discussion around the api change is
> > > 
> > > https://lore.kernel.org/linux-fpga/661d53d0-0ba4-d344-8da0-995a9b612905@redhat.com/
> > > 
> > > In these toss up's if the maintainer does not weigh in as the tie breaker,
> > > the patch stalls.
> > > 
> > > > > If maintainership depends on an approving maintainter, what happens when the
> > > > > approving maintainer has left ?
> > > > Vacations happen in the summer.  I've talked to Moritz many times, and
> > > > all is well here.
> > > Yes. in the xrt v9 patch Moritz announced late of a vacation with a return
> > > of 9/4.
> > > 
> > > It has been 11 days.
> > I had a family issue that was unforseen combined with an unusual high
> > post-vacation workload at $dayjob when I got back.
> > 
> > I'm still catching up, and will get to it when I can.
> 
> I almost never take vacation because of the post vacation workload.

That is not sustainable, nor a requirement of a kernel maintainer.

> You not having backup is a problem.
> 
> Please consider taking the help I am offering.

You can not force yourself on others.  Moritz is doing a fine job,
please do not make it difficult.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer
  2021-09-16 12:49             ` Greg KH
@ 2021-09-17  0:21               ` Dave Airlie
  2021-09-17 16:38                 ` Moritz Fischer
  0 siblings, 1 reply; 10+ messages in thread
From: Dave Airlie @ 2021-09-17  0:21 UTC (permalink / raw)
  To: Greg KH; +Cc: Tom Rix, Moritz Fischer, hao.wu, LKML, linux-fpga

On Thu, 16 Sept 2021 at 22:50, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Sep 16, 2021 at 05:41:35AM -0700, Tom Rix wrote:
> >
> > On 9/15/21 1:55 PM, Moritz Fischer wrote:
> > > On Wed, Sep 15, 2021 at 09:12:51AM -0700, Tom Rix wrote:
> > > > On 9/15/21 7:04 AM, Greg KH wrote:
> > > > > On Wed, Sep 15, 2021 at 06:23:16AM -0700, Tom Rix wrote:
> > > > > > On 9/14/21 11:58 AM, Greg KH wrote:
> > > > > > > [note, you got the maintainer's email address wrong on your cc: line
> > > > > > >     I fixed it up...]
> > > > > > >
> > > > > > > On Tue, Sep 14, 2021 at 11:23:33AM -0700, trix@redhat.com wrote:
> > > > > > > > From: Tom Rix <trix@redhat.com>
> > > > > > > >
> > > > > > > > I am the maintainer of the fpga/ subsystem for both the kernel and
> > > > > > > > userspace for Red Hat.  I have been an active reviewer and contributor
> > > > > > > > on for public fpga/ subsystem for the last year.  I would like to
> > > > > > > > help out more.
> > > > > > > >
> > > > > > > > Since I am paid to do this work, change the status to Supported.
> > > > > > > >
> > > > > > > > Signed-off-by: Tom Rix <trix@redhat.com>
> > > > > > > > ---
> > > > > > > >     MAINTAINERS | 4 ++--
> > > > > > > >     1 file changed, 2 insertions(+), 2 deletions(-)
> > > > > > > >
> > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > > > > index 04fa4edf100b83..0443d7ab826659 100644
> > > > > > > > --- a/MAINTAINERS
> > > > > > > > +++ b/MAINTAINERS
> > > > > > > > @@ -7353,9 +7353,9 @@ F:  include/uapi/linux/fpga-dfl.h
> > > > > > > >     FPGA MANAGER FRAMEWORK
> > > > > > > >     M:    Moritz Fischer <mdf@kernel.org>
> > > > > > > > -R:       Tom Rix <trix@redhat.com>
> > > > > > > > +M:       Tom Rix <trix@redhat.com>
> > > > > > > >     L:    linux-fpga@vger.kernel.org
> > > > > > > > -S:       Maintained
> > > > > > > > +S:       Supported
> > > > > > > >     W:    http://www.rocketboards.org
> > > > > > > >     Q:    http://patchwork.kernel.org/project/linux-fpga/list/
> > > > > > > >     T:    git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
> > > > > > > > --
> > > > > > > > 2.26.3
> > > > > > > >
> > > > > > > Traditionally existing maintainers are the ones that add new
> > > > > > > maintainers, it's not something that you just submit a patch for hoping
> > > > > > > it will be accepted.
> > > > > > >
> > > > > > > What has changed since the last time you asked to do this?
> > > > > > Because public and private requests have gone unanswered for so long, it is
> > > > > > unclear if Moritz is still maintaining the subsystem.
> > > > > He is, as is evident by the patches I accept from him each merge.
> > > > >
> > > > > > The nearly year old xrt patchset has been pending for 6 weeks with minor
> > > > > > changes to one patch out of 14 needing reviews.
> > > > > Code quality is not the maintainer's job, it's the developer's, so the
> > > > > age and number of reviews is not any indication.
> > > > https://lore.kernel.org/linux-fpga/20210802160521.331031-1-lizhi.hou@xilinx.com/
> > > >
> > > > The review is needed because Moritz asked for the changes v8 here
> > > >
> > > > https://lore.kernel.org/linux-fpga/YP42zE2ljx4hHj40@epycbox.lan/
> > > >
> > > > When the maintainer asks for the changes, they are responsible for the
> > > > followup.
> > > >
> > > > > > The standard release patchset, which needs an opinion has on an api change,
> > > > > > has been outstanding for 8 weeks.
> > > > > Have a pointer to it?
> > > > This was a change you requested. the recent patchset is
> > > >
> > > > https://lore.kernel.org/linux-fpga/20210914214327.94048-4-russell.h.weight@intel.com/
> > > >
> > > > The discussion around the api change is
> > > >
> > > > https://lore.kernel.org/linux-fpga/661d53d0-0ba4-d344-8da0-995a9b612905@redhat.com/
> > > >
> > > > In these toss up's if the maintainer does not weigh in as the tie breaker,
> > > > the patch stalls.
> > > >
> > > > > > If maintainership depends on an approving maintainter, what happens when the
> > > > > > approving maintainer has left ?
> > > > > Vacations happen in the summer.  I've talked to Moritz many times, and
> > > > > all is well here.
> > > > Yes. in the xrt v9 patch Moritz announced late of a vacation with a return
> > > > of 9/4.
> > > >
> > > > It has been 11 days.
> > > I had a family issue that was unforseen combined with an unusual high
> > > post-vacation workload at $dayjob when I got back.
> > >
> > > I'm still catching up, and will get to it when I can.
> >
> > I almost never take vacation because of the post vacation workload.
>
> That is not sustainable, nor a requirement of a kernel maintainer.
>
> > You not having backup is a problem.
> >
> > Please consider taking the help I am offering.
>
> You can not force yourself on others.  Moritz is doing a fine job,
> please do not make it difficult.

I think it's probably up to Moritz to discuss this possibility with
Tom, but we should not be dismissing potential comaintainer roles
either, the bus factor is real, and being able to take time off
without things grinding to a halt is a welcome feature for everyone.

Dave.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer
  2021-09-17  0:21               ` Dave Airlie
@ 2021-09-17 16:38                 ` Moritz Fischer
  0 siblings, 0 replies; 10+ messages in thread
From: Moritz Fischer @ 2021-09-17 16:38 UTC (permalink / raw)
  To: Dave Airlie; +Cc: Greg KH, Tom Rix, Moritz Fischer, hao.wu, LKML, linux-fpga

Dave,

On Fri, Sep 17, 2021 at 10:21:27AM +1000, Dave Airlie wrote:
> On Thu, 16 Sept 2021 at 22:50, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Sep 16, 2021 at 05:41:35AM -0700, Tom Rix wrote:
> > >
> > > On 9/15/21 1:55 PM, Moritz Fischer wrote:
> > > > On Wed, Sep 15, 2021 at 09:12:51AM -0700, Tom Rix wrote:
> > > > > On 9/15/21 7:04 AM, Greg KH wrote:
> > > > > > On Wed, Sep 15, 2021 at 06:23:16AM -0700, Tom Rix wrote:
> > > > > > > On 9/14/21 11:58 AM, Greg KH wrote:
> > > > > > > > [note, you got the maintainer's email address wrong on your cc: line
> > > > > > > >     I fixed it up...]
> > > > > > > >
> > > > > > > > On Tue, Sep 14, 2021 at 11:23:33AM -0700, trix@redhat.com wrote:
> > > > > > > > > From: Tom Rix <trix@redhat.com>
> > > > > > > > >
> > > > > > > > > I am the maintainer of the fpga/ subsystem for both the kernel and
> > > > > > > > > userspace for Red Hat.  I have been an active reviewer and contributor
> > > > > > > > > on for public fpga/ subsystem for the last year.  I would like to
> > > > > > > > > help out more.
> > > > > > > > >
> > > > > > > > > Since I am paid to do this work, change the status to Supported.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Tom Rix <trix@redhat.com>
> > > > > > > > > ---
> > > > > > > > >     MAINTAINERS | 4 ++--
> > > > > > > > >     1 file changed, 2 insertions(+), 2 deletions(-)
> > > > > > > > >
> > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > > > > > index 04fa4edf100b83..0443d7ab826659 100644
> > > > > > > > > --- a/MAINTAINERS
> > > > > > > > > +++ b/MAINTAINERS
> > > > > > > > > @@ -7353,9 +7353,9 @@ F:  include/uapi/linux/fpga-dfl.h
> > > > > > > > >     FPGA MANAGER FRAMEWORK
> > > > > > > > >     M:    Moritz Fischer <mdf@kernel.org>
> > > > > > > > > -R:       Tom Rix <trix@redhat.com>
> > > > > > > > > +M:       Tom Rix <trix@redhat.com>
> > > > > > > > >     L:    linux-fpga@vger.kernel.org
> > > > > > > > > -S:       Maintained
> > > > > > > > > +S:       Supported
> > > > > > > > >     W:    http://www.rocketboards.org
> > > > > > > > >     Q:    http://patchwork.kernel.org/project/linux-fpga/list/
> > > > > > > > >     T:    git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
> > > > > > > > > --
> > > > > > > > > 2.26.3
> > > > > > > > >
> > > > > > > > Traditionally existing maintainers are the ones that add new
> > > > > > > > maintainers, it's not something that you just submit a patch for hoping
> > > > > > > > it will be accepted.
> > > > > > > >
> > > > > > > > What has changed since the last time you asked to do this?
> > > > > > > Because public and private requests have gone unanswered for so long, it is
> > > > > > > unclear if Moritz is still maintaining the subsystem.
> > > > > > He is, as is evident by the patches I accept from him each merge.
> > > > > >
> > > > > > > The nearly year old xrt patchset has been pending for 6 weeks with minor
> > > > > > > changes to one patch out of 14 needing reviews.
> > > > > > Code quality is not the maintainer's job, it's the developer's, so the
> > > > > > age and number of reviews is not any indication.
> > > > > https://lore.kernel.org/linux-fpga/20210802160521.331031-1-lizhi.hou@xilinx.com/
> > > > >
> > > > > The review is needed because Moritz asked for the changes v8 here
> > > > >
> > > > > https://lore.kernel.org/linux-fpga/YP42zE2ljx4hHj40@epycbox.lan/
> > > > >
> > > > > When the maintainer asks for the changes, they are responsible for the
> > > > > followup.
> > > > >
> > > > > > > The standard release patchset, which needs an opinion has on an api change,
> > > > > > > has been outstanding for 8 weeks.
> > > > > > Have a pointer to it?
> > > > > This was a change you requested. the recent patchset is
> > > > >
> > > > > https://lore.kernel.org/linux-fpga/20210914214327.94048-4-russell.h.weight@intel.com/
> > > > >
> > > > > The discussion around the api change is
> > > > >
> > > > > https://lore.kernel.org/linux-fpga/661d53d0-0ba4-d344-8da0-995a9b612905@redhat.com/
> > > > >
> > > > > In these toss up's if the maintainer does not weigh in as the tie breaker,
> > > > > the patch stalls.
> > > > >
> > > > > > > If maintainership depends on an approving maintainter, what happens when the
> > > > > > > approving maintainer has left ?
> > > > > > Vacations happen in the summer.  I've talked to Moritz many times, and
> > > > > > all is well here.
> > > > > Yes. in the xrt v9 patch Moritz announced late of a vacation with a return
> > > > > of 9/4.
> > > > >
> > > > > It has been 11 days.
> > > > I had a family issue that was unforseen combined with an unusual high
> > > > post-vacation workload at $dayjob when I got back.
> > > >
> > > > I'm still catching up, and will get to it when I can.
> > >
> > > I almost never take vacation because of the post vacation workload.
> >
> > That is not sustainable, nor a requirement of a kernel maintainer.
> >
> > > You not having backup is a problem.
> > >
> > > Please consider taking the help I am offering.
> >
> > You can not force yourself on others.  Moritz is doing a fine job,
> > please do not make it difficult.
> 
> I think it's probably up to Moritz to discuss this possibility with
> Tom, but we should not be dismissing potential comaintainer roles
> either, the bus factor is real, and being able to take time off
> without things grinding to a halt is a welcome feature for everyone.

I'm not generally opposed to having another maintainer to take patches
for the times I'm out or get hit by a bus. However, I don't feel like
being bullied into this.

Between off-list emails, attempts to go behind my back emailing people
complaining about me, declaring himself maintainer and pro-claiming
there's a new repo for linux-fpga over the last year and some, I've just
about had enough of this sh*t. This is not how this works.

There are plenty of folks around that also help out and that I'd much
rather work with at this point -- if just to skip the drama.

So for now NAK on this patch from my end.

Cheers,
Moritz

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-09-17 16:38 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14 18:23 [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer trix
2021-09-14 18:58 ` Greg KH
2021-09-15 13:23   ` Tom Rix
2021-09-15 14:04     ` Greg KH
2021-09-15 16:12       ` Tom Rix
2021-09-15 20:55         ` Moritz Fischer
2021-09-16 12:41           ` Tom Rix
2021-09-16 12:49             ` Greg KH
2021-09-17  0:21               ` Dave Airlie
2021-09-17 16:38                 ` Moritz Fischer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).