Re: [PATCH] fpga: ice40-spi: Add SPI device ID table

Re: [PATCH] fpga: ice40-spi: Add SPI device ID table

[Moritz Fischer]

On Mon, Sep 27, 2021 at 02:44:03PM +0100, Mark Brown wrote:
> Currently autoloading for SPI devices does not use the DT ID table, it uses
> SPI modalises. Supporting OF modalises is going to be difficult if not
> impractical, an attempt was made but has been reverted, so ensure that
> module autoloading works for this driver by adding a SPI ID table.
> 
> Fixes: 96c8395e2166 ("spi: Revert modalias changes")
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  drivers/fpga/ice40-spi.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/fpga/ice40-spi.c b/drivers/fpga/ice40-spi.c
> index 69dec5af23c3..029d3cdb918d 100644
> --- a/drivers/fpga/ice40-spi.c
> +++ b/drivers/fpga/ice40-spi.c
> @@ -192,12 +192,19 @@ static const struct of_device_id ice40_fpga_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, ice40_fpga_of_match);
>  
> +static const struct spi_device_id ice40_fpga_spi_ids[] = {
> +	{ .name = "ice40-fpga-mgr", },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(spi, ice40_fpga_spi_ids);
> +
>  static struct spi_driver ice40_fpga_driver = {
>  	.probe = ice40_fpga_probe,
>  	.driver = {
>  		.name = "ice40spi",
>  		.of_match_table = of_match_ptr(ice40_fpga_of_match),
>  	},
> +	.id_table = ice40_fpga_spi_ids,
>  };
>  
>  module_spi_driver(ice40_fpga_driver);
> -- 
> 2.20.1
> 

Applied to fixes,

Thanks

[PATCH 1/2] MAINTAINERS: Add Hao and Yilun as maintainers

[Moritz Fischer]

Hao and Yilun have agreed to help out with maintenance.
Both have been active in the Linux FPGA community for a long time
and we need backups for vacation and load-balancing.

Cc: Xu Yilun <yilun.xu@intel.com>
Cc: Wu Hao <hao.wu@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index eeb4c70b3d5b..2ec4c2a2458a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7337,6 +7337,8 @@ F:	include/uapi/linux/fpga-dfl.h
 
 FPGA MANAGER FRAMEWORK
 M:	Moritz Fischer <mdf@kernel.org>
+M:	Wu Hao <hao.wu@intel.com>
+M:	Xu Yilun <yilun.xu@intel.com>
 R:	Tom Rix <trix@redhat.com>
 L:	linux-fpga@vger.kernel.org
 S:	Maintained
-- 
2.33.0

[PATCH 2/2] MAINTAINERS: Drop outdated FPGA Manager website

[Moritz Fischer]

The rocketboards website no longer really reflects a good landing
place for people interested in FPGA Manager.

Cc: Xu Yilun <yilun.xu@intel.com>
Cc: Wu Hao <hao.wu@intel.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2ec4c2a2458a..c4eaac287edb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7342,7 +7342,6 @@ M:	Xu Yilun <yilun.xu@intel.com>
 R:	Tom Rix <trix@redhat.com>
 L:	linux-fpga@vger.kernel.org
 S:	Maintained
-W:	http://www.rocketboards.org
 Q:	http://patchwork.kernel.org/project/linux-fpga/list/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
 F:	Documentation/devicetree/bindings/fpga/
-- 
2.33.0

[PATCH] fpga: ice40-spi: Add SPI device ID table

[Moritz Fischer]

From: Mark Brown <broonie@kernel.org>

Currently autoloading for SPI devices does not use the DT ID table, it uses
SPI modalises. Supporting OF modalises is going to be difficult if not
impractical, an attempt was made but has been reverted, so ensure that
module autoloading works for this driver by adding a SPI ID table.

Fixes: 96c8395e2166 ("spi: Revert modalias changes")
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/fpga/ice40-spi.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/fpga/ice40-spi.c b/drivers/fpga/ice40-spi.c
index 69dec5af23c3..029d3cdb918d 100644
--- a/drivers/fpga/ice40-spi.c
+++ b/drivers/fpga/ice40-spi.c
@@ -192,12 +192,19 @@ static const struct of_device_id ice40_fpga_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, ice40_fpga_of_match);
 
+static const struct spi_device_id ice40_fpga_spi_ids[] = {
+	{ .name = "ice40-fpga-mgr", },
+	{},
+};
+MODULE_DEVICE_TABLE(spi, ice40_fpga_spi_ids);
+
 static struct spi_driver ice40_fpga_driver = {
 	.probe = ice40_fpga_probe,
 	.driver = {
 		.name = "ice40spi",
 		.of_match_table = of_match_ptr(ice40_fpga_of_match),
 	},
+	.id_table = ice40_fpga_spi_ids,
 };
 
 module_spi_driver(ice40_fpga_driver);
-- 
2.20.1

Re: [PATCH] fpga: ice40-spi: Add SPI device ID table

[Moritz Fischer]

On Mon, Sep 27, 2021 at 02:44:03PM +0100, Mark Brown wrote:
> Currently autoloading for SPI devices does not use the DT ID table, it uses
> SPI modalises. Supporting OF modalises is going to be difficult if not
> impractical, an attempt was made but has been reverted, so ensure that
> module autoloading works for this driver by adding a SPI ID table.
> 
> Fixes: 96c8395e2166 ("spi: Revert modalias changes")
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  drivers/fpga/ice40-spi.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/fpga/ice40-spi.c b/drivers/fpga/ice40-spi.c
> index 69dec5af23c3..029d3cdb918d 100644
> --- a/drivers/fpga/ice40-spi.c
> +++ b/drivers/fpga/ice40-spi.c
> @@ -192,12 +192,19 @@ static const struct of_device_id ice40_fpga_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, ice40_fpga_of_match);
>  
> +static const struct spi_device_id ice40_fpga_spi_ids[] = {
> +	{ .name = "ice40-fpga-mgr", },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(spi, ice40_fpga_spi_ids);
> +
>  static struct spi_driver ice40_fpga_driver = {
>  	.probe = ice40_fpga_probe,
>  	.driver = {
>  		.name = "ice40spi",
>  		.of_match_table = of_match_ptr(ice40_fpga_of_match),
>  	},
> +	.id_table = ice40_fpga_spi_ids,
>  };
>  
>  module_spi_driver(ice40_fpga_driver);
> -- 
> 2.20.1
> 

Ehr .. please ignore that ... I fatfingered sending that patch again.

Sorry for the noise ...

- Moritz

Re: [PATCH 1/2] MAINTAINERS: Add Hao and Yilun as maintainers

[Greg Kroah-Hartman]

On Tue, Sep 28, 2021 at 08:02:25AM -0700, Moritz Fischer wrote:
> Hao and Yilun have agreed to help out with maintenance.
> Both have been active in the Linux FPGA community for a long time
> and we need backups for vacation and load-balancing.
> 
> Cc: Xu Yilun <yilun.xu@intel.com>
> Cc: Wu Hao <hao.wu@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

I need an ack from the two new people here in order to take this :)

thanks,

greg k-h

Re: [PATCH 1/2] MAINTAINERS: Add Hao and Yilun as maintainers

[Xu Yilun]

On Tue, Sep 28, 2021 at 05:28:39PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 28, 2021 at 08:02:25AM -0700, Moritz Fischer wrote:
> > Hao and Yilun have agreed to help out with maintenance.
> > Both have been active in the Linux FPGA community for a long time
> > and we need backups for vacation and load-balancing.
> > 
> > Cc: Xu Yilun <yilun.xu@intel.com>
> > Cc: Wu Hao <hao.wu@intel.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> I need an ack from the two new people here in order to take this :)

Acked-by: Xu Yilun <yilun.xu@intel.com>

Thanks,
Yilun

> 
> thanks,
> 
> greg k-h

RE: [PATCH 1/2] MAINTAINERS: Add Hao and Yilun as maintainers

[Wu, Hao]

> On Tue, Sep 28, 2021 at 05:28:39PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Sep 28, 2021 at 08:02:25AM -0700, Moritz Fischer wrote:
> > > Hao and Yilun have agreed to help out with maintenance.
> > > Both have been active in the Linux FPGA community for a long time
> > > and we need backups for vacation and load-balancing.
> > >
> > > Cc: Xu Yilun <yilun.xu@intel.com>
> > > Cc: Wu Hao <hao.wu@intel.com>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > I need an ack from the two new people here in order to take this :)
> 
> Acked-by: Xu Yilun <yilun.xu@intel.com>

Acked-by: Wu Hao <hao.wu@intel.com>

Thanks
Hao

> 
> Thanks,
> Yilun
> 
> >
> > thanks,
> >
> > greg k-h

Re: [PATCH 1/2] MAINTAINERS: Add Hao and Yilun as maintainers

[Moritz Fischer]

On Wed, Sep 29, 2021 at 01:04:54AM +0000, Wu, Hao wrote:
> > On Tue, Sep 28, 2021 at 05:28:39PM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Sep 28, 2021 at 08:02:25AM -0700, Moritz Fischer wrote:
> > > > Hao and Yilun have agreed to help out with maintenance.
> > > > Both have been active in the Linux FPGA community for a long time
> > > > and we need backups for vacation and load-balancing.
> > > >
> > > > Cc: Xu Yilun <yilun.xu@intel.com>
> > > > Cc: Wu Hao <hao.wu@intel.com>
> > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >
> > > I need an ack from the two new people here in order to take this :)
> > 
> > Acked-by: Xu Yilun <yilun.xu@intel.com>
> 
> Acked-by: Wu Hao <hao.wu@intel.com>
> 
> Thanks
> Hao
> 
> > 
> > Thanks,
> > Yilun
> > 
> > >
> > > thanks,
> > >
> > > greg k-h

Applied to for-next,

Moritz

Re: [PATCH 2/2] MAINTAINERS: Drop outdated FPGA Manager website

[Xu Yilun]

On Tue, Sep 28, 2021 at 08:02:26AM -0700, Moritz Fischer wrote:
> The rocketboards website no longer really reflects a good landing
> place for people interested in FPGA Manager.
> 
> Cc: Xu Yilun <yilun.xu@intel.com>
> Cc: Wu Hao <hao.wu@intel.com>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
>  MAINTAINERS | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2ec4c2a2458a..c4eaac287edb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7342,7 +7342,6 @@ M:	Xu Yilun <yilun.xu@intel.com>
>  R:	Tom Rix <trix@redhat.com>
>  L:	linux-fpga@vger.kernel.org
>  S:	Maintained
> -W:	http://www.rocketboards.org

The website is mostly about SOCFPGA architecture, while the FPGA Manager
is mainly about the generic image loading and enumeration framework. So
I'm good to this change.

People could still find the website at ARM/SOCFPGA ARCHITECTURE, which is a
better place for it.

Acked-by: Xu Yilun <yilun.xu@intel.com>

Thanks,
Yilun

>  Q:	http://patchwork.kernel.org/project/linux-fpga/list/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
>  F:	Documentation/devicetree/bindings/fpga/
> -- 
> 2.33.0

Re: [PATCH 2/2] MAINTAINERS: Drop outdated FPGA Manager website

[Moritz Fischer]

On Sat, Oct 02, 2021 at 10:49:57PM +0800, Xu Yilun wrote:
> On Tue, Sep 28, 2021 at 08:02:26AM -0700, Moritz Fischer wrote:
> > The rocketboards website no longer really reflects a good landing
> > place for people interested in FPGA Manager.
> > 
> > Cc: Xu Yilun <yilun.xu@intel.com>
> > Cc: Wu Hao <hao.wu@intel.com>
> > Signed-off-by: Moritz Fischer <mdf@kernel.org>
> > ---
> >  MAINTAINERS | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 2ec4c2a2458a..c4eaac287edb 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -7342,7 +7342,6 @@ M:	Xu Yilun <yilun.xu@intel.com>
> >  R:	Tom Rix <trix@redhat.com>
> >  L:	linux-fpga@vger.kernel.org
> >  S:	Maintained
> > -W:	http://www.rocketboards.org
> 
> The website is mostly about SOCFPGA architecture, while the FPGA Manager
> is mainly about the generic image loading and enumeration framework. So
> I'm good to this change.
> 
> People could still find the website at ARM/SOCFPGA ARCHITECTURE, which is a
> better place for it.
> 
> Acked-by: Xu Yilun <yilun.xu@intel.com>
> 
> Thanks,
> Yilun
> 
> >  Q:	http://patchwork.kernel.org/project/linux-fpga/list/
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
> >  F:	Documentation/devicetree/bindings/fpga/
> > -- 
> > 2.33.0

Applied to for-next,

Thanks