From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E179C433F5 for ; Tue, 4 Oct 2022 14:56:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbiJDOzM (ORCPT ); Tue, 4 Oct 2022 10:55:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbiJDOzK (ORCPT ); Tue, 4 Oct 2022 10:55:10 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C36261C41D; Tue, 4 Oct 2022 07:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664895309; x=1696431309; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ukW3DZ9qfunc0cxq05UBGyWkbgjuOQ47AszS9nmdg1s=; b=I/2wBLX7MnppNRCwmGrb3Xn+2wbfuD8ckVTLJG56yKeLd1lqROMXgPSA 2nXRSN2D+bkUlRygV0+MJHEjREe4TvE25is5/sQMCKOK9IaAhSrObCrN4 x/i7IZnVv0QTGE8Dp3AbTHJhlJ3IBCZR22OZFdPwZwsevJ2OaMP56oAOC +Xb3kr7xVqKA+FWhnacd9bGe9XWr5LdQPUdBfQDFuhpMyJoLkIvw/SpGE 11Y3ZWJjfHBon6VWQU55jgz9YPjtZ9vPLRtX5OoxGy5hXBw8ywyNp36H6 gCRurCtTS/C7iMCEMqbSKHQPhiWXfnrnZdlZt0aLLPK7nCJMtxgGz9uPM w==; X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="286119981" X-IronPort-AV: E=Sophos;i="5.95,158,1661842800"; d="scan'208";a="286119981" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 07:55:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="575050547" X-IronPort-AV: E=Sophos;i="5.95,158,1661842800"; d="scan'208";a="575050547" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 04 Oct 2022 07:55:03 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ofjK1-0027Uz-0y; Tue, 04 Oct 2022 17:55:01 +0300 Date: Tue, 4 Oct 2022 17:55:01 +0300 From: Andy Shevchenko To: matthew.gerlach@linux.intel.com Cc: hao.wu@intel.com, yilun.xu@intel.com, russell.h.weight@intel.com, basheer.ahmed.muddebihal@intel.com, trix@redhat.com, mdf@kernel.org, linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, tianfei.zhang@intel.com, corbet@lwn.net, gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, jirislaby@kernel.org, geert+renesas@glider.be, niklas.soderlund+renesas@ragnatech.se, macro@orcam.me.uk, johan@kernel.org, lukas@wunner.de, Basheer Ahmed Muddebihal Subject: Re: [PATCH v3 2/4] fpga: dfl: Add DFHv1 Register Definitions Message-ID: References: <20221004143718.1076710-1-matthew.gerlach@linux.intel.com> <20221004143718.1076710-3-matthew.gerlach@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221004143718.1076710-3-matthew.gerlach@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On Tue, Oct 04, 2022 at 07:37:16AM -0700, matthew.gerlach@linux.intel.com wrote: > From: Basheer Ahmed Muddebihal > > This patch adds the definitions for DFHv1 header and related register > bitfields. ... > - * Copyright (C) 2017-2018 Intel Corporation, Inc. > + * Copyright (C) 2017-2022 Intel Corporation, Inc. I do not think this is correct. What happened to the code in 2019, 2020, and 2021? It's unclear. Have you consulted with our lawyer about this? That said, I _think_ (not your lawyer though) that the correct one should be * Copyright (C) 2017-2018,2022 Intel Corporation, Inc. If you wanted to correct that, perhaps it should be done in a separate patch first with explanation for those years in the gap. Unfortunately I haven't found any description for those. Ditto for the rest similar cases. -- With Best Regards, Andy Shevchenko