Re: [PATCH v2 1/2] spi: Add DFL bus driver for Altera SPI Master

From: matthew.gerlach@linux.intel.com
To: Mark Brown <broonie@kernel.org>
Cc: hao.wu@intel.com, trix@redhat.com, mdf@kernel.org,
	linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
	yilun.xu@intel.com, jdelvare@suse.com, linux@roeck-us.net,
	lee.jones@linaro.org, linux-hwmon@vger.kernel.org,
	russell.h.weight@intel.com, linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 1/2] spi: Add DFL bus driver for Altera SPI Master
Date: Wed, 14 Apr 2021 12:09:50 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2104141203480.482712@rhweight-WRK1> (raw)
In-Reply-To: <20210414141816.GD4535@sirena.org.uk>

On Wed, 14 Apr 2021, Mark Brown wrote:

> On Tue, Apr 13, 2021 at 03:58:34PM -0700, matthew.gerlach@linux.intel.com wrote:
>
>> +++ b/drivers/spi/spi-altera-dfl.c
>> @@ -0,0 +1,222 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * DFL bus driver for Altera SPI Master
>> + *
>
> Please make the entire comment a C++ one so things look more
> intentional.

Ok, I'll change it in the next revision.

>
>> +	memset(&pdevinfo, 0, sizeof(pdevinfo));
>> +
>> +	pdevinfo.name = "subdev_spi_altera";
>> +	pdevinfo.id = PLATFORM_DEVID_AUTO;
>> +	pdevinfo.parent = dev;
>> +	pdevinfo.data = &pdata;
>> +	pdevinfo.size_data = sizeof(pdata);
>> +
>> +	return platform_device_register_full(&pdevinfo);
>
> Don't create a platform device here, extend the spi-altera driver to
> register with both DFL and platform buses.
>

Are you suggesting something like the SPI driver for the Designware 
controller where there is spi-dw-core.c and bus specific code like 
spi-dw-pci.c and spi-dw-mmioc.c?

Thanks for the review.

Matthew