From: Tom Rix <trix@redhat.com>
To: "Martin Hundebøll" <mhu@silicom.dk>,
"Martin Hundebøll" <martin@geanix.com>,
"Wu Hao" <hao.wu@intel.com>, "Moritz Fischer" <mdf@kernel.org>,
"Xu Yilun" <yilun.xu@intel.com>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Lee Jones" <lee.jones@linaro.org>,
"Mark Brown" <broonie@kernel.org>
Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-spi@vger.kernel.org,
Matthew Gerlach <matthew.gerlach@linux.intel.com>
Subject: Re: [PATCH v4 1/4] fpga: dfl: expose feature revision from struct dfl_device
Date: Wed, 14 Jul 2021 07:30:17 -0700 [thread overview]
Message-ID: <cf535684-52fa-d4c6-fe40-77d3a6c043d5@redhat.com> (raw)
In-Reply-To: <4ffd5153-e182-c615-0a81-2f5dad4979f5@silicom.dk>
On 7/14/21 4:14 AM, Martin Hundebøll wrote:
>
>
> On 06/07/2021 16.10, Tom Rix wrote:
>>> diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
>>> index 511b20ff35a3..9381c579d1cd 100644
>>> --- a/drivers/fpga/dfl.c
>>> +++ b/drivers/fpga/dfl.c
>>> @@ -381,6 +381,7 @@ dfl_dev_add(struct dfl_feature_platform_data
>>> *pdata,
>>> ddev->type = feature_dev_id_type(pdev);
>>> ddev->feature_id = feature->id;
>>> + ddev->revision = feature->revision;
>>> ddev->cdev = pdata->dfl_cdev;
>>> /* add mmio resource */
>>> @@ -717,6 +718,7 @@ struct build_feature_devs_info {
>>> */
>>> struct dfl_feature_info {
>>> u16 fid;
>>> + u8 rev;
>>
>> In other places 'revision' is the element name.
>>
>> For consistency, change rev to revision
>
> So is fid vs. feature. I deliberately chose 'rev' to be consistent
> with other elements in struct dfl_feature_info.
Consistence for revision is important because we want to make it easy
for folks using grep to search for one string not several.
fid vs feature_id is a problem, but one you do not need to solve.
Tom
>
> // Martin
>
next prev parent reply other threads:[~2021-07-14 14:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 10:16 [PATCH v4 0/4] fpga/mfd/hwmon: Initial support for Silicom N5010 PAC Martin Hundebøll
2021-07-05 10:16 ` [PATCH v4 1/4] fpga: dfl: expose feature revision from struct dfl_device Martin Hundebøll
2021-07-06 14:10 ` Tom Rix
2021-07-14 11:14 ` Martin Hundebøll
2021-07-14 14:30 ` Tom Rix [this message]
2021-07-05 10:16 ` [PATCH v4 2/4] spi: spi-altera-dfl: support n5010 feature revision Martin Hundebøll
2021-07-06 14:56 ` Tom Rix
2021-07-14 11:33 ` Martin Hundebøll
2021-07-14 14:22 ` Tom Rix
2021-07-14 14:27 ` Martin Hundebøll
2021-07-05 10:16 ` [PATCH v4 3/4] mfd: intel-m10-bmc: add n5010 variant Martin Hundebøll
2021-07-05 10:16 ` [PATCH v4 4/4] hwmon: intel-m10-bmc-hwmon: add n5010 sensors Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf535684-52fa-d4c6-fe40-77d3a6c043d5@redhat.com \
--to=trix@redhat.com \
--cc=broonie@kernel.org \
--cc=hao.wu@intel.com \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin@geanix.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=mhu@silicom.dk \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).