From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA7EC48BCF for ; Wed, 9 Jun 2021 13:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C03E613AD for ; Wed, 9 Jun 2021 13:27:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233372AbhFIN3F (ORCPT ); Wed, 9 Jun 2021 09:29:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49303 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233367AbhFIN3E (ORCPT ); Wed, 9 Jun 2021 09:29:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623245229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ohr3+N5+xISuDSpVy5HLd2jlXJtsoJDH7zUknKOaVE=; b=Pbyq3avq+eG3xosDAZfc/FYyJPgsaM0fpzrMWk5XkcMXPxIJp3RDJ8EvM9v2TVrHw+HbkZ QizTg0RUgQz5/Ttx/dhS2fuZ5QnFoiKvteK8bW6xD4ziet8a3iy+vxDp4hii6HhRjlWcIf RgIGp44yaYMF1F5HbWll3GuxRBC5kPE= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-521-BPzSPtNQMHS0sQCELRq5dA-1; Wed, 09 Jun 2021 09:27:08 -0400 X-MC-Unique: BPzSPtNQMHS0sQCELRq5dA-1 Received: by mail-ot1-f70.google.com with SMTP id x2-20020a9d62820000b02902e4ff743c4cso16300450otk.8 for ; Wed, 09 Jun 2021 06:27:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=9ohr3+N5+xISuDSpVy5HLd2jlXJtsoJDH7zUknKOaVE=; b=VM1L1BycglOf8w4FaDo1ggaqvg6TFGXXPwRjoTd68MGJ2NWFQ2U58XwRoobG2QnFPe wjf209lqmoxr++l+VqFzY9Se/yQo1LgkfGaGS0AGObNZmiJaozef/g5uOjofxEAkouGe DlUuRINGXjBxtW9fdcAXPnO+tMYfPPxnSnlaE6Bkdy7J8CYe3llykbFDeOVyzWF3v628 rXy/6KazCXQThUI/5JTDGWfT7dd05oVKaCwFmhmLjgfitmkSVXMOANOQfD1qH1MiV1Lj 68PaIBKz+7o+6DHtjVtuBzLUjbyCX84vRkbtCDiGYrcG+izkmr5+hSH30wN7Cbx4Hczn bKUA== X-Gm-Message-State: AOAM532dzZAB3rsEDgiRk7cEiuiYAPescWnhtiaDcjWImwfOX7x+hq4A oKhipPfXX2pfNMENagcUI5wrC6fUzmCqqtxcCmvXLxenX1IjFJcQBN/mx5lD4kGl/DVooNRVSy/ miGa8VDkAM0Rpwx911Sbcjw== X-Received: by 2002:a9d:7096:: with SMTP id l22mr1480955otj.79.1623245227431; Wed, 09 Jun 2021 06:27:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxknDhyZXQ2dREilj+RsfQ2CcUmDo/spMg54cPqAUNtnKCISJ8SIDWlXQ2kuypYzZqZH5QCnA== X-Received: by 2002:a9d:7096:: with SMTP id l22mr1480942otj.79.1623245227268; Wed, 09 Jun 2021 06:27:07 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id z14sm3760901oti.29.2021.06.09.06.27.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 06:27:07 -0700 (PDT) Subject: Re: [PATCH 6/7] fpga: xilinx: remove xilinx- prefix on files To: Greg KH Cc: mdf@kernel.org, michal.simek@xilinx.com, nava.manne@xilinx.com, luca@lucaceresoli.net, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210608162551.3010533-1-trix@redhat.com> From: Tom Rix Message-ID: Date: Wed, 9 Jun 2021 06:27:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 6/9/21 2:59 AM, Greg KH wrote: > On Tue, Jun 08, 2021 at 09:25:51AM -0700, trix@redhat.com wrote: >> From: Tom Rix >> >> It is not necessary to have a xilinx- prefix on a file >> when the file is in a xilinx/ subdir. >> >> Signed-off-by: Tom Rix >> --- >> drivers/fpga/xilinx/Makefile | 4 ++-- >> drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0 >> drivers/fpga/xilinx/{xilinx-spi.c => spi.c} | 0 >> 3 files changed, 2 insertions(+), 2 deletions(-) >> rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%) >> rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%) >> >> diff --git a/drivers/fpga/xilinx/Makefile b/drivers/fpga/xilinx/Makefile >> index 7bb7543412790..4ac727d03e140 100644 >> --- a/drivers/fpga/xilinx/Makefile >> +++ b/drivers/fpga/xilinx/Makefile >> @@ -1,7 +1,7 @@ >> # SPDX-License-Identifier: GPL-2.0 >> >> -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o >> -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o >> +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o >> +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o > You just renamed the module to be called "spi.ko"???? > > Did you test this thing? You can not rename modules without good > reasons, and calling a device specific kernel module "spi.ko" is not ok. yes, this is a problem, I will drop the renaming patches. Tom > greg k-h >