From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79A6CC433E0 for ; Tue, 26 Jan 2021 13:40:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A6572223D for ; Tue, 26 Jan 2021 13:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391958AbhAZNjl (ORCPT ); Tue, 26 Jan 2021 08:39:41 -0500 Received: from mga11.intel.com ([192.55.52.93]:52653 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392690AbhAZNje (ORCPT ); Tue, 26 Jan 2021 08:39:34 -0500 IronPort-SDR: cNJdLxyKjbdrnq5AEIne49BoqK1RhzeTzYZvckey0vJI3ADXjrQ3OSCaCwN7Fq3rkNwhZ29IdG Vz/u8AosiP3Q== X-IronPort-AV: E=McAfee;i="6000,8403,9875"; a="176390416" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="176390416" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 05:37:37 -0800 IronPort-SDR: RIU2LCL36R7kbA6UP0kB3ccuaFbVz2wYJXgoEoDF7X3QWQemGpOQHFM6pAslaobQyuVhnbhy1i q83oskIH/s6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="356725435" Received: from marshy.an.intel.com (HELO [10.122.105.143]) ([10.122.105.143]) by orsmga006.jf.intel.com with ESMTP; 26 Jan 2021 05:37:36 -0800 Subject: Re: [PATCHv3 5/6] dt-bindings: fpga: add authenticate-fpga-config property To: Moritz Fischer Cc: trix@redhat.com, gregkh@linuxfoundation.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, dinguyen@kernel.org, sridhar.rajagopal@intel.com, Richard Gong References: <1611608188-25621-1-git-send-email-richard.gong@linux.intel.com> <1611608188-25621-6-git-send-email-richard.gong@linux.intel.com> From: Richard Gong Message-ID: Date: Tue, 26 Jan 2021 07:58:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 1/25/21 11:05 PM, Moritz Fischer wrote: > On Mon, Jan 25, 2021 at 02:56:27PM -0600, richard.gong@linux.intel.com wrote: >> From: Richard Gong >> >> Add authenticate-fpga-config property for FPGA bitstream authentication, >> which makes sure a signed bitstream has valid signatures. >> >> Signed-off-by: Richard Gong >> --- >> v3: no change >> v2: put authenticate-fpga-config above partial-fpga-config >> update commit messages >> --- >> Documentation/devicetree/bindings/fpga/fpga-region.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/fpga/fpga-region.txt b/Documentation/devicetree/bindings/fpga/fpga-region.txt >> index e811cf8..d0d3234 100644 >> --- a/Documentation/devicetree/bindings/fpga/fpga-region.txt >> +++ b/Documentation/devicetree/bindings/fpga/fpga-region.txt >> @@ -182,6 +182,7 @@ Optional properties: >> This property is optional if the FPGA Manager handles the bridges. >> If the fpga-region is the child of a fpga-bridge, the list should not >> contain the parent bridge. >> +- authenticate-fpga-config : boolean, set if do bitstream authentication only. > I don't understand. Can I do authenticate-fpga-config AND > partial-fpga-config? Yes, but not simultaneously. Flag authenticate-fpga-config is used to first check the integrity of the bitstream. If the authentication passes, the user can perform a full or partial configuration to actually configure the bistream to device. >> - partial-fpga-config : boolean, set if partial reconfiguration is to be done, >> otherwise full reconfiguration is done. >> - external-fpga-config : boolean, set if the FPGA has already been configured >> -- >> 2.7.4 >> > Please clarify, > > Moritz > Regards, Richard