From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F37FBC433DF for ; Fri, 31 Jul 2020 17:40:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D689A2083B for ; Fri, 31 Jul 2020 17:40:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="swUCq2zU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733194AbgGaRkp (ORCPT ); Fri, 31 Jul 2020 13:40:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732973AbgGaRkp (ORCPT ); Fri, 31 Jul 2020 13:40:45 -0400 Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49285C061574 for ; Fri, 31 Jul 2020 10:40:45 -0700 (PDT) Received: by mail-qv1-xf44.google.com with SMTP id a19so8483765qvy.3 for ; Fri, 31 Jul 2020 10:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5b8eKT5y5KskA+QTSo5NaqnD5JNjajpt9hUsqgHyMPA=; b=swUCq2zUyU/s9P2gacLhfJB8170Gd6TpjAt25vsyxYyUN58sdSB5A8isqWilFZ0G/X jdXXVUi1fA8RQyzKxCfbDNhIKT7KwFtIbj2/U6BcMY0mmCsvlr8wyEu3k90EgEDFl54b jACnQ9MuDRBvCsfz+TppWmLMpYr9oKaZiqUk7Uqcv2g8DbYYHEP3k0pEhCzKb4ojtpAO 6Ik/c/Mijw1KLv3i9Ndl8OoyuJlo/guhA1euzJHQBZDknVoQBbi4oSv9hFFCIKzPtO1I cckU5nSin4okaiJNzRdQW/FedcD8IOr0NcCBRs9AkMI8Z0lE7BHaLMjOFfm4x3xbdCAy qgtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5b8eKT5y5KskA+QTSo5NaqnD5JNjajpt9hUsqgHyMPA=; b=RXZgSphZHeyrCr63WbYP3BlAddFOorfhZdkqEjwkaOTjjc4CGLQUCRYGM8/c3jR5+N S3Zm9D5fpQDiO8CscqTpWNx40t0UpqZ2HG5RqvqGO6a+YRdRpUCf+GeYsuj4J5biv2Tp 7Qr68Eq95LXl67l2mUYo9nA9/Ciz0Pn6FMUz6r3bZuLQ9yax91fPOJ9mRep6Ube9+rlb d/dqFRJjrMcLD4pAnKq7kGfCOVgUCrVzZwIEq9ERWihzo9DOTpd/M0oW44J3B520g1QT PmpStpSkT8zc8F9yKClAtGeY0oKa5wSkCWkBtLY59/7F/pUwwrL6QoVwGAkPfH8vDv++ A7mA== X-Gm-Message-State: AOAM5307RAhDaGixI/ebIwVX4/RLYxoHLxkRJni8iBsH5YM4Im5XfmNw nVr6w5zyrG/2c55bW9ke3Ng= X-Google-Smtp-Source: ABdhPJxAFI8kDlC/3ECdO9ar9GrmSykkH0mms8X7j1NYCondhlBV6izg/zDHDX7D46B3TTrkLjtkPw== X-Received: by 2002:a05:6214:1910:: with SMTP id er16mr4966181qvb.228.1596217244341; Fri, 31 Jul 2020 10:40:44 -0700 (PDT) Received: from ?IPv6:2620:10d:c0a8:11e1::10da? ([2620:10d:c091:480::1:4a2]) by smtp.gmail.com with ESMTPSA id s5sm8825129qke.120.2020.07.31.10.40.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2020 10:40:43 -0700 (PDT) From: Jes Sorensen X-Google-Original-From: Jes Sorensen Subject: Re: [PATCH 0/7] Split fsverity-utils into a shared library To: Eric Biggers Cc: Jes Sorensen , linux-fscrypt@vger.kernel.org, kernel-team@fb.com, Chris Mason References: <20200211000037.189180-1-Jes.Sorensen@gmail.com> <20200211192209.GA870@sol.localdomain> <20200211231454.GB870@sol.localdomain> <20200214203510.GA1985@gmail.com> <479b0fff-6af2-32e6-a645-03fcfc65ad59@gmail.com> <20200730175252.GA1074@sol.localdomain> Message-ID: <0d5c5b1d-2170-025e-2cc1-75169bb33008@gmail.com> Date: Fri, 31 Jul 2020 13:40:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200730175252.GA1074@sol.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On 7/30/20 1:52 PM, Eric Biggers wrote: > On Wed, Feb 19, 2020 at 06:49:07PM -0500, Jes Sorensen wrote: >>> We'd also need to follow shared library best practices like compiling with >>> -fvisibility=hidden and marking the API functions explicitly with >>> __attribute__((visibility("default"))), and setting the 'soname' like >>> -Wl,-soname=libfsverity.so.0. >>> >>> Also, is the GPLv2+ license okay for the use case? >> >> Personally I only care about linking it into rpm, which is GPL v2, so >> from my perspective, that is sufficient. I am also fine making it LGPL, >> but given it's your code I am stealing, I cannot make that call. >> > > Hi Jes, I'd like to revisit this, as I'm concerned about future use cases where > software under other licenses (e.g. LGPL, MIT, or Apache 2.0) might want to use > libfsverity -- especially if libfsverity grows more functionality. > > Also, fsverity-utils links to OpenSSL, which some people (e.g. Debian) consider > to be incompatible with GPLv2. > > We think the MIT license (https://opensource.org/licenses/MIT) would offer the > most flexibility. Are you okay with changing the license of fsverity-utils to > MIT? If so, I'll send a patch and you can give an Acked-by on it. > > Thanks! > > - Eric Hi Eric, I went back through my patches to make sure I didn't reuse code from other GPL projects. I don't see anything that looks like it was reused except from fsverity-utils itself, so it should be fine. I think it's fair to relax the license so other projects can link to it. I would prefer we use the LGPL rather than the MIT license though? CC'ing Chris Mason as well, since he has the auth to ack it on behalf of the company. Cheers, Jes