From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 21 Aug 2019 17:21:09 +1000 From: Herbert Xu Message-ID: <20190821072109.GA22686@gondor.apana.org.au> References: <004201d557eb$9b0a4410$d11ecc30$@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [dm-devel] [PATCH 6/9] dm crypt: support diskcipher List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Milan Broz Cc: 'Jens Axboe' , 'Jaehoon Chung' , 'Ulf Hansson' , "'Theodore Y. Ts'o'" , 'Mike Snitzer' , "boojin.kim" , 'Chao Yu' , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, 'Krzysztof Kozlowski' , 'Eric Biggers' , dm-devel@redhat.com, 'Kukjin Kim' , 'Andreas Dilger' , linux-crypto@vger.kernel.org, 'Jaegeuk Kim' , linux-fscrypt@vger.kernel.org, "'David S. Miller'" , 'Alasdair Kergon' List-ID: On Wed, Aug 21, 2019 at 09:13:36AM +0200, Milan Broz wrote: > > NACK. > > The whole principle of dm-crypt target is that it NEVER EVER submits > plaintext data down the stack in bio. > > If you want to do some lower/higher layer encryption, use key management > on a different layer. > So here, just setup encryption for fs, do not stack it with dm-crypt. > > Also, dm-crypt is software-independent solution > (software-based full disk encryption), it must not depend on > any underlying hardware. > Hardware can be of course used used for acceleration, but then > just implement proper crypto API module that accelerates particular cipher. I agree. Please take a look at the recent ESSIV patches on linux-crypto and build multi-block operations on top of them which can then be implemented by the hardware. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel