From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@infradead.org>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Satya Tangirala <satyat@google.com>,
Paul Lawrence <paullawrence@google.com>,
Dave Chinner <david@fromorbit.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org, Paul Crowley <paulcrowley@google.com>
Subject: Re: [PATCH 1/3] fscrypt: add support for inline-encryption-optimized policies
Date: Thu, 24 Oct 2019 00:04:33 -0700 [thread overview]
Message-ID: <20191024070433.GB16652@infradead.org> (raw)
In-Reply-To: <20191024024459.GA743@sol.localdomain>
On Wed, Oct 23, 2019 at 07:44:59PM -0700, Eric Biggers wrote:
> Would you be happy with something that more directly describes the change the
> flag makes
Yes.
> , like FSCRYPT_POLICY_FLAG_CONTENTS_IV_INO_LBLK_64? I.e., the IVs for
> contents encryption are 64-bit and contain the inode and logical block numbers.
>
> Actually, we could use the same key derivation and IV generation for directories
> and symlinks too, which would result in just FSCRYPT_POLICY_FLAG_IV_INO_LBLK_64.
> (lblk is 0 when encrypting a filename.)
I think not making it crazy verbose is a helpful, but at the same time
it should be somewhat descriptive.
> Although, in general it would be nice to name the settings in ways that are
> easier for people not intimately familiar with the crypto to understand...
For the andoid case the actual users won't ever really see it, and if
you set up the thing yourself it probably helps a lot to try to
understand what your are doing.
next prev parent reply other threads:[~2019-10-24 7:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 23:03 [PATCH 0/3] fscrypt: support for inline-encryption-optimized policies Eric Biggers
2019-10-21 23:03 ` [PATCH 1/3] fscrypt: add " Eric Biggers
2019-10-22 5:27 ` Dave Chinner
2019-10-22 6:00 ` Eric Biggers
2019-10-22 13:30 ` Theodore Y. Ts'o
2019-10-22 16:15 ` Eric Biggers
2019-10-23 9:27 ` Christoph Hellwig
2019-10-23 12:57 ` Theodore Y. Ts'o
2019-10-24 1:27 ` Christoph Hellwig
2019-10-24 2:44 ` Eric Biggers
2019-10-24 7:04 ` Christoph Hellwig [this message]
2019-10-24 9:54 ` Paul Crowley
2019-10-23 9:28 ` Christoph Hellwig
2019-10-21 23:03 ` [PATCH 2/3] ext4: add support for INLINE_CRYPT_OPTIMIZED encryption policies Eric Biggers
2019-10-22 13:37 ` Theodore Y. Ts'o
2019-10-22 16:37 ` Eric Biggers
2019-10-21 23:03 ` [PATCH 3/3] f2fs: " Eric Biggers
2019-10-22 16:43 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024070433.GB16652@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=paulcrowley@google.com \
--cc=paullawrence@google.com \
--cc=satyat@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).