From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4CFBC3F68F for ; Sun, 8 Dec 2019 03:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C29FD208C3 for ; Sun, 8 Dec 2019 03:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726469AbfLHDmX (ORCPT ); Sat, 7 Dec 2019 22:42:23 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:56938 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726418AbfLHDmX (ORCPT ); Sat, 7 Dec 2019 22:42:23 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1idnS4-00084W-CV; Sun, 08 Dec 2019 03:41:47 +0000 Date: Sun, 8 Dec 2019 03:41:44 +0000 From: Al Viro To: Tiezhu Yang Cc: "Theodore Y. Ts'o" , Jaegeuk Kim , Chao Yu , Eric Biggers , Tyler Hicks , linux-fsdevel@vger.kernel.org, ecryptfs@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] fs: introduce is_dot_dotdot helper for cleanup Message-ID: <20191208034144.GP4203@ZenIV.linux.org.uk> References: <1575718548-19017-1-git-send-email-yangtiezhu@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1575718548-19017-1-git-send-email-yangtiezhu@loongson.cn> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Sat, Dec 07, 2019 at 07:35:48PM +0800, Tiezhu Yang wrote: > There exists many similar and duplicate codes to check "." and "..", > so introduce is_dot_dotdot helper to make the code more clean. Umm... No objections, in principle, but... you try to say that name (e.g. in a phone conversation) without stuttering ;-/ Any suggestions from native speakers?