From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Chandan Rajendra <chandan@linux.vnet.ibm.com>,
linux-fscrypt@vger.kernel.org
Subject: Re: [v3 PATCH] fscrypt: Allow modular crypto algorithms
Date: Tue, 24 Dec 2019 16:38:52 -0600 [thread overview]
Message-ID: <20191224223852.GA178036@zzz.localdomain> (raw)
In-Reply-To: <20191223074623.you4ivf2yuxk4ad2@gondor.apana.org.au>
On Mon, Dec 23, 2019 at 03:46:23PM +0800, Herbert Xu wrote:
> diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
> index ef42ab040905..930793456d3a 100644
> --- a/fs/ext4/Kconfig
> +++ b/fs/ext4/Kconfig
> @@ -10,6 +10,7 @@ config EXT3_FS
> select CRC16
> select CRYPTO
> select CRYPTO_CRC32C
> + select FS_ENCRYPTION_ALGS if FS_ENCRYPTION
> help
> This config option is here only for backward compatibility. ext3
> filesystem is now handled by the ext4 driver.
This needs to be under EXT4_FS, not EXT3_FS. That should address the kbuild
test robot error.
(The fact that EXT3_FS selects options other than just EXT4_FS is unnecessary
and misleading; I'll send a separate patch to clean that up.)
- Eric
next prev parent reply other threads:[~2019-12-24 22:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 14:30 [PATCH] fscrypt: Restore modular support Herbert Xu
2019-12-21 23:44 ` Eric Biggers
2019-12-22 8:41 ` [v2 PATCH] fscrypt: Allow modular crypto algorithms Herbert Xu
2019-12-22 16:45 ` Eric Biggers
2019-12-23 7:46 ` [v3 " Herbert Xu
2019-12-24 22:38 ` Eric Biggers [this message]
2019-12-27 2:47 ` [v4 " Herbert Xu
2020-01-03 17:04 ` Eric Biggers
2019-12-24 11:44 ` [PATCH] fscrypt: Restore modular support kbuild test robot
2019-12-24 11:58 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224223852.GA178036@zzz.localdomain \
--to=ebiggers@kernel.org \
--cc=chandan@linux.vnet.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jaegeuk@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).