From: Eric Biggers <ebiggers@kernel.org>
To: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org
Cc: linux-fscrypt@vger.kernel.org,
Chandan Rajendra <chandan@linux.vnet.ibm.com>
Subject: Re: [PATCH] ubifs: use IS_ENCRYPTED() instead of ubifs_crypt_is_encrypted()
Date: Fri, 3 Jan 2020 09:09:28 -0800 [thread overview]
Message-ID: <20200103170927.GO19521@gmail.com> (raw)
In-Reply-To: <20191209212721.244396-1-ebiggers@kernel.org>
On Mon, Dec 09, 2019 at 01:27:21PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> There's no need for the ubifs_crypt_is_encrypted() function anymore.
> Just use IS_ENCRYPTED() instead, like ext4 and f2fs do. IS_ENCRYPTED()
> checks the VFS-level flag instead of the UBIFS-specific flag, but it
> shouldn't change any behavior since the flags are kept in sync.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/ubifs/dir.c | 8 ++++----
> fs/ubifs/file.c | 4 ++--
> fs/ubifs/journal.c | 6 +++---
> fs/ubifs/ubifs.h | 7 -------
> 4 files changed, 9 insertions(+), 16 deletions(-)
Richard, can you consider applying this to the UBIFS tree for 5.6?
- Eric
next prev parent reply other threads:[~2020-01-03 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 21:27 [PATCH] ubifs: use IS_ENCRYPTED() instead of ubifs_crypt_is_encrypted() Eric Biggers
2020-01-03 17:09 ` Eric Biggers [this message]
2020-01-09 8:01 ` Richard Weinberger
2020-01-20 6:54 ` Eric Biggers
2020-01-20 9:44 ` Richard Weinberger
2020-01-20 18:47 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103170927.GO19521@gmail.com \
--to=ebiggers@kernel.org \
--cc=chandan@linux.vnet.ibm.com \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).