From: Eric Biggers <ebiggers@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, Victor Hsieh <victorhsieh@google.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] fs-verity: implement readahead of Merkle tree pages
Date: Mon, 6 Jan 2020 12:43:58 -0800 [thread overview]
Message-ID: <20200106204357.GA254289@gmail.com> (raw)
In-Reply-To: <20200106181508.GA50058@jaegeuk-macbookpro.roam.corp.google.com>
On Mon, Jan 06, 2020 at 10:15:08AM -0800, Jaegeuk Kim wrote:
> > static struct page *f2fs_read_merkle_tree_page(struct inode *inode,
> > - pgoff_t index)
> > + pgoff_t index,
> > + unsigned long num_ra_pages)
> > {
> > + struct page *page;
> > +
> > index += f2fs_verity_metadata_pos(inode) >> PAGE_SHIFT;
> >
> > - return read_mapping_page(inode->i_mapping, index, NULL);
> > + page = find_get_page(inode->i_mapping, index);
> > + if (!page || !PageUptodate(page)) {
> > + if (page)
> > + put_page(page);
> > + else if (num_ra_pages > 1)
> > + f2fs_merkle_tree_readahead(inode->i_mapping, index,
> > + num_ra_pages);
> > + page = read_mapping_page(inode->i_mapping, index, NULL);
> > + if (IS_ERR(page))
> > + return page;
>
> We don't need to check this, but can use the below return page?
>
Indeed, I'll remove the unnecessary IS_ERR(page) check.
> > + }
>
> mark_page_accessed(page)?
>
> > + return page;
> > }
Good idea, but read_mapping_page() already calls mark_page_accessed(). It's
just find_get_page() that doesn't. So after this patch, mark_page_accessed() is
no longer called in the case where the page is already cached and Uptodate.
I'll change it to use:
find_get_page_flags(inode->i_mapping, index, FGP_ACCESSED);
- Eric
prev parent reply other threads:[~2020-01-06 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 18:11 [PATCH] fs-verity: implement readahead of Merkle tree pages Eric Biggers
2020-01-06 17:39 ` Eric Biggers
2020-01-06 18:15 ` [f2fs-dev] " Jaegeuk Kim
2020-01-06 20:43 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106204357.GA254289@gmail.com \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=victorhsieh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).