Linux-FSCrypt Archive on
 help / color / Atom feed
From: "Theodore Y. Ts'o" <>
To: Eric Biggers <>
Subject: Re: [PATCH] ext4: handle decryption error in __ext4_block_zero_page_range()
Date: Mon, 13 Jan 2020 14:25:08 -0500
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Dec 26, 2019 at 09:41:05AM -0600, Eric Biggers wrote:
> From: Eric Biggers <>
> fscrypt_decrypt_pagecache_blocks() can fail, because it uses
> skcipher_request_alloc(), which uses kmalloc(), which can fail; and also
> because it calls crypto_skcipher_decrypt(), which can fail depending on
> the driver that actually implements the crypto.
> Therefore it's not appropriate to WARN on decryption error in
> __ext4_block_zero_page_range().
> Remove the WARN and just handle the error instead.
> Signed-off-by: Eric Biggers <>

Thanks, applied.

					- Ted

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-26 15:41 Eric Biggers
2020-01-13 19:25 ` Theodore Y. Ts'o [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-FSCrypt Archive on

Archives are clonable:
	git clone --mirror linux-fscrypt/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fscrypt linux-fscrypt/ \
	public-inbox-index linux-fscrypt

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone