Linux-FSCrypt Archive on lore.kernel.org
 help / color / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-ext4@vger.kernel.org, linux-fscrypt@vger.kernel.org
Subject: Re: [PATCH] ext4: fix deadlock allocating crypto bounce page from mempool
Date: Mon, 13 Jan 2020 14:44:52 -0500
Message-ID: <20200113194452.GF76141@mit.edu> (raw)
In-Reply-To: <20191231181149.47619-1-ebiggers@kernel.org>

On Tue, Dec 31, 2019 at 12:11:49PM -0600, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> ext4_writepages() on an encrypted file has to encrypt the data, but it
> can't modify the pagecache pages in-place, so it encrypts the data into
> bounce pages and writes those instead.  All bounce pages are allocated
> from a mempool using GFP_NOFS.
> 
> This is not correct use of a mempool, and it can deadlock.  This is
> because GFP_NOFS includes __GFP_DIRECT_RECLAIM, which enables the "never
> fail" mode for mempool_alloc() where a failed allocation will fall back
> to waiting for one of the preallocated elements in the pool.
> 
> But since this mode is used for all a bio's pages and not just the
> first, it can deadlock waiting for pages already in the bio to be freed.
> 
> This deadlock can be reproduced by patching mempool_alloc() to pretend
> that pool->alloc() always fails (so that it always falls back to the
> preallocations), and then creating an encrypted file of size > 128 KiB.
> 
> Fix it by only using GFP_NOFS for the first page in the bio.  For
> subsequent pages just use GFP_NOWAIT, and if any of those fail, just
> submit the bio and start a new one.
> 
> This will need to be fixed in f2fs too, but that's less straightforward.
> 
> Fixes: c9af28fdd449 ("ext4 crypto: don't let data integrity writebacks fail with ENOMEM")
> Cc: stable@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Applied, thanks.

					- Ted

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-31 18:11 Eric Biggers
2020-01-13 19:44 ` Theodore Y. Ts'o [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200113194452.GF76141@mit.edu \
    --to=tytso@mit.edu \
    --cc=ebiggers@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-FSCrypt Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fscrypt/0 linux-fscrypt/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fscrypt linux-fscrypt/ https://lore.kernel.org/linux-fscrypt \
		linux-fscrypt@vger.kernel.org
	public-inbox-index linux-fscrypt

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fscrypt


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git