Linux-FSCrypt Archive on
 help / color / Atom feed
From: "Theodore Y. Ts'o" <>
To: Eric Biggers <>
Subject: Re: [PATCH] ext4: fix deadlock allocating bio_post_read_ctx from mempool
Date: Mon, 13 Jan 2020 14:47:24 -0500
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Dec 31, 2019 at 12:12:22PM -0600, Eric Biggers wrote:
> From: Eric Biggers <>
> Without any form of coordination, any case where multiple allocations
> from the same mempool are needed at a time to make forward progress can
> deadlock under memory pressure.
> This is the case for struct bio_post_read_ctx, as one can be allocated
> to decrypt a Merkle tree page during fsverity_verify_bio(), which itself
> is running from a post-read callback for a data bio which has its own
> struct bio_post_read_ctx.
> Fix this by freeing the first bio_post_read_ctx before calling
> fsverity_verify_bio().  This works because verity (if enabled) is always
> the last post-read step.
> This deadlock can be reproduced by trying to read from an encrypted
> verity file after reducing NUM_PREALLOC_POST_READ_CTXS to 1 and patching
> mempool_alloc() to pretend that pool->alloc() always fails.
> Note that since NUM_PREALLOC_POST_READ_CTXS is actually 128, to actually
> hit this bug in practice would require reading from lots of encrypted
> verity files at the same time.  But it's theoretically possible, as N
> available objects isn't enough to guarantee forward progress when > N/2
> threads each need 2 objects at a time.
> Fixes: 22cfe4b48ccb ("ext4: add fs-verity read support")
> Signed-off-by: Eric Biggers <>

Thanks, applied.

						- Ted

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-31 18:12 Eric Biggers
2020-01-13 19:47 ` Theodore Y. Ts'o [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-FSCrypt Archive on

Archives are clonable:
	git clone --mirror linux-fscrypt/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fscrypt linux-fscrypt/ \
	public-inbox-index linux-fscrypt

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone