From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0456C33CA1 for ; Mon, 20 Jan 2020 06:54:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4A07207E0 for ; Mon, 20 Jan 2020 06:54:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579503265; bh=3/g8O0L8/HHyUM7mzXuzKScJszx17sO0OT6iedMCQbY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0xCTnqKNtY/BrzNAwdJOHK0GXvcG/AWL1WZPigVjjpqZmbaosSI7h9InyMM2hGcvw 1iYgqJaTAt3WvPdV+GEhNOCU0KlWzxuD9/SYT2g0TNagiPNxpHOM9GAPXdL4jXqd28 /hqfovn7ujn6EAQnG6NCwQa49ji02YdwOuQ9bQrs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725876AbgATGyZ (ORCPT ); Mon, 20 Jan 2020 01:54:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:56654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbgATGyZ (ORCPT ); Mon, 20 Jan 2020 01:54:25 -0500 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6811F2073D; Mon, 20 Jan 2020 06:54:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579503264; bh=3/g8O0L8/HHyUM7mzXuzKScJszx17sO0OT6iedMCQbY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Occ+eKdYD75/B0vY5B8dPtboth69kxcmqdb2JLdJfROsBnMGeKyITZlIB9awuY89K KQZYwiWpREBVfe06v6ipryJId0Yd/UXeOZFkyWeO/P8Ch6xhbBjbuVhTsehCJbJCqC mtRjU2mVA2Mghajjr+xVlGKp6LibusrEYHO2AHRg= Date: Sun, 19 Jan 2020 22:54:22 -0800 From: Eric Biggers To: Richard Weinberger Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-fscrypt@vger.kernel.org, Chandan Rajendra Subject: Re: [PATCH] ubifs: use IS_ENCRYPTED() instead of ubifs_crypt_is_encrypted() Message-ID: <20200120065422.GA976@sol.localdomain> References: <20191209212721.244396-1-ebiggers@kernel.org> <20200103170927.GO19521@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Thu, Jan 09, 2020 at 09:01:09AM +0100, Richard Weinberger wrote: > On Fri, Jan 3, 2020 at 6:09 PM Eric Biggers wrote: > > > > On Mon, Dec 09, 2019 at 01:27:21PM -0800, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > There's no need for the ubifs_crypt_is_encrypted() function anymore. > > > Just use IS_ENCRYPTED() instead, like ext4 and f2fs do. IS_ENCRYPTED() > > > checks the VFS-level flag instead of the UBIFS-specific flag, but it > > > shouldn't change any behavior since the flags are kept in sync. > > > > > > Signed-off-by: Eric Biggers > > > --- > > > fs/ubifs/dir.c | 8 ++++---- > > > fs/ubifs/file.c | 4 ++-- > > > fs/ubifs/journal.c | 6 +++--- > > > fs/ubifs/ubifs.h | 7 ------- > > > 4 files changed, 9 insertions(+), 16 deletions(-) > > > > Richard, can you consider applying this to the UBIFS tree for 5.6? > > Sure. I'm back from the x-mas break and start collecting patches. > Ping? I see the other UBIFS patches I sent in linux-ubifs.git#linux-next, but not this one. - Eric