linux-fscrypt.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/9]  Split fsverity-utils into a shared library
@ 2020-03-12 21:47 Jes Sorensen
  2020-03-12 21:47 ` [PATCH 1/9] Build basic shared library framework Jes Sorensen
                   ` (9 more replies)
  0 siblings, 10 replies; 23+ messages in thread
From: Jes Sorensen @ 2020-03-12 21:47 UTC (permalink / raw)
  To: linux-fscrypt; +Cc: kernel-team, ebiggers, Jes Sorensen

From: Jes Sorensen <jsorensen@fb.com>

Hi,

This is an updated version of my patches to split fsverity-utils into
a shared library. This version addresses most of the comments I
received in the last version:

1) Document the API
2) Verified ran xfstest against the build
3) Make struct fsverity_descriptor private
4) Reviewed (and documented) error codes
5) Improved validation of input parameters, and return error if any
   reserved field is not zero.

I left struct fsverity_hash_alg in the public API, because it adds
useful information to the user, in particular providing the digest
size, and allows the caller to walk the list to obtain the supported
algorithms. The alternative is to introduce a
libverity_get_digest_size() call.

I still need to add some self-tests to the build and deal with the
soname stuff.

Next up is rpm support.

Cheers,
Jes


Jes Sorensen (9):
  Build basic shared library framework
  Change compute_file_measurement() to take a file descriptor as
    argument
  Move fsverity_descriptor definition to libfsverity.h
  Move hash algorithm code to shared library
  Create libfsverity_compute_digest() and adapt cmd_sign to use it
  Introduce libfsverity_sign_digest()
  Validate input arguments to libfsverity_compute_digest()
  Validate input parameters for libfsverity_sign_digest()
  Document API of libfsverity

 Makefile              |  18 +-
 cmd_enable.c          |  11 +-
 cmd_measure.c         |   4 +-
 cmd_sign.c            | 526 +++------------------------------------
 fsverity.c            |  16 +-
 hash_algs.c           |  26 +-
 hash_algs.h           |  27 --
 libfsverity.h         | 127 ++++++++++
 libfsverity_private.h |  33 +++
 libverity.c           | 559 ++++++++++++++++++++++++++++++++++++++++++
 util.h                |   2 +
 11 files changed, 801 insertions(+), 548 deletions(-)
 create mode 100644 libfsverity.h
 create mode 100644 libfsverity_private.h
 create mode 100644 libverity.c

-- 
2.24.1


^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2020-04-22 17:57 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-12 21:47 [PATCH v3 0/9] Split fsverity-utils into a shared library Jes Sorensen
2020-03-12 21:47 ` [PATCH 1/9] Build basic shared library framework Jes Sorensen
2020-03-22  5:23   ` Eric Biggers
2020-03-22  5:33   ` Eric Biggers
2020-04-21 21:00     ` Jes Sorensen
2020-03-12 21:47 ` [PATCH 2/9] Change compute_file_measurement() to take a file descriptor as argument Jes Sorensen
2020-03-12 21:47 ` [PATCH 3/9] Move fsverity_descriptor definition to libfsverity.h Jes Sorensen
2020-03-22  4:57   ` Eric Biggers
2020-04-21 16:07     ` Jes Sorensen
2020-04-21 16:16       ` Eric Biggers
2020-04-21 16:20         ` Jes Sorensen
2020-03-12 21:47 ` [PATCH 4/9] Move hash algorithm code to shared library Jes Sorensen
2020-03-22  5:38   ` Eric Biggers
2020-04-22 17:57     ` Jes Sorensen
2020-03-12 21:47 ` [PATCH 5/9] Create libfsverity_compute_digest() and adapt cmd_sign to use it Jes Sorensen
2020-03-22  5:40   ` Eric Biggers
2020-03-12 21:47 ` [PATCH 6/9] Introduce libfsverity_sign_digest() Jes Sorensen
2020-03-12 21:47 ` [PATCH 7/9] Validate input arguments to libfsverity_compute_digest() Jes Sorensen
2020-03-12 21:47 ` [PATCH 8/9] Validate input parameters for libfsverity_sign_digest() Jes Sorensen
2020-03-22  5:27   ` Eric Biggers
2020-03-12 21:47 ` [PATCH 9/9] Document API of libfsverity Jes Sorensen
2020-03-22  5:54   ` Eric Biggers
2020-03-22  5:05 ` [PATCH v3 0/9] Split fsverity-utils into a shared library Eric Biggers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).