From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC02C47255 for ; Fri, 8 May 2020 20:25:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39A5D24955 for ; Fri, 8 May 2020 20:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588969517; bh=qNmHLjlvAN/0x2W7x8pTUYU1rf1Pi23VDXATKDSdUcs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zrKaklJBuEPzQAn/tOBHANSl6IS/O/m8bi92PgvGixX+vanDswjIoe9j1dV/mQPHw 9/FutbEu/xKqpzd4tWZEK5UQkxLxwpeL+IrpvUxwKVcPTvJaFM/l4Lk0O3mmlVQigG t24dAK0RsxOXQznaaEtnOPdbJU/ZKvrlOYnjnzRA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726904AbgEHUZQ (ORCPT ); Fri, 8 May 2020 16:25:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:41416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbgEHUZQ (ORCPT ); Fri, 8 May 2020 16:25:16 -0400 Received: from gmail.com (unknown [104.132.1.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 25D922173E; Fri, 8 May 2020 20:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588969515; bh=qNmHLjlvAN/0x2W7x8pTUYU1rf1Pi23VDXATKDSdUcs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q9+tJDu3e9F6/OeItcROXU9m26WlcaNrXkxydiiIWlvVxfuWwmKCECH2p3vxWt+gX HT9DsWR5CSVygx/eAlTA4oFlLIMVUQYa2zavVEilokx5KvhZfo2EwVcfRX+m82pbG0 SLXFXqJHNhMaQgdYV7kJ4/XRCQeT4fgUsUQ+OmaM= Date: Fri, 8 May 2020 13:25:13 -0700 From: Eric Biggers To: Steev Klimaszewski Cc: Thara Gopinath , linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org, Alim Akhtar , Andy Gross , Avri Altman , Barani Muthukumaran , Bjorn Andersson , Can Guo , Elliot Berman , John Stultz , Satya Tangirala Subject: Re: [RFC PATCH v4 4/4] scsi: ufs-qcom: add Inline Crypto Engine support Message-ID: <20200508202513.GA233206@gmail.com> References: <20200501045111.665881-1-ebiggers@kernel.org> <20200501045111.665881-5-ebiggers@kernel.org> <31fa95e5-7757-96ae-2e86-1f54959e3a6c@linaro.org> <20200507180435.GB236103@gmail.com> <20200507180838.GC236103@gmail.com> <150ddaaf-12ec-231e-271a-c65b1d88d30f@kali.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <150ddaaf-12ec-231e-271a-c65b1d88d30f@kali.org> Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Fri, May 08, 2020 at 03:18:23PM -0500, Steev Klimaszewski wrote: > > On 5/7/20 1:08 PM, Eric Biggers wrote: > > On Thu, May 07, 2020 at 11:04:35AM -0700, Eric Biggers wrote: > >> Hi Thara, > >> > >> On Thu, May 07, 2020 at 08:36:58AM -0400, Thara Gopinath wrote: > >>> > >>> On 5/1/20 12:51 AM, Eric Biggers wrote: > >>>> From: Eric Biggers > >>>> > >>>> Add support for Qualcomm Inline Crypto Engine (ICE) to ufs-qcom. > >>>> > >>>> The standards-compliant parts, such as querying the crypto capabilities > >>>> and enabling crypto for individual UFS requests, are already handled by > >>>> ufshcd-crypto.c, which itself is wired into the blk-crypto framework. > >>>> However, ICE requires vendor-specific init, enable, and resume logic, > >>>> and it requires that keys be programmed and evicted by vendor-specific > >>>> SMC calls. Make the ufs-qcom driver handle these details. > >>>> > >>>> I tested this on Dragonboard 845c, which is a publicly available > >>>> development board that uses the Snapdragon 845 SoC and runs the upstream > >>>> Linux kernel. This is the same SoC used in the Pixel 3 and Pixel 3 XL > >>>> phones. This testing included (among other things) verifying that the > >>>> expected ciphertext was produced, both manually using ext4 encryption > >>>> and automatically using a block layer self-test I've written. > >>> Hello Eric, > >>> > >>> I am interested in testing out this series on 845, 855 and if possile on 865 > >>> platforms. Can you give me some more details about your testing please. > >>> > >> Great! You can test this with fscrypt, a.k.a. ext4 or f2fs encryption. > >> > >> A basic manual test would be: > >> > >> 1. Build a kernel with: > >> > >> CONFIG_BLK_INLINE_ENCRYPTION=y > >> CONFIG_FS_ENCRYPTION=y > >> CONFIG_FS_ENCRYPTION_INLINE_CRYPT=y > > Sorry, I forgot: 'CONFIG_SCSI_UFS_CRYPTO=y' is needed too. > > > > - Eric > > I took a look into this as well - is v12 the latest of the fscrypt > inline crypto patches? > > I see a EXPORT_SYMBOL_GPL(fscrypt_inode_uses_inline_crypto) but it seems > like it should be EXPORT_SYMBOL_GPL(__fscrypt_inode_uses_inline_crypto) > otherwise you end up with > > > WARNING: modpost: "fscrypt_inode_uses_inline_crypto" [vmlinux] is a > static EXPORT_SYMBOL_GPL > > > when you have something like CONFIG_F2FS_FS=m > > > Apologies but I'm not sure where the original patchset is to send as a > reply to them. The original patchset is at https://lkml.kernel.org/r/20200430115959.238073-1-satyat@google.com/ Yes, v12 is the latest version, and yes that's a bug. The export needs double underscores. Satya will fix it when he sends out v13. - Eric