From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-mmc@vger.kernel.org,
"Theodore Y . Ts'o" <tytso@mit.edu>,
Satya Tangirala <satyat@google.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Paul Crowley <paulcrowley@google.com>
Subject: Re: [PATCH] fscrypt: add support for IV_INO_LBLK_32 policies
Date: Mon, 25 May 2020 08:33:20 -0700 [thread overview]
Message-ID: <20200525153320.GA2152@sol.localdomain> (raw)
In-Reply-To: <20200515204141.251098-1-ebiggers@kernel.org>
On Fri, May 15, 2020 at 01:41:41PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The eMMC inline crypto standard will only specify 32 DUN bits (a.k.a. IV
> bits), unlike UFS's 64. IV_INO_LBLK_64 is therefore not applicable, but
> an encryption format which uses one key per policy and permits the
> moving of encrypted file contents (as f2fs's garbage collector requires)
> is still desirable.
>
> To support such hardware, add a new encryption format IV_INO_LBLK_32
> that makes the best use of the 32 bits: the IV is set to
> 'SipHash-2-4(inode_number) + file_logical_block_number mod 2^32', where
> the SipHash key is derived from the fscrypt master key. We hash only
> the inode number and not also the block number, because we need to
> maintain contiguity of DUNs to merge bios.
>
> Unlike with IV_INO_LBLK_64, with this format IV reuse is possible; this
> is unavoidable given the size of the DUN. This means this format should
> only be used where the requirements of the first paragraph apply.
> However, the hash spreads out the IVs in the whole usable range, and the
> use of a keyed hash makes it difficult for an attacker to determine
> which files use which IVs.
>
> Besides the above differences, this flag works like IV_INO_LBLK_64 in
> that on ext4 it is only allowed if the stable_inodes feature has been
> enabled to prevent inode numbers and the filesystem UUID from changing.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> Documentation/filesystems/fscrypt.rst | 33 +++++++++--
> fs/crypto/crypto.c | 6 +-
> fs/crypto/fscrypt_private.h | 20 +++++--
> fs/crypto/keyring.c | 5 +-
> fs/crypto/keysetup.c | 85 +++++++++++++++++++++------
> fs/crypto/policy.c | 51 +++++++++++-----
> include/uapi/linux/fscrypt.h | 3 +-
> 7 files changed, 157 insertions(+), 46 deletions(-)
Applied to fscrypt.git#master for 5.8.
- Eric
prev parent reply other threads:[~2020-05-25 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 20:41 [PATCH] fscrypt: add support for IV_INO_LBLK_32 policies Eric Biggers
2020-05-19 11:13 ` Theodore Y. Ts'o
2020-05-19 14:45 ` Eric Biggers
2020-05-19 16:33 ` Paul Crowley
2020-05-25 15:33 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525153320.GA2152@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=paulcrowley@google.com \
--cc=satyat@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).