From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/4] f2fs: add inline encryption support
Date: Thu, 18 Jun 2020 15:50:09 -0700 [thread overview]
Message-ID: <20200618225009.GA35732@gmail.com> (raw)
In-Reply-To: <20200617075732.213198-4-satyat@google.com>
On Wed, Jun 17, 2020 at 07:57:31AM +0000, Satya Tangirala wrote:
> Wire up f2fs to support inline encryption via the helper functions which
> fs/crypto/ now provides. This includes:
>
> - Adding a mount option 'inlinecrypt' which enables inline encryption
> on encrypted files where it can be used.
>
> - Setting the bio_crypt_ctx on bios that will be submitted to an
> inline-encrypted file.
>
> - Not adding logically discontiguous data to bios that will be submitted
> to an inline-encrypted file.
>
> - Not doing filesystem-layer crypto on inline-encrypted files.
>
> This patch includes a fix for a race during IPU by
> Sahitya Tummala <stummala@codeaurora.org>
>
> Co-developed-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Satya Tangirala <satyat@google.com>
> ---
> Documentation/filesystems/f2fs.rst | 7 ++-
> fs/f2fs/compress.c | 2 +-
> fs/f2fs/data.c | 81 ++++++++++++++++++++++++------
> fs/f2fs/super.c | 32 ++++++++++++
> 4 files changed, 104 insertions(+), 18 deletions(-)
>
> diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
> index 099d45ac8d8f..4dc36143ff82 100644
> --- a/Documentation/filesystems/f2fs.rst
> +++ b/Documentation/filesystems/f2fs.rst
> @@ -258,7 +258,12 @@ compress_extension=%s Support adding specified extension, so that f2fs can enab
> on compression extension list and enable compression on
> these file by default rather than to enable it via ioctl.
> For other files, we can still enable compression via ioctl.
> -====================== ============================================================
The above line being deleted marks the end of a table, so it shouldn't be
deleted (it should go after the part below).
> +inlinecrypt
> + Encrypt/decrypt the contents of encrypted files using the
> + blk-crypto framework rather than filesystem-layer encryption.
> + This allows the use of inline encryption hardware. The on-disk
> + format is unaffected. For more details, see
> + Documentation/block/inline-encryption.rst.
Like I commented on one of the commit messages -- this doesn't make it clear
what happens in cases where blk-crypto can't be used. Maybe just replace:
"Encrypt/decrypt" => "When possible, encrypt/decrypt".
Likewise for the ext4 documentation for this same mount option.
- Eric
next prev parent reply other threads:[~2020-06-18 22:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 7:57 [PATCH 0/4] Inline Encryption Support for fscrypt Satya Tangirala
2020-06-17 7:57 ` [PATCH 1/4] fs: introduce SB_INLINECRYPT Satya Tangirala
2020-06-17 17:46 ` Jaegeuk Kim
2020-06-18 1:19 ` Dave Chinner
2020-06-18 3:19 ` Eric Biggers
2020-06-23 0:46 ` Dave Chinner
2020-06-23 1:50 ` [f2fs-dev] " Eric Biggers
2020-06-24 0:55 ` Dave Chinner
2020-06-17 7:57 ` [PATCH 2/4] fscrypt: add inline encryption support Satya Tangirala
2020-06-17 17:59 ` Jaegeuk Kim
2020-06-18 17:48 ` Eric Biggers
2020-06-17 7:57 ` [PATCH 3/4] f2fs: " Satya Tangirala
2020-06-17 17:56 ` Jaegeuk Kim
2020-06-18 10:06 ` Chao Yu
2020-06-18 18:13 ` Eric Biggers
2020-06-18 19:28 ` Jaegeuk Kim
2020-06-18 19:35 ` Eric Biggers
2020-06-19 2:43 ` Chao Yu
2020-06-19 2:39 ` Chao Yu
2020-06-19 4:20 ` Eric Biggers
2020-06-19 6:37 ` Chao Yu
2020-06-18 22:50 ` Eric Biggers [this message]
2020-06-17 7:57 ` [PATCH 4/4] ext4: " Satya Tangirala
2020-06-18 17:27 ` [PATCH 0/4] Inline Encryption Support for fscrypt Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618225009.GA35732@gmail.com \
--to=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).