From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 020E9C433DF for ; Wed, 24 Jun 2020 06:04:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D31742085B for ; Wed, 24 Jun 2020 06:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592978658; bh=STmnuLbp6dqBamgAzJ+Ue/+bNkc6g/1tpfJs2y+gU6M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=RBV7DU22H8eVpjLpNjso8HWaNEOFNNHkTHySU2tj+KICndU+4c5naQF68HA66WR/e 7Q8qsbTOE74p1foYWxDhCCkcHX11QZhx9fpBuRGane/n1hSbdUNApkO2vXYr2Sfhii FSJTkDl/+xY++UHbLewrhX6SmGFTjER6iITrhV5Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388892AbgFXGEG (ORCPT ); Wed, 24 Jun 2020 02:04:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:33800 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388164AbgFXGEG (ORCPT ); Wed, 24 Jun 2020 02:04:06 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11AC92085B; Wed, 24 Jun 2020 06:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592978645; bh=STmnuLbp6dqBamgAzJ+Ue/+bNkc6g/1tpfJs2y+gU6M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=po3bfXB92hJ+PijyLMwHXbS/arxBw/0IUAsnaYskimBhp5qtvm5z+v8pGM+WgW9eW FLe98JcBQR5dGhNpYT2AcM037Hpb1EdSMM5PBYfhnf2Wgpw7k7/8mYfd7JPRk5E8No teVgpd0E/A1IgM2mFReeceA8sMDJhn8YuudMvMdA= Date: Tue, 23 Jun 2020 23:04:03 -0700 From: Eric Biggers To: Daniel Rosenberg Cc: Theodore Ts'o , linux-ext4@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, Alexander Viro , Richard Weinberger , linux-mtd@lists.infradead.org, Andreas Dilger , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Gabriel Krisman Bertazi , kernel-team@android.com Subject: Re: [PATCH v9 4/4] ext4: Use generic casefolding support Message-ID: <20200624060403.GH844@sol.localdomain> References: <20200624043341.33364-1-drosen@google.com> <20200624043341.33364-5-drosen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624043341.33364-5-drosen@google.com> Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Tue, Jun 23, 2020 at 09:33:41PM -0700, Daniel Rosenberg wrote: > This switches ext4 over to the generic support provided in > commit 5f829feca774 ("fs: Add standard casefolding support") Commit IDs aren't determined until the patches are applied. It's possible for the person applying the patches to fix them, but in general people will forget, so it's better not to include non-stable commit IDs. Also, a sentence explaining *why* this change is good would be helpful. Commit messages should always have a *why* unless it's obvious. Likewise for the f2fs commit. - Eric