From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FB7C433E0 for ; Wed, 8 Jul 2020 01:44:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEA0A20772 for ; Wed, 8 Jul 2020 01:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594172684; bh=pc9r2MlQ4YV78AG0esE4ppDqeMfOm93xI5UmXgp5gqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nnggmmuo5wycyUzNxCesGToID9JRjViKpYQBs7xb3UDx7H0rZajfwj607qKq7Cl0e jzAmCsryof/S9egvfEHq89OeM055pm50L41xabEQ2BAwHYEQRsMkil4lEXBLzCIKlI tTlxtNXhmCKcqteA0klYy0+jTBsdj6WqgLU5QlsU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729216AbgGHBom (ORCPT ); Tue, 7 Jul 2020 21:44:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:51424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728067AbgGHBom (ORCPT ); Tue, 7 Jul 2020 21:44:42 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 50755206DF; Wed, 8 Jul 2020 01:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594172681; bh=pc9r2MlQ4YV78AG0esE4ppDqeMfOm93xI5UmXgp5gqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QA5sGO5qUiLKD4ECswpWLjjMFqRtnVqe1TpN2o5l+JL6AMbY49ekIgI2f+lN+1OzN CpYzIZysoQcDNnfJWfLju4xO+Q6RkMAy4njljS9zJ24uFFljUEDXTXsHuSFPA9bRdu ocaEleHjB6OsO9CNhqwYyabxBcbLRQwGKW2j0Aco= Date: Tue, 7 Jul 2020 18:44:39 -0700 From: Eric Biggers To: Daniel Rosenberg Cc: Theodore Ts'o , linux-ext4@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, Alexander Viro , Andreas Dilger , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Gabriel Krisman Bertazi , kernel-team@android.com Subject: Re: [PATCH v10 4/4] ext4: Use generic casefolding support Message-ID: <20200708014439.GH839@sol.localdomain> References: <20200707113123.3429337-1-drosen@google.com> <20200707113123.3429337-5-drosen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200707113123.3429337-5-drosen@google.com> Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Tue, Jul 07, 2020 at 04:31:23AM -0700, Daniel Rosenberg wrote: > This switches ext4 over to the generic support provided in > the previous patch. > > Since casefolded dentries behave the same in ext4 and f2fs, we decrease > the maintenance burden by unifying them, and any optimizations will > immediately apply to both. > > Signed-off-by: Daniel Rosenberg > --- > fs/ext4/dir.c | 64 ++----------------------------------------------- > fs/ext4/ext4.h | 12 ---------- > fs/ext4/hash.c | 2 +- > fs/ext4/namei.c | 20 +++++++--------- > fs/ext4/super.c | 12 +++++----- > 5 files changed, 17 insertions(+), 93 deletions(-) > Looks good, you can add: Reviewed-by: Eric Biggers - Eric