From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org
Cc: linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Paul Crowley <paulcrowley@google.com>,
Satya Tangirala <satyat@google.com>
Subject: Re: [PATCH] fscrypt: restrict IV_INO_LBLK_* to AES-256-XTS
Date: Mon, 27 Jul 2020 09:35:19 -0700 [thread overview]
Message-ID: <20200727163519.GB1138@sol.localdomain> (raw)
In-Reply-To: <20200721181012.39308-1-ebiggers@kernel.org>
On Tue, Jul 21, 2020 at 11:10:12AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> IV_INO_LBLK_* exist only because of hardware limitations, and currently
> the only known use case for them involves AES-256-XTS. Therefore, for
> now only allow them in combination with AES-256-XTS. This way we don't
> have to worry about them being combined with other encryption modes.
>
> (To be clear, combining IV_INO_LBLK_* with other encryption modes
> *should* work just fine. It's just not being tested, so we can't be
> 100% sure it works. So with no known use case, it's best to disallow it
> for now, just like we don't allow other weird combinations like
> AES-256-XTS contents encryption with Adiantum filenames encryption.)
>
> This can be relaxed later if a use case for other combinations arises.
>
> Fixes: b103fb7653ff ("fscrypt: add support for IV_INO_LBLK_64 policies")
> Fixes: e3b1078bedd3 ("fscrypt: add support for IV_INO_LBLK_32 policies")
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/crypto/policy.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/fs/crypto/policy.c b/fs/crypto/policy.c
> index 8a8ad0e44bb8..8e667aadf271 100644
> --- a/fs/crypto/policy.c
> +++ b/fs/crypto/policy.c
> @@ -77,6 +77,20 @@ static bool supported_iv_ino_lblk_policy(const struct fscrypt_policy_v2 *policy,
> struct super_block *sb = inode->i_sb;
> int ino_bits = 64, lblk_bits = 64;
>
> + /*
> + * IV_INO_LBLK_* exist only because of hardware limitations, and
> + * currently the only known use case for them involves AES-256-XTS.
> + * That's also all we test currently. For these reasons, for now only
> + * allow AES-256-XTS here. This can be relaxed later if a use case for
> + * IV_INO_LBLK_* with other encryption modes arises.
> + */
> + if (policy->contents_encryption_mode != FSCRYPT_MODE_AES_256_XTS) {
> + fscrypt_warn(inode,
> + "Can't use %s policy with contents mode other than AES-256-XTS",
> + type);
> + return false;
> + }
> +
> /*
> * It's unsafe to include inode numbers in the IVs if the filesystem can
> * potentially renumber inodes, e.g. via filesystem shrinking.
> --
Applied to fscrypt.git#master for 5.9.
- Eric
prev parent reply other threads:[~2020-07-27 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 18:10 [PATCH] fscrypt: restrict IV_INO_LBLK_* to AES-256-XTS Eric Biggers
2020-07-27 16:35 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727163519.GB1138@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=paulcrowley@google.com \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).