From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [PATCH v6 6/7] fscrypt: document inline encryption support
Date: Mon, 27 Jul 2020 09:43:10 -0700 [thread overview]
Message-ID: <20200727164310.GD1138@sol.localdomain> (raw)
In-Reply-To: <20200724184501.1651378-7-satyat@google.com>
On Fri, Jul 24, 2020 at 06:45:00PM +0000, Satya Tangirala wrote:
> Update the fscrypt documentation file for inline encryption support.
>
> Signed-off-by: Satya Tangirala <satyat@google.com>
> Reviewed-by: Eric Biggers <ebiggers@google.com>
> Reviewed-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> Documentation/filesystems/fscrypt.rst | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/fscrypt.rst b/Documentation/filesystems/fscrypt.rst
> index 1a6ad6f736b5..423c5a0daf45 100644
> --- a/Documentation/filesystems/fscrypt.rst
> +++ b/Documentation/filesystems/fscrypt.rst
> @@ -1204,6 +1204,18 @@ buffer. Some filesystems, such as UBIFS, already use temporary
> buffers regardless of encryption. Other filesystems, such as ext4 and
> F2FS, have to allocate bounce pages specially for encryption.
>
> +Fscrypt is also able to use inline encryption hardware instead of the
> +kernel crypto API for en/decryption of file contents. When possible,
> +and if directed to do so (by specifying the 'inlinecrypt' mount option
> +for an ext4/F2FS filesystem), it adds encryption contexts to bios and
> +uses blk-crypto to perform the en/decryption instead of making use of
> +the above read/write path changes. Of course, even if directed to
> +make use of inline encryption, fscrypt will only be able to do so if
> +either hardware inline encryption support is available for the
> +selected encryption algorithm or CONFIG_BLK_INLINE_ENCRYPTION_FALLBACK
> +is selected. If neither is the case, fscrypt will fall back to using
> +the above mentioned read/write path changes for en/decryption.
> +
> Filename hashing and encoding
> -----------------------------
>
> @@ -1250,7 +1262,9 @@ Tests
>
> To test fscrypt, use xfstests, which is Linux's de facto standard
> filesystem test suite. First, run all the tests in the "encrypt"
> -group on the relevant filesystem(s). For example, to test ext4 and
> +group on the relevant filesystem(s). One can also run the tests
> +with the 'inlinecrypt' mount option to test the implementation for
> +inline encryption support. For example, to test ext4 and
> f2fs encryption using `kvm-xfstests
> <https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md>`_::
Since this patch is separate from the direct I/O support, I've applied it to
fscrypt.git#master for 5.9. I'm not applying the direct I/O patches yet.
- Eric
next prev parent reply other threads:[~2020-07-27 16:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 18:44 [PATCH v6 0/7] add support for direct I/O with fscrypt using blk-crypto Satya Tangirala
2020-07-24 18:44 ` [PATCH v6 1/7] fscrypt: Add functions for direct I/O support Satya Tangirala
2020-07-25 0:14 ` Dave Chinner
2020-07-26 2:49 ` [f2fs-dev] " Eric Biggers
2020-07-27 0:58 ` Dave Chinner
2020-07-27 2:59 ` Eric Biggers
2020-07-27 4:47 ` Dave Chinner
2020-07-24 18:44 ` [PATCH v6 2/7] direct-io: add support for fscrypt using blk-crypto Satya Tangirala
2020-07-24 18:44 ` [PATCH v6 3/7] iomap: support direct I/O with " Satya Tangirala
2020-07-24 18:44 ` [PATCH v6 4/7] ext4: " Satya Tangirala
2020-07-24 18:44 ` [PATCH v6 5/7] f2fs: " Satya Tangirala
2020-07-24 18:45 ` [PATCH v6 6/7] fscrypt: document inline encryption support Satya Tangirala
2020-07-27 16:43 ` Eric Biggers [this message]
2020-07-24 18:45 ` [PATCH v6 7/7] fscrypt: update documentation for direct I/O support Satya Tangirala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727164310.GD1138@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).