Linux-FSCrypt Archive on lore.kernel.org
 help / color / Atom feed
* [xfstests-bld PATCH] test-appliance: exclude generic/587 from the encrypt tests
@ 2020-07-09 18:37 Satya Tangirala
  2020-07-09 18:41 ` Eric Biggers
  0 siblings, 1 reply; 8+ messages in thread
From: Satya Tangirala @ 2020-07-09 18:37 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: linux-fscrypt, linux-ext4, Satya Tangirala

The encryption feature doesn't play well with quota, and generic/587
tests quota functionality.

Signed-off-by: Satya Tangirala <satyat@google.com>
---
 .../test-appliance/files/root/fs/ext4/cfg/encrypt.exclude        | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
index 47c26e7..07111c2 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
@@ -24,6 +24,7 @@ generic/270
 generic/381
 generic/382
 generic/566
+generic/587
 
 # encryption doesn't play well with casefold (at least not yet)
 generic/556
-- 
2.27.0.383.g050319c2ae-goog


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [xfstests-bld PATCH] test-appliance: exclude generic/587 from the encrypt tests
  2020-07-09 18:37 [xfstests-bld PATCH] test-appliance: exclude generic/587 from the encrypt tests Satya Tangirala
@ 2020-07-09 18:41 ` Eric Biggers
  2020-07-09 18:58   ` [xfstests-bld PATCH v2] " Satya Tangirala
  0 siblings, 1 reply; 8+ messages in thread
From: Eric Biggers @ 2020-07-09 18:41 UTC (permalink / raw)
  To: Satya Tangirala; +Cc: Theodore Ts'o, linux-fscrypt, linux-ext4

On Thu, Jul 09, 2020 at 06:37:01PM +0000, Satya Tangirala wrote:
> The encryption feature doesn't play well with quota, and generic/587
> tests quota functionality.
> 
> Signed-off-by: Satya Tangirala <satyat@google.com>
> ---
>  .../test-appliance/files/root/fs/ext4/cfg/encrypt.exclude        | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> index 47c26e7..07111c2 100644
> --- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> +++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> @@ -24,6 +24,7 @@ generic/270
>  generic/381
>  generic/382
>  generic/566
> +generic/587
>  
>  # encryption doesn't play well with casefold (at least not yet)
>  generic/556
> -- 

Can you update encrypt_1k.exclude as well?

- Eric

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [xfstests-bld PATCH v2] test-appliance: exclude generic/587 from the encrypt tests
  2020-07-09 18:41 ` Eric Biggers
@ 2020-07-09 18:58   ` Satya Tangirala
  2020-07-09 19:10     ` Eric Biggers
  0 siblings, 1 reply; 8+ messages in thread
From: Satya Tangirala @ 2020-07-09 18:58 UTC (permalink / raw)
  To: Theodore Ts'o, ebiggers; +Cc: linux-fscrypt, linux-ext4, Satya Tangirala

The encryption feature doesn't play well with quota, and generic/587
tests quota functionality.

Signed-off-by: Satya Tangirala <satyat@google.com>
---
 .../test-appliance/files/root/fs/ext4/cfg/encrypt.exclude        | 1 +
 .../test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude     | 1 +
 2 files changed, 2 insertions(+)

diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
index 47c26e7..07111c2 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
@@ -24,6 +24,7 @@ generic/270
 generic/381
 generic/382
 generic/566
+generic/587
 
 # encryption doesn't play well with casefold (at least not yet)
 generic/556
diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude
index cd60151..1f5a7e5 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude
@@ -20,6 +20,7 @@ generic/235
 generic/270
 generic/382
 generic/204
+generic/587
 
 # These tests are also excluded in 1k.exclude.
 # See there for the reasons.
-- 
2.27.0.383.g050319c2ae-goog


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [xfstests-bld PATCH v2] test-appliance: exclude generic/587 from the encrypt tests
  2020-07-09 18:58   ` [xfstests-bld PATCH v2] " Satya Tangirala
@ 2020-07-09 19:10     ` Eric Biggers
  2020-09-01 16:17       ` Eric Biggers
  2020-09-24 17:27       ` Theodore Y. Ts'o
  0 siblings, 2 replies; 8+ messages in thread
From: Eric Biggers @ 2020-07-09 19:10 UTC (permalink / raw)
  To: Satya Tangirala; +Cc: Theodore Ts'o, linux-fscrypt, linux-ext4

On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> The encryption feature doesn't play well with quota, and generic/587
> tests quota functionality.
> 
> Signed-off-by: Satya Tangirala <satyat@google.com>

Reviewed-by: Eric Biggers <ebiggers@google.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [xfstests-bld PATCH v2] test-appliance: exclude generic/587 from the encrypt tests
  2020-07-09 19:10     ` Eric Biggers
@ 2020-09-01 16:17       ` Eric Biggers
  2020-09-21 18:42         ` Eric Biggers
  2020-09-24 17:27       ` Theodore Y. Ts'o
  1 sibling, 1 reply; 8+ messages in thread
From: Eric Biggers @ 2020-09-01 16:17 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: Satya Tangirala, linux-fscrypt, linux-ext4

On Thu, Jul 09, 2020 at 12:10:31PM -0700, Eric Biggers wrote:
> On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> > The encryption feature doesn't play well with quota, and generic/587
> > tests quota functionality.
> > 
> > Signed-off-by: Satya Tangirala <satyat@google.com>
> 
> Reviewed-by: Eric Biggers <ebiggers@google.com>

Ted, are you planning to apply this?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [xfstests-bld PATCH v2] test-appliance: exclude generic/587 from the encrypt tests
  2020-09-01 16:17       ` Eric Biggers
@ 2020-09-21 18:42         ` Eric Biggers
  0 siblings, 0 replies; 8+ messages in thread
From: Eric Biggers @ 2020-09-21 18:42 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: Satya Tangirala, linux-fscrypt, linux-ext4

On Tue, Sep 01, 2020 at 09:17:26AM -0700, Eric Biggers wrote:
> On Thu, Jul 09, 2020 at 12:10:31PM -0700, Eric Biggers wrote:
> > On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> > > The encryption feature doesn't play well with quota, and generic/587
> > > tests quota functionality.
> > > 
> > > Signed-off-by: Satya Tangirala <satyat@google.com>
> > 
> > Reviewed-by: Eric Biggers <ebiggers@google.com>
> 
> Ted, are you planning to apply this?

Ping.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [xfstests-bld PATCH v2] test-appliance: exclude generic/587 from the encrypt tests
  2020-07-09 19:10     ` Eric Biggers
  2020-09-01 16:17       ` Eric Biggers
@ 2020-09-24 17:27       ` Theodore Y. Ts'o
  2020-09-28 22:06         ` Eric Biggers
  1 sibling, 1 reply; 8+ messages in thread
From: Theodore Y. Ts'o @ 2020-09-24 17:27 UTC (permalink / raw)
  To: Eric Biggers; +Cc: Satya Tangirala, linux-fscrypt, linux-ext4

On Thu, Jul 09, 2020 at 12:10:31PM -0700, Eric Biggers wrote:
> On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> > The encryption feature doesn't play well with quota, and generic/587
> > tests quota functionality.
> > 
> > Signed-off-by: Satya Tangirala <satyat@google.com>
> 
> Reviewed-by: Eric Biggers <ebiggers@google.com>

Applied, thanks

						- Ted

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [xfstests-bld PATCH v2] test-appliance: exclude generic/587 from the encrypt tests
  2020-09-24 17:27       ` Theodore Y. Ts'o
@ 2020-09-28 22:06         ` Eric Biggers
  0 siblings, 0 replies; 8+ messages in thread
From: Eric Biggers @ 2020-09-28 22:06 UTC (permalink / raw)
  To: Theodore Y. Ts'o; +Cc: Satya Tangirala, linux-fscrypt, linux-ext4

On Thu, Sep 24, 2020 at 01:27:29PM -0400, Theodore Y. Ts'o wrote:
> On Thu, Jul 09, 2020 at 12:10:31PM -0700, Eric Biggers wrote:
> > On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> > > The encryption feature doesn't play well with quota, and generic/587
> > > tests quota functionality.
> > > 
> > > Signed-off-by: Satya Tangirala <satyat@google.com>
> > 
> > Reviewed-by: Eric Biggers <ebiggers@google.com>
> 
> Applied, thanks
> 

Thanks.  Looks like you forgot to push?  Also, the kernel.org and github
repositories for xfstests-bld aren't in sync.

- Eric

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09 18:37 [xfstests-bld PATCH] test-appliance: exclude generic/587 from the encrypt tests Satya Tangirala
2020-07-09 18:41 ` Eric Biggers
2020-07-09 18:58   ` [xfstests-bld PATCH v2] " Satya Tangirala
2020-07-09 19:10     ` Eric Biggers
2020-09-01 16:17       ` Eric Biggers
2020-09-21 18:42         ` Eric Biggers
2020-09-24 17:27       ` Theodore Y. Ts'o
2020-09-28 22:06         ` Eric Biggers

Linux-FSCrypt Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fscrypt/0 linux-fscrypt/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fscrypt linux-fscrypt/ https://lore.kernel.org/linux-fscrypt \
		linux-fscrypt@vger.kernel.org
	public-inbox-index linux-fscrypt

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fscrypt


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git