linux-fscrypt.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-crypto@vger.kernel.org
Cc: linux-fscrypt@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
	"Theodore Y. Ts'o" <tytso@mit.edu>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	Eric Biggers <ebiggers@kernel.org>
Subject: [PATCH 1/2] fscrypt: relax Kconfig dependencies for crypto API algorithms
Date: Fri, 16 Apr 2021 18:06:41 +0200	[thread overview]
Message-ID: <20210416160642.85387-2-ardb@kernel.org> (raw)
In-Reply-To: <20210416160642.85387-1-ardb@kernel.org>

Even if FS encryption has strict functional dependencies on various
crypto algorithms and chaining modes. those dependencies could potentially
be satisified by other implementations than the generic ones, and no link
time dependency exists on the 'depends on' claused defined by
CONFIG_FS_ENCRYPTION_ALGS.

So let's relax these clauses to 'imply', so that the default behavior
is still to pull in those generic algorithms, but in a way that permits
them to be disabled again in Kconfig.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 fs/crypto/Kconfig | 23 ++++++++++++++------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/fs/crypto/Kconfig b/fs/crypto/Kconfig
index a5f5c30368a2..1e6c11de95c8 100644
--- a/fs/crypto/Kconfig
+++ b/fs/crypto/Kconfig
@@ -17,13 +17,22 @@ config FS_ENCRYPTION
 # allows the algorithms to be built as modules when all the filesystems are.
 config FS_ENCRYPTION_ALGS
 	tristate
-	select CRYPTO_AES
-	select CRYPTO_CBC
-	select CRYPTO_CTS
-	select CRYPTO_ECB
-	select CRYPTO_HMAC
-	select CRYPTO_SHA512
-	select CRYPTO_XTS
+	imply CRYPTO_AES
+	imply CRYPTO_CBC
+	imply CRYPTO_CTS
+	imply CRYPTO_ECB
+	imply CRYPTO_HMAC
+	imply CRYPTO_SHA512
+	imply CRYPTO_XTS
+	help
+	  This pulls in the generic implementations of the various
+	  cryptographic algorithms and chaining modes that filesystem
+	  encryption relies on. These are 'soft' dependencies only, as
+	  architectures may supersede these generic implementations with
+	  special, optimized ones.
+
+	  If unsure, keep the generic algorithms enabled, as they can
+	  happily co-exist with per-architecture implementations.
 
 config FS_ENCRYPTION_INLINE_CRYPT
 	bool "Enable fscrypt to use inline crypto"
-- 
2.30.2


  reply	other threads:[~2021-04-16 16:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 16:06 [PATCH 0/2] relax crypto Kconfig dependencies for fsverity/fscrypt Ard Biesheuvel
2021-04-16 16:06 ` Ard Biesheuvel [this message]
2021-04-19 22:03   ` [PATCH 1/2] fscrypt: relax Kconfig dependencies for crypto API algorithms Eric Biggers
2021-04-16 16:06 ` [PATCH 2/2] fsverity: relax build time dependency on CRYPTO_SHA256 Ard Biesheuvel
2021-04-19 22:05   ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210416160642.85387-2-ardb@kernel.org \
    --to=ardb@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=tytso@mit.edu \
    --subject='Re: [PATCH 1/2] fscrypt: relax Kconfig dependencies for crypto API algorithms' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).