From: Jes Sorensen <jes.sorensen@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, kernel-team@fb.com,
Jes Sorensen <jsorensen@fb.com>
Subject: Re: [PATCH 2/2] Let package manager override CFLAGS and CPPFLAGS
Date: Wed, 20 May 2020 17:20:27 -0400 [thread overview]
Message-ID: <28bc7cbd-2f28-fa97-6393-56478d3dc345@gmail.com> (raw)
In-Reply-To: <20200520210622.GB218475@gmail.com>
On 5/20/20 5:06 PM, Eric Biggers wrote:
> On Wed, May 20, 2020 at 04:08:11PM -0400, Jes Sorensen wrote:
>> From: Jes Sorensen <jsorensen@fb.com>
>>
>> Package managers such as RPM wants to build everything with their
>> preferred flags, and we shouldn't hard override flags.
>>
>> Signed-off-by: Jes Sorensen <jsorensen@fb.com>
>> ---
>> Makefile | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index e7fb5cf..7bcd5e4 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -32,15 +32,14 @@ cc-option = $(shell if $(CC) $(1) -c -x c /dev/null -o /dev/null &>/dev/null; \
>> #### Common compiler flags. You can add additional flags by defining CFLAGS
>> #### and/or CPPFLAGS in the environment or on the 'make' command line.
>
> The above comment is still being made outdated. IMO, just remove it.
Good point, I'll send out a v3.
>>
>> -override CFLAGS := -O2 -Wall -Wundef \
>> +CFLAGS := -O2 -Wall -Wundef \
>> $(call cc-option,-Wdeclaration-after-statement) \
>> $(call cc-option,-Wmissing-prototypes) \
>> $(call cc-option,-Wstrict-prototypes) \
>> $(call cc-option,-Wvla) \
>> - $(call cc-option,-Wimplicit-fallthrough) \
>> - $(CFLAGS)
>> + $(call cc-option,-Wimplicit-fallthrough)
>>
>> -override CPPFLAGS := -D_FILE_OFFSET_BITS=64 $(CPPFLAGS)
>> +CPPFLAGS := -D_FILE_OFFSET_BITS=64 $(CPPFLAGS)
>
> On the other thread you ageed that CPPFLAGS should be left as-is, but here you
> removed 'override'. I think always using -D_FILE_OFFSET_BITS=64 is what we
> want, since it avoids incorrect builds on 32-bit platforms. Right?
That should work I think, I read your response as agreeing with me,
hence leaving the change in place.
Cheers,
Jes
next prev parent reply other threads:[~2020-05-20 21:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 20:08 [PATCH v2 0/2] fsverity-utils Makefile fixes Jes Sorensen
2020-05-20 20:08 ` [PATCH 1/2] Fix Makefile to delete objects from the library on make clean Jes Sorensen
2020-05-20 20:08 ` [PATCH 2/2] Let package manager override CFLAGS and CPPFLAGS Jes Sorensen
2020-05-20 21:06 ` Eric Biggers
2020-05-20 21:20 ` Jes Sorensen [this message]
2020-05-20 21:03 ` [PATCH v2 0/2] fsverity-utils Makefile fixes Eric Biggers
2020-05-20 21:04 ` Jes Sorensen
-- strict thread matches above, loose matches on Subject: below --
2020-05-20 21:25 [PATCH v3 " Jes Sorensen
2020-05-20 21:25 ` [PATCH 2/2] Let package manager override CFLAGS and CPPFLAGS Jes Sorensen
2020-05-15 20:56 [PATCH 0/2] fsverity-utils Makefile fixes Jes Sorensen
2020-05-15 20:56 ` [PATCH 2/2] Let package manager override CFLAGS and CPPFLAGS Jes Sorensen
2020-05-20 2:54 ` Eric Biggers
2020-05-20 20:00 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28bc7cbd-2f28-fa97-6393-56478d3dc345@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=ebiggers@kernel.org \
--cc=jsorensen@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).