From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA874C35249 for ; Wed, 5 Feb 2020 04:21:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 903DC21741 for ; Wed, 5 Feb 2020 04:21:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727834AbgBEEVm (ORCPT ); Tue, 4 Feb 2020 23:21:42 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:47498 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727846AbgBEEVm (ORCPT ); Tue, 4 Feb 2020 23:21:42 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 694AB29298E From: Gabriel Krisman Bertazi To: Daniel Rosenberg Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, Alexander Viro , Richard Weinberger , linux-mtd@lists.infradead.org, Andreas Dilger , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v6 1/5] unicode: Add standard casefolded d_ops Organization: Collabora References: <20200128230328.183524-1-drosen@google.com> <20200128230328.183524-2-drosen@google.com> <85sgjsxx2g.fsf@collabora.com> Date: Tue, 04 Feb 2020 23:21:33 -0500 In-Reply-To: (Daniel Rosenberg's message of "Tue, 4 Feb 2020 19:05:02 -0800") Message-ID: <85h8051x6a.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org Daniel Rosenberg writes: > On Sun, Feb 2, 2020 at 5:46 PM Gabriel Krisman Bertazi > wrote: >> >> >> I don't think fs/unicode is the right place for these very specific >> filesystem functions, just because they happen to use unicode. It is an >> encoding library, it doesn't care about dentries, nor should know how to >> handle them. It exposes a simple api to manipulate and convert utf8 strings. >> >> I saw change was after the desire to not have these functions polluting >> the VFS hot path, but that has nothing to do with placing them here. >> >> Would libfs be better? or a casefolding library in fs/casefold.c? >> >> >> -- >> Gabriel Krisman Bertazi > > The hash function needs access to utf8ncursor, but apart from that, > libfs would make sense. utf8ncursor is the only reason I have them > here. How do you feel about exposing utf8cursor or something similar? Hi, It was designed to be an internal thing, but I'm ok with exposing it. -- Gabriel Krisman Bertazi