From: Daniel Rosenberg <drosen@google.com>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <chao@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-fscrypt@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v9 4/4] ext4: Use generic casefolding support
Date: Tue, 7 Jul 2020 03:44:06 -0700 [thread overview]
Message-ID: <CA+PiJmQN6Mkqq3aA+v6032QZehHs2sTqthzM-NqZN6k3jGBJvg@mail.gmail.com> (raw)
In-Reply-To: <877dvxggsl.fsf@collabora.com>
On Tue, Jun 23, 2020 at 10:43 PM Gabriel Krisman Bertazi
<krisman@collabora.com> wrote:
>
> Daniel Rosenberg <drosen@google.com> writes:
>
> > -
> > const struct dentry_operations ext4_dentry_ops = {
> > - .d_hash = ext4_d_hash,
> > - .d_compare = ext4_d_compare,
> > + .d_hash = generic_ci_d_hash,
> > + .d_compare = generic_ci_d_compare,
> > };
> > #endif
>
> Can you make the structure generic since it is the same for f2fs and
> ext4, which let you drop the code guards? Unless that becomes a problem for
> d_revalidate with fscrypt, it is fine like this.
>
> --
> Gabriel Krisman Bertazi
I unify them in a later patch, since I end up having to deal with
fscrypt's d_revalidate. With that patch I'd end up undoing the export
I'd add for this, so I'll skip that for the moment.
-Daniel
next prev parent reply other threads:[~2020-07-07 10:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 4:33 [PATCH v9 0/4] Prepare for upcoming Casefolding/Encryption patches Daniel Rosenberg
2020-06-24 4:33 ` [PATCH v9 1/4] unicode: Add utf8_casefold_hash Daniel Rosenberg
2020-06-24 5:13 ` Gabriel Krisman Bertazi
2020-06-24 5:37 ` Eric Biggers
2020-06-24 4:33 ` [PATCH v9 2/4] fs: Add standard casefolding support Daniel Rosenberg
2020-06-24 5:33 ` Gabriel Krisman Bertazi
2020-06-24 5:42 ` Eric Biggers
2020-06-24 5:57 ` Eric Biggers
2020-07-03 1:01 ` Daniel Rosenberg
2020-07-03 19:20 ` Eric Biggers
2020-06-24 4:33 ` [PATCH v9 3/4] f2fs: Use generic " Daniel Rosenberg
2020-06-24 4:33 ` [PATCH v9 4/4] ext4: " Daniel Rosenberg
2020-06-24 5:43 ` Gabriel Krisman Bertazi
2020-07-07 10:44 ` Daniel Rosenberg [this message]
2020-06-24 6:04 ` Eric Biggers
2020-06-24 5:34 ` [PATCH v9 0/4] Prepare for upcoming Casefolding/Encryption patches Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+PiJmQN6Mkqq3aA+v6032QZehHs2sTqthzM-NqZN6k3jGBJvg@mail.gmail.com \
--to=drosen@google.com \
--cc=adilger.kernel@dilger.ca \
--cc=chao@kernel.org \
--cc=corbet@lwn.net \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=krisman@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).