From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 431D8C2D0B1 for ; Wed, 5 Feb 2020 03:05:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16797217F4 for ; Wed, 5 Feb 2020 03:05:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="a/rT7owE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727774AbgBEDFP (ORCPT ); Tue, 4 Feb 2020 22:05:15 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:37392 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727910AbgBEDFP (ORCPT ); Tue, 4 Feb 2020 22:05:15 -0500 Received: by mail-lf1-f67.google.com with SMTP id b15so369233lfc.4 for ; Tue, 04 Feb 2020 19:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5WF1go+DuJvbwgdXeUhoD65NaX1JQ7zRHimo51GmC8M=; b=a/rT7owEo3U/lPRFn35JOyHmNdZNKq3CUN5eC0vmSOAlGMUJJc7ELCvSX1Mh8APfaa lAlLVERWXR5pYN81ddhMclRnb/OmN5Fx2KddB7KuZLDfFPyFM3c5qNNCCjwGgxr+r3s1 DNCcaZvM6VYKACKmTz/OjiTlKJVFN9VL8YzEYvQS2U83lFvZUm1XWKOklUIkQxQvXozG vNU7Zo1syf0hTTILG3oFQfUcj+JQqVr59fj+c5MCVuSCuEvLrPxTFeYRhYsiMU1wniYS k/ew5rFlhFL2LzMHulEuIV3u33upCBPfLhXENQXAIsbZYUZT2I99yQmfa/FkquxeDAIP aNXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5WF1go+DuJvbwgdXeUhoD65NaX1JQ7zRHimo51GmC8M=; b=PHwGNaT/6nTbGAuxxDX8u2YRF4FPq0m7qTDt9VHcMgS9zV+KbxR3PO6nWLwhwF8bil hpw11cRrTI8R701r3QEZnaJY0qQJLRAnYphi5C+fesA4bTt4S1qowQgkj+nuHxDlcREq kyn6Ov84dehZQJ8wrlbM9DxvXwgF2yNyVBwPBUzYk/5YhpK7I80rUkv5YLN+oGh/rW2N 56AA8GhssWQtJnAVV646sCy7Sjep61NXfdRj7sscXuBOSpc6n7GRUSdxpxBL6OptxvS8 hrRiKL845vL4xyFZbYYyuM4GIsAQ9F7C5YtIIilXBvv/IGx3A9ahb3+Jw6mR5EWi4Ik6 qSyQ== X-Gm-Message-State: APjAAAVPYM5BHUV+OW73bgK3V4qUA9P1uL7mNgIh1iz/ZZMO2MUr06i/ BpkfA3UNPDdBcTqtOvZ8CzPBfiFhyIpgUwHOPMNzqw== X-Google-Smtp-Source: APXvYqzeG4caRRvcRllow4EA73MGmU6WFhFNYJbaTAD8sJamhzsXSFSCQuZUYpZgWEJovRgzDpyi7R9sxFKJltzNJtg= X-Received: by 2002:a19:4a92:: with SMTP id x140mr17094713lfa.29.1580871913677; Tue, 04 Feb 2020 19:05:13 -0800 (PST) MIME-Version: 1.0 References: <20200128230328.183524-1-drosen@google.com> <20200128230328.183524-2-drosen@google.com> <85sgjsxx2g.fsf@collabora.com> In-Reply-To: <85sgjsxx2g.fsf@collabora.com> From: Daniel Rosenberg Date: Tue, 4 Feb 2020 19:05:02 -0800 Message-ID: Subject: Re: [PATCH v6 1/5] unicode: Add standard casefolded d_ops To: Gabriel Krisman Bertazi Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, Alexander Viro , Richard Weinberger , linux-mtd@lists.infradead.org, Andreas Dilger , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Sun, Feb 2, 2020 at 5:46 PM Gabriel Krisman Bertazi wrote: > > > I don't think fs/unicode is the right place for these very specific > filesystem functions, just because they happen to use unicode. It is an > encoding library, it doesn't care about dentries, nor should know how to > handle them. It exposes a simple api to manipulate and convert utf8 strings. > > I saw change was after the desire to not have these functions polluting > the VFS hot path, but that has nothing to do with placing them here. > > Would libfs be better? or a casefolding library in fs/casefold.c? > > > -- > Gabriel Krisman Bertazi The hash function needs access to utf8ncursor, but apart from that, libfs would make sense. utf8ncursor is the only reason I have them here. How do you feel about exposing utf8cursor or something similar?