Linux-FSCrypt Archive on lore.kernel.org
 help / color / Atom feed
From: Daeho Jeong <daeho43@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
	Daeho Jeong <daehojeong@google.com>,
	linux-fscrypt@vger.kernel.org, fstests@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 0/5] xfstests: test f2fs compression+encryption
Date: Wed, 7 Oct 2020 13:27:13 +0900
Message-ID: <CACOAw_xO83YJjDoAK3O7aCK53pEihg=fTp-bMgkDsVM9_rMwEg@mail.gmail.com> (raw)
In-Reply-To: <20201007034829.GA912@sol.localdomain>

Sorry for the late reply. We had a long holiday last week.
The patch looks good to me~

Thanks,

2020년 10월 7일 (수) 오후 12:49, Eric Biggers <ebiggers@kernel.org>님이 작성:
>
> On Wed, Sep 30, 2020 at 05:25:02PM -0700, Eric Biggers wrote:
> > Add a test which verifies that encryption is done correctly when a file
> > on f2fs uses both compression and encryption at the same time.
> >
> > Patches 1-4 add prerequisites for the test, while patch 5 adds the
> > actual test.  Patch 2 also fixes a bug which could cause the existing
> > test generic/602 to fail in extremely rare cases.  See the commit
> > messages for details.
> >
> > The new test passes both with and without the inlinecrypt mount option.
> > It requires CONFIG_F2FS_FS_COMPRESSION=y.
> >
> > I'd appreciate the f2fs developers taking a look.
> >
> > Note, there is a quirk where the IVs in compressed files are off by one
> > from the "natural" values.  It's still secure, though it made the test
> > slightly harder to write.  I'm not sure how intentional this quirk was.
> >
> > Eric Biggers (5):
> >   fscrypt-crypt-util: clean up parsing --block-size and --inode-number
> >   fscrypt-crypt-util: fix IV incrementing for --iv-ino-lblk-32
> >   fscrypt-crypt-util: add --block-number option
> >   common/f2fs: add _require_scratch_f2fs_compression()
> >   f2fs: verify ciphertext of compressed+encrypted file
>
> Jaegeuk, Chao, Daeho: any comments on this?
>
> - Eric
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

      reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01  0:25 Eric Biggers
2020-10-01  0:25 ` [PATCH 1/5] fscrypt-crypt-util: clean up parsing --block-size and --inode-number Eric Biggers
2020-10-01  0:25 ` [PATCH 2/5] fscrypt-crypt-util: fix IV incrementing for --iv-ino-lblk-32 Eric Biggers
2020-10-01  0:25 ` [PATCH 3/5] fscrypt-crypt-util: add --block-number option Eric Biggers
2020-10-01  0:25 ` [PATCH 4/5] common/f2fs: add _require_scratch_f2fs_compression() Eric Biggers
2020-10-01  0:25 ` [PATCH 5/5] f2fs: verify ciphertext of compressed+encrypted file Eric Biggers
2020-10-07  3:48 ` [PATCH 0/5] xfstests: test f2fs compression+encryption Eric Biggers
2020-10-07  4:27   ` Daeho Jeong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACOAw_xO83YJjDoAK3O7aCK53pEihg=fTp-bMgkDsVM9_rMwEg@mail.gmail.com' \
    --to=daeho43@gmail.com \
    --cc=daehojeong@google.com \
    --cc=ebiggers@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-FSCrypt Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fscrypt/0 linux-fscrypt/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fscrypt linux-fscrypt/ https://lore.kernel.org/linux-fscrypt \
		linux-fscrypt@vger.kernel.org
	public-inbox-index linux-fscrypt

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fscrypt


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git