From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52C8DC433E2 for ; Tue, 14 Jul 2020 16:59:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 339CB22571 for ; Tue, 14 Jul 2020 16:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594745998; bh=hfGULgx6cVGhSXYUjwr08O37iYZjxDOqExPxcVgLX20=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=KlQYrvYby+h0JOc/hcLHiGul6rXq9khiC/uAQK9uwwB+NNMxoOi6eiiPsV+G4Q6yf pwjxA9a7vLa5x9f7rVuDrvPi6g+EAMPBmY+12NGxElHBonCKhRrkzJfA9jyg8ofUqx 330brDAEV3YKtLWUn+N1Jpq/ZebF/4VvNvdkH4js= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728392AbgGNQ75 (ORCPT ); Tue, 14 Jul 2020 12:59:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:43072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbgGNQ75 (ORCPT ); Tue, 14 Jul 2020 12:59:57 -0400 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 86F6F22573; Tue, 14 Jul 2020 16:59:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594745996; bh=hfGULgx6cVGhSXYUjwr08O37iYZjxDOqExPxcVgLX20=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IVz7G9dnWJcklodZApZc+PE5LAOinEhXCAeRs+OuKyMHKcXp6G+gxfBhVLZoEU2sY 4CU08uJ83+WTma1I/1NOONviXlQFiTvrHqLn9vSGpSzTZj11cVLhZnIcs3jOn6wIqr hF+k1mUe7Aq7JpFhneCOfHaWFIQbMw3vp6ahg/00= Received: by mail-oi1-f180.google.com with SMTP id y22so14447106oie.8; Tue, 14 Jul 2020 09:59:56 -0700 (PDT) X-Gm-Message-State: AOAM530BGP4k/iCXXCGa4o2lgFjlj1PoYolIHYUoN+8A2fnuqSqow4wm XY8XrycO8XRQfnisL4Z2k7zQKU3JVF0JWb57Xw== X-Google-Smtp-Source: ABdhPJwv5DtvHNqkpG1lMxmy6zg7lYTz/pvjdCAG8t+hqEI7IbsYj4R6P0ANEAPuU+Zw88Djpz3Btrixh7w8DMOHHd8= X-Received: by 2002:aca:bb82:: with SMTP id l124mr4592017oif.106.1594745995936; Tue, 14 Jul 2020 09:59:55 -0700 (PDT) MIME-Version: 1.0 References: <20200710072013.177481-1-ebiggers@kernel.org> <20200710072013.177481-4-ebiggers@kernel.org> <20200714161516.GA1064009@gmail.com> <20200714164353.GB1064009@gmail.com> In-Reply-To: <20200714164353.GB1064009@gmail.com> From: Rob Herring Date: Tue, 14 Jul 2020 10:59:44 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 3/5] arm64: dts: sdm845: add Inline Crypto Engine registers and clock To: Eric Biggers Cc: Andy Gross , Bjorn Andersson , SCSI , linux-arm-msm , linux-fscrypt@vger.kernel.org, Alim Akhtar , Avri Altman , Barani Muthukumaran , Can Guo , Elliot Berman , John Stultz , "Martin K. Petersen" , Satya Tangirala , Steev Klimaszewski , Thara Gopinath Content-Type: text/plain; charset="UTF-8" Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Tue, Jul 14, 2020 at 10:43 AM Eric Biggers wrote: > > On Tue, Jul 14, 2020 at 10:35:12AM -0600, Rob Herring wrote: > > On Tue, Jul 14, 2020 at 10:15 AM Eric Biggers wrote: > > > > > > On Tue, Jul 14, 2020 at 10:16:04AM -0400, Martin K. Petersen wrote: > > > > > > > > Eric, > > > > > > > > > Add the vendor-specific registers and clock for Qualcomm ICE (Inline > > > > > Crypto Engine) to the device tree node for the UFS host controller on > > > > > sdm845, so that the ufs-qcom driver will be able to use inline crypto. > > > > > > > > I would like to see an Acked-by for this patch before I merge it. > > > > > > > > > > Andy, Bjorn, or Rob: can you give Acked-by? > > > > DTS changes should go in via the QCom tree. > > > > So, the DTS patch can't be applied without the driver patches since then the > driver would misinterpret the ICE registers as the dev_ref_clk_ctrl registers. That sounds broken, but there's no context here for me to comment further. DTS changes should work with old/stable kernels. I'd suggest you get a review from Bjorn on the driver first. Rob