From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E27E9C433F5 for ; Mon, 20 Sep 2021 21:21:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9DEB61166 for ; Mon, 20 Sep 2021 21:21:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231946AbhITVXI (ORCPT ); Mon, 20 Sep 2021 17:23:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:35066 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbhITVVI (ORCPT ); Mon, 20 Sep 2021 17:21:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E4A1A61184; Mon, 20 Sep 2021 21:19:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632172781; bh=MplE7LBVAl9zXP9vwhf4BHK4PTdYkt2vg1hMEoTCasI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JBNyrDTQLj4Mp0YcyNUD7IQSnwgiKcpQ8BiGcJ8IKgyqIJI2PdeanBdr20NOQvysF 2i4vnKOxJG9QFGBMzsuZWKkYjha/oq9d3K2jiPDIYjV5UousrDhxAYSUKCiM7td6sA 4wXImuHuNi/E/M5jdfickkfnluSHoIgki3EviGpDB/g2ra3An1G7hoLEVdtR8Sq7et KJae94XALsa5XBKUvbkLbnYO/785n2BUgjUkRupQ+1uiCS/AYnA8OKDnC6uo+BO7fH uGOXDSqGZuQ94e6v1mTxFwF/OMHgyM5BHP6RHZwkaLxofnOS9ZwaQrw0878izgTLy9 Ta6am1zb6/0HQ== Date: Mon, 20 Sep 2021 14:19:39 -0700 From: Eric Biggers To: Aleksander Adamowski Cc: Tomasz =?utf-8?Q?K=C5=82oczko?= , "linux-fscrypt@vger.kernel.org" Subject: Re: [fsverity-utils] 1.4: test suite does not build Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Mon, Sep 20, 2021 at 08:05:25PM +0000, Aleksander Adamowski wrote: > On Saturday, September 18, 2021 1:04 PM, Eric Biggers wrote: > > Aleksander, can you look into these? > > These look like compiler warnings, why did they break the build? > > The reason for the warnings is that the Engines API that we use with OpenSSL <= > 1.1 has started to be deprecated with OpenSSL release 3.0. > > The replacement that OpenSSL offers is called "Providers": > https://www.openssl.org/docs/man3.0/man7/migration_guide.html#Engines-and-METHOD-APIs > > Unfortunately, the Providers API is only available starting with version 3.0, > the same version that deprecates Engines: > > https://www.openssl.org/docs/manmaster/man3/OSSL_PROVIDER_load.html > > So, our options here are: > > 1. Tolerate deprecation warnings from the compiler until the OpenSSL version > that provides the new replacement API is widespread enough to stop supporting > OpenSSL versions <= 1.1 (I think this is the most reasonable approach, after > all that's how deprecation mechanisms are meant to be used). > > 2. Use a bunch of preprocessor conditional #ifdefs to support both OpenSSL > pre-3.0 with Engines and post-3.0 with Providers. This would make code pretty > messy IMHO, but should be doable. I can start working on a patch if we get > consensus; however, my opinion is that we should withhold from that until > OpenSSL 3 is the standard release on mainstream distros. > Sorry, it looks like I misread Tomasz's email; the build break wasn't from those warnings but rather from the test programs not being linked to libfsverity. Tomasz, are you using the provided Makefile? In the Makefile, the test programs are linked correctly, so this isn't an issue. How can I reproduce your issue? Aleksander: there still shouldn't be any compiler warnings. In my test script (scripts/run-tests.sh) I actually use -Werror. If there isn't a good way to avoid these deprecation warnings (and I'd prefer not to have code that's conditional on different OpenSSL versions), we can just add -Wno-deprecated-declarations to the Makefile for now. - Eric