From: Christoph Hellwig <hch@infradead.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Nathan Huckleberry <nhuck@google.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-fscrypt@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/4] blk-mq: release crypto keyslot before reporting I/O complete
Date: Wed, 15 Mar 2023 09:18:38 -0700 [thread overview]
Message-ID: <ZBHv3m0c9Fzs9DHA@infradead.org> (raw)
In-Reply-To: <ZBC63ry7EFMr+Xzk@sol.localdomain>
On Tue, Mar 14, 2023 at 11:20:14AM -0700, Eric Biggers wrote:
> I did notice that attempt_merge() calls elv_merge_requests() (not to be confused
> with elv_merged_request()) if it merges the requests.
>
> So it seems there is elv_merge_requests() which means the request was merged,
> and elv_merged_request() which means the request was *not* merged... I have no
> idea what is going on there :-(
The naming looks very confusing, but that is indeed what the code
does. The elevator code is in massive need of a cleanup, as it often
is that confusing.
next prev parent reply other threads:[~2023-03-15 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 19:36 [PATCH v2 0/4] Fix blk-crypto keyslot race condition Eric Biggers
2023-03-08 19:36 ` [PATCH v2 1/4] blk-mq: release crypto keyslot before reporting I/O complete Eric Biggers
2023-03-13 21:26 ` Nathan Huckleberry
2023-03-14 18:20 ` Eric Biggers
2023-03-15 16:18 ` Christoph Hellwig [this message]
2023-03-15 16:19 ` Christoph Hellwig
2023-03-08 19:36 ` [PATCH v2 2/4] blk-crypto: make blk_crypto_evict_key() more robust Eric Biggers
2023-03-15 16:23 ` Christoph Hellwig
2023-03-15 18:26 ` Eric Biggers
2023-03-08 19:36 ` [PATCH v2 3/4] blk-crypto: remove blk_crypto_insert_cloned_request() Eric Biggers
2023-03-15 16:24 ` Christoph Hellwig
2023-03-15 18:27 ` Eric Biggers
2023-03-08 19:36 ` [PATCH v2 4/4] blk-crypto: drop the NULL check from blk_crypto_put_keyslot() Eric Biggers
2023-03-15 16:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBHv3m0c9Fzs9DHA@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=ebiggers@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=nhuck@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).