From: Jes Sorensen <jes.sorensen@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>, Jes Sorensen <jsorensen@fb.com>
Cc: linux-fscrypt@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 3/9] Move fsverity_descriptor definition to libfsverity.h
Date: Tue, 21 Apr 2020 12:20:38 -0400 [thread overview]
Message-ID: <dbdd7247-f624-bbee-da12-0dd74bca73bd@gmail.com> (raw)
In-Reply-To: <20200421161611.GA95716@gmail.com>
On 4/21/20 12:16 PM, Eric Biggers wrote:
> On Tue, Apr 21, 2020 at 12:07:07PM -0400, Jes Sorensen wrote:
>> On 3/22/20 12:57 AM, Eric Biggers wrote:
>>> I thought there was no need for this to be part of the library API?
>>
>> Hi Eric,
>>
>> Been busy working on RPM support, but looking at this again now. Given
>> that the fsverity signature is a hash of the descriptor, I don't see how
>> we can avoid this?
>>
>
> struct fsverity_descriptor isn't signed directly; it's hashed as an intermediate
> step in libfsverity_compute_digest(). So why would the library user need the
> definition of 'struct fsverity_descriptor'?
Hi Eric,
You're right, I actually moved it to libfsverity_private.h already, but
it's in the new patches I am working on.
I pushed it all to git.kernel.org, but I still need to address some of
the issues you responded about. I'll post an update to this when I have
worked through your list of comments. Most noticeable is that I had to
rework the read API to make it work with RPM, but you can find my
current tree here (libfsverity branch):
https://git.kernel.org/pub/scm/linux/kernel/git/jes/fsverity-utils.git/
Current RPM work is here:
https://github.com/jessorensen/rpm/tree/rpm-fsverity
Cheers,
Jes
next prev parent reply other threads:[~2020-04-21 16:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 21:47 [PATCH v3 0/9] Split fsverity-utils into a shared library Jes Sorensen
2020-03-12 21:47 ` [PATCH 1/9] Build basic shared library framework Jes Sorensen
2020-03-22 5:23 ` Eric Biggers
2020-03-22 5:33 ` Eric Biggers
2020-04-21 21:00 ` Jes Sorensen
2020-03-12 21:47 ` [PATCH 2/9] Change compute_file_measurement() to take a file descriptor as argument Jes Sorensen
2020-03-12 21:47 ` [PATCH 3/9] Move fsverity_descriptor definition to libfsverity.h Jes Sorensen
2020-03-22 4:57 ` Eric Biggers
2020-04-21 16:07 ` Jes Sorensen
2020-04-21 16:16 ` Eric Biggers
2020-04-21 16:20 ` Jes Sorensen [this message]
2020-03-12 21:47 ` [PATCH 4/9] Move hash algorithm code to shared library Jes Sorensen
2020-03-22 5:38 ` Eric Biggers
2020-04-22 17:57 ` Jes Sorensen
2020-03-12 21:47 ` [PATCH 5/9] Create libfsverity_compute_digest() and adapt cmd_sign to use it Jes Sorensen
2020-03-22 5:40 ` Eric Biggers
2020-03-12 21:47 ` [PATCH 6/9] Introduce libfsverity_sign_digest() Jes Sorensen
2020-03-12 21:47 ` [PATCH 7/9] Validate input arguments to libfsverity_compute_digest() Jes Sorensen
2020-03-12 21:47 ` [PATCH 8/9] Validate input parameters for libfsverity_sign_digest() Jes Sorensen
2020-03-22 5:27 ` Eric Biggers
2020-03-12 21:47 ` [PATCH 9/9] Document API of libfsverity Jes Sorensen
2020-03-22 5:54 ` Eric Biggers
2020-03-22 5:05 ` [PATCH v3 0/9] Split fsverity-utils into a shared library Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbdd7247-f624-bbee-da12-0dd74bca73bd@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=ebiggers@kernel.org \
--cc=jsorensen@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).