memory leak in create_pipe_files

memory leak in create_pipe_files

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    a581387e Merge tag 'io_uring-5.8-2020-07-10' of git://git...
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10ba1967100000
kernel config:  https://syzkaller.appspot.com/x/.config?x=13a9cfc3f50ff96
dashboard link: https://syzkaller.appspot.com/bug?extid=6a137efd811917e8b53c
compiler:       gcc (GCC) 10.1.0-syz 20200507
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=13d2004f100000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6a137efd811917e8b53c@syzkaller.appspotmail.com

BUG: memory leak
unreferenced object 0xffff88812a6c8800 (size 256):
  comm "syz-execprog", pid 6479, jiffies 4295096411 (age 83.520s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    20 2d 85 2a 81 88 ff ff 80 57 d2 15 81 88 ff ff   -.*.....W......
  backtrace:
    [<00000000057eb446>] kmem_cache_zalloc include/linux/slab.h:659 [inline]
    [<00000000057eb446>] __alloc_file+0x23/0x120 fs/file_table.c:101
    [<0000000046b459a4>] alloc_empty_file+0x4f/0xe0 fs/file_table.c:151
    [<00000000fced1caf>] alloc_file+0x31/0x160 fs/file_table.c:193
    [<0000000079549d8a>] alloc_file_pseudo+0xae/0x120 fs/file_table.c:233
    [<0000000058a70f71>] create_pipe_files+0x127/0x270 fs/pipe.c:931
    [<00000000ad5d09be>] __do_pipe_flags fs/pipe.c:964 [inline]
    [<00000000ad5d09be>] do_pipe2+0x43/0x110 fs/pipe.c:1012
    [<0000000038960906>] __do_sys_pipe2 fs/pipe.c:1030 [inline]
    [<0000000038960906>] __se_sys_pipe2 fs/pipe.c:1028 [inline]
    [<0000000038960906>] __x64_sys_pipe2+0x16/0x20 fs/pipe.c:1028
    [<00000000b1b64f40>] do_syscall_64+0x4c/0xe0 arch/x86/entry/common.c:384
    [<00000000e3fac4b7>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0xffff88812a7abb80 (size 16):
  comm "syz-execprog", pid 6479, jiffies 4295096411 (age 83.520s)
  hex dump (first 16 bytes):
    01 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<0000000029e2bcd5>] kmem_cache_zalloc include/linux/slab.h:659 [inline]
    [<0000000029e2bcd5>] lsm_file_alloc security/security.c:567 [inline]
    [<0000000029e2bcd5>] security_file_alloc+0x2e/0xc0 security/security.c:1455
    [<00000000884a9f66>] __alloc_file+0x61/0x120 fs/file_table.c:106
    [<0000000046b459a4>] alloc_empty_file+0x4f/0xe0 fs/file_table.c:151
    [<00000000fced1caf>] alloc_file+0x31/0x160 fs/file_table.c:193
    [<0000000079549d8a>] alloc_file_pseudo+0xae/0x120 fs/file_table.c:233
    [<0000000058a70f71>] create_pipe_files+0x127/0x270 fs/pipe.c:931
    [<00000000ad5d09be>] __do_pipe_flags fs/pipe.c:964 [inline]
    [<00000000ad5d09be>] do_pipe2+0x43/0x110 fs/pipe.c:1012
    [<0000000038960906>] __do_sys_pipe2 fs/pipe.c:1030 [inline]
    [<0000000038960906>] __se_sys_pipe2 fs/pipe.c:1028 [inline]
    [<0000000038960906>] __x64_sys_pipe2+0x16/0x20 fs/pipe.c:1028
    [<00000000b1b64f40>] do_syscall_64+0x4c/0xe0 arch/x86/entry/common.c:384
    [<00000000e3fac4b7>] entry_SYSCALL_64_after_hwframe+0x44/0xa9



---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

Re: memory leak in create_pipe_files

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit:    3aaf0a27 Merge tag 'clang-format-for-linux-v5.11-rc7' of g..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15d87364d00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=b7edd79f26f7c0c3
dashboard link: https://syzkaller.appspot.com/bug?extid=6a137efd811917e8b53c
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=10df828cd00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12c4f2f8d00000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6a137efd811917e8b53c@syzkaller.appspotmail.com

Warning: Permanently added '10.128.10.43' (ECDSA) to the list of known hosts.
executing program
executing program
BUG: memory leak
unreferenced object 0xffff888110f47600 (size 232):
  comm "kworker/u4:1", pid 8442, jiffies 4294942490 (age 13.540s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    60 2a 04 01 81 88 ff ff 80 2d 37 0f 81 88 ff ff  `*.......-7.....
  backtrace:
    [<000000007ea4ba2d>] kmem_cache_zalloc include/linux/slab.h:672 [inline]
    [<000000007ea4ba2d>] __alloc_file+0x1f/0xf0 fs/file_table.c:101
    [<00000000cdcab42a>] alloc_empty_file+0x69/0x120 fs/file_table.c:150
    [<00000000ca09bf0f>] alloc_file+0x33/0x1b0 fs/file_table.c:192
    [<00000000c44b2f75>] alloc_file_pseudo+0xb2/0x140 fs/file_table.c:232
    [<00000000a7d8ad8d>] create_pipe_files+0x138/0x2e0 fs/pipe.c:911
    [<000000007cde2906>] umd_setup+0x33/0x220 kernel/usermode_driver.c:104
    [<00000000566c5ffa>] call_usermodehelper_exec_async+0xb4/0x1b0 kernel/umh.c:101
    [<00000000f26cfa20>] ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:296

BUG: memory leak
unreferenced object 0xffff888113186300 (size 232):
  comm "kworker/u4:1", pid 8442, jiffies 4294942490 (age 13.540s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    60 2a 04 01 81 88 ff ff 00 d6 13 0f 81 88 ff ff  `*..............
  backtrace:
    [<000000007ea4ba2d>] kmem_cache_zalloc include/linux/slab.h:672 [inline]
    [<000000007ea4ba2d>] __alloc_file+0x1f/0xf0 fs/file_table.c:101
    [<00000000cdcab42a>] alloc_empty_file+0x69/0x120 fs/file_table.c:150
    [<00000000ca09bf0f>] alloc_file+0x33/0x1b0 fs/file_table.c:192
    [<0000000053d2fba9>] alloc_file_clone+0x22/0x70 fs/file_table.c:244
    [<000000002475fc17>] create_pipe_files+0x182/0x2e0 fs/pipe.c:922
    [<00000000bcdcee57>] umd_setup+0xad/0x220 kernel/usermode_driver.c:115
    [<00000000566c5ffa>] call_usermodehelper_exec_async+0xb4/0x1b0 kernel/umh.c:101
    [<00000000f26cfa20>] ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:296