From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Tetsuhiro Kohada'" <kohada.t2@gmail.com>,
<Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Cc: <Mori.Takahiro@ab.MitsubishiElectric.co.jp>,
<Motai.Hirotaka@aj.MitsubishiElectric.co.jp>,
"'Sungjong Seo'" <sj1557.seo@samsung.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] exfat: retain 'VolumeFlags' properly
Date: Thu, 30 Jul 2020 15:59:04 +0900 [thread overview]
Message-ID: <015e01d6663e$e99e4ec0$bcdaec40$@samsung.com> (raw)
In-Reply-To: <fa122230-e0fd-6ed6-5473-31b17b56260c@gmail.com>
> Ping..
Hi Tetsuhiro,
>
> On 2020/07/15 19:06, Tetsuhiro Kohada wrote:
> >> It looks complicated. It would be better to simply set/clear VOLUME DIRTY bit.
> >
> > I think exfat_set_vol_flags() gets a little complicated, because it
> > needs the followings (with bit operation)
> > a) Set/Clear VOLUME_DIRTY.
> > b) Set MEDIA_FAILUR.
>
> How about splitting these into separate functions as below?
>
>
> exfat_set_volume_dirty()
> exfat_set_vol_flags(sb, sbi->vol_flag | VOLUME_DIRTY);
>
> exfat_clear_volume_dirty()
> exfat_set_vol_flags(sb, sbi->vol_flag & ~VOLUME_DIRTY);
Looks good.
>
> exfat_set_media_failure()
> exfat_set_vol_flags(sb, sbi->vol_flag | MEDIA_FAILURE);
Where will this function be called? We don't need to create unused functions in advance...
>
>
> The implementation is essentially the same for exfat_set_vol_flags(), but I think the intention of the
> operation will be easier to understand.
Yes.
Thanks!
>
>
> BR
> ---
> Tetsuhiro Kohada <kohada.t2@gmail.com>
next prev parent reply other threads:[~2020-07-30 6:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200708095813epcas1p2277cdf7de6a8bb20c27bcd030eec431f@epcas1p2.samsung.com>
2020-07-08 9:57 ` [PATCH] exfat: retain 'VolumeFlags' properly Tetsuhiro Kohada
2020-07-13 4:52 ` Namjae Jeon
2020-07-14 1:56 ` Kohada.Tetsuhiro
2020-07-15 1:54 ` Namjae Jeon
2020-07-15 10:06 ` Tetsuhiro Kohada
2020-07-30 6:24 ` Tetsuhiro Kohada
2020-07-30 6:59 ` Namjae Jeon [this message]
2020-07-31 1:29 ` Tetsuhiro Kohada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='015e01d6663e$e99e4ec0$bcdaec40$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp \
--cc=Mori.Takahiro@ab.MitsubishiElectric.co.jp \
--cc=Motai.Hirotaka@aj.MitsubishiElectric.co.jp \
--cc=kohada.t2@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).