From: Markus Elfring <Markus.Elfring@web.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Dave Chinner <david@fromorbit.com>,
Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <jth@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH v12 1/2] fs: New zonefs file system
Date: Thu, 6 Feb 2020 20:56:05 +0100 [thread overview]
Message-ID: <02780281-ddb3-7a2f-b5af-cc317d4adf45@web.de> (raw)
> zonefs is a very simple file system …
How do you think about to be consistent with the capitalisation
at the beginning of such sentences?
https://lore.kernel.org/linux-fsdevel/20200206052631.111586-1-damien.lemoal@wdc.com/
…
> +++ b/fs/zonefs/super.c
…
> +static int zonefs_create_zgroup(struct zonefs_zone_data *zd,
> + enum zonefs_ztype type)
> +{
…
> + if (type == ZONEFS_ZTYPE_CNV)
> + zgroup_name = "cnv";
> + else
> + zgroup_name = "seq";
I find the following code variant more succinct.
+ zgroup_name = (type == ZONEFS_ZTYPE_CNV) ? "cnv" : "seq";
Regards,
Markus
next reply other threads:[~2020-02-06 20:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 19:56 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-06 5:26 [PATCH v12 0/2] New zonefs file system Damien Le Moal
2020-02-06 5:26 ` [PATCH v12 1/2] fs: " Damien Le Moal
2020-02-07 0:29 ` Dave Chinner
2020-02-07 2:29 ` Damien Le Moal
2020-02-07 3:49 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02780281-ddb3-7a2f-b5af-cc317d4adf45@web.de \
--to=markus.elfring@web.de \
--cc=Damien.LeMoal@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hare@suse.de \
--cc=jth@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).