Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@redhat.com>, Matthew Wilcox <willy@infradead.org>
Cc: fsdevel <linux-fsdevel@vger.kernel.org>, Jan Kara <jack@suse.cz>,
	Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH] fs: avoid softlockups in s_inodes iterators
Date: Fri, 11 Oct 2019 16:14:02 -0500
Message-ID: <02e4b6c3-1ec8-8adf-93a0-ebf2a7820d65@sandeen.net> (raw)
In-Reply-To: <6e67a39c-88ed-f6a9-16a7-6ae9560a1112@redhat.com>



On 10/11/19 1:45 PM, Eric Sandeen wrote:
> On 10/11/19 1:32 PM, Matthew Wilcox wrote:
>> On Fri, Oct 11, 2019 at 11:49:38AM -0500, Eric Sandeen wrote:
>>> @@ -698,6 +699,13 @@ int invalidate_inodes(struct super_block *sb, bool kill_dirty)
>>>  		inode_lru_list_del(inode);
>>>  		spin_unlock(&inode->i_lock);
>>>  		list_add(&inode->i_lru, &dispose);
>>> +
>>> +		if (need_resched()) {
>>> +			spin_unlock(&sb->s_inode_list_lock);
>>> +			cond_resched();
>>> +			dispose_list(&dispose);
>>> +			goto again;
>>> +		}
>>>  	}
>>>  	spin_unlock(&sb->s_inode_list_lock);
>>>  
>>
>> Is this equivalent to:
>>
>> +		cond_resched_lock(&sb->s_inode_list_lock));
>>
>> or is disposing of the list a crucial part here?
> 
> I think we need to dispose, or we'll start with the entire ~unmodified list again after the goto:

Oh, if you meant in lieu of the goto, we can't drop that lock and
expect to pick up our traversal where we left off, can we?

-Eric

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 16:49 Eric Sandeen
2019-10-11 17:29 ` Josef Bacik
2019-10-11 17:34   ` Eric Sandeen
2019-10-11 17:35     ` Josef Bacik
2019-10-11 18:32 ` Matthew Wilcox
2019-10-11 18:45   ` Eric Sandeen
2019-10-11 21:14     ` Eric Sandeen [this message]
2019-10-12  4:29       ` Dave Chinner
2019-10-14  8:46 ` Jan Kara

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02e4b6c3-1ec8-8adf-93a0-ebf2a7820d65@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=jack@suse.cz \
    --cc=jbacik@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org linux-fsdevel@archiver.kernel.org
	public-inbox-index linux-fsdevel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox