From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
Dmitry Kadashev <dkadashev@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <christian.brauner@ubuntu.com>
Cc: linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org
Subject: Re: [PATCH v5 00/10] io_uring: add mkdir, [sym]linkat and mknodat support
Date: Tue, 22 Jun 2021 11:26:14 -0600 [thread overview]
Message-ID: <0441443f-3f90-2d6c-20aa-92dc95a3f733@kernel.dk> (raw)
In-Reply-To: <ee7307f5-75f3-60d7-836e-830c701fe0e5@gmail.com>
On 6/22/21 5:56 AM, Pavel Begunkov wrote:
> On 6/3/21 6:18 AM, Dmitry Kadashev wrote:
>> This started out as an attempt to add mkdirat support to io_uring which
>> is heavily based on renameat() / unlinkat() support.
>>
>> During the review process more operations were added (linkat, symlinkat,
>> mknodat) mainly to keep things uniform internally (in namei.c), and
>> with things changed in namei.c adding support for these operations to
>> io_uring is trivial, so that was done too. See
>> https://lore.kernel.org/io-uring/20210514145259.wtl4xcsp52woi6ab@wittgenstein/
>
> io_uring part looks good in general, just small comments. However, I
> believe we should respin it, because there should be build problems
> in the middle.
I can drop it, if Dmitry wants to respin. I do think that we could
easily drop mknodat and not really lose anything there, better to
reserve the op for something a bit more useful.
--
Jens Axboe
next prev parent reply other threads:[~2021-06-22 17:26 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 5:18 [PATCH v5 00/10] io_uring: add mkdir, [sym]linkat and mknodat support Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 01/10] fs: make do_mkdirat() take struct filename Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 02/10] io_uring: add support for IORING_OP_MKDIRAT Dmitry Kadashev
2021-06-22 11:41 ` Pavel Begunkov
2021-06-22 11:50 ` Pavel Begunkov
2021-06-23 6:41 ` Dmitry Kadashev
2021-06-23 11:53 ` Pavel Begunkov
2021-06-24 11:11 ` Dmitry Kadashev
2021-06-24 12:21 ` Pavel Begunkov
2021-06-28 8:17 ` Dmitry Kadashev
2021-07-07 14:06 ` Pavel Begunkov
2021-07-12 12:44 ` Dmitry Kadashev
2021-07-12 13:14 ` Pavel Begunkov
2021-06-22 17:41 ` Pavel Begunkov
2021-06-23 0:41 ` Jens Axboe
2021-06-23 5:50 ` Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 03/10] fs: make do_mknodat() take struct filename Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 04/10] fs: make do_symlinkat() " Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 05/10] namei: add getname_uflags() Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 06/10] fs: make do_linkat() take struct filename Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 07/10] fs: update do_*() helpers to return ints Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 08/10] io_uring: add support for IORING_OP_SYMLINKAT Dmitry Kadashev
2021-06-22 11:36 ` Pavel Begunkov
2021-06-23 5:45 ` Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 09/10] io_uring: add support for IORING_OP_LINKAT Dmitry Kadashev
2021-06-22 11:48 ` Pavel Begunkov
2021-06-23 6:09 ` Dmitry Kadashev
2021-06-23 13:13 ` Pavel Begunkov
2021-06-03 5:18 ` [PATCH v5 10/10] io_uring: add support for IORING_OP_MKNODAT Dmitry Kadashev
2021-06-22 11:52 ` Pavel Begunkov
2021-06-23 6:26 ` Dmitry Kadashev
2021-06-23 11:58 ` Pavel Begunkov
2021-06-24 2:36 ` Jens Axboe
2021-06-18 6:24 ` [PATCH v5 00/10] io_uring: add mkdir, [sym]linkat and mknodat support Dmitry Kadashev
2021-06-18 16:10 ` Jens Axboe
2021-06-21 15:21 ` Jens Axboe
2021-06-22 8:12 ` Christian Brauner
2021-06-22 8:34 ` Dmitry Kadashev
2021-06-29 13:06 ` Christian Brauner
2021-06-22 17:26 ` Jens Axboe
2021-06-22 8:26 ` Dmitry Kadashev
2021-06-21 15:57 ` Jens Axboe
2021-06-21 15:59 ` Jens Axboe
2021-06-22 11:56 ` Pavel Begunkov
2021-06-22 17:26 ` Jens Axboe [this message]
2021-06-22 17:28 ` Pavel Begunkov
2021-06-22 17:32 ` Jens Axboe
2021-06-23 5:37 ` Dmitry Kadashev
2021-06-23 5:49 ` Dmitry Kadashev
2021-06-24 2:37 ` Jens Axboe
2021-06-24 10:55 ` Dmitry Kadashev
2021-06-23 5:35 ` Dmitry Kadashev
2021-06-24 2:37 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0441443f-3f90-2d6c-20aa-92dc95a3f733@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=christian.brauner@ubuntu.com \
--cc=dkadashev@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).