From: Vlastimil Babka <vbabka@suse.cz>
To: Kemi Wang <kemi.wang@intel.com>,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>, Michal Hocko <mhocko@suse.com>,
Mel Gorman <mgorman@techsingularity.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Christopher Lameter <cl@linux.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Dave <dave.hansen@linux.intel.com>,
Tim Chen <tim.c.chen@intel.com>,
Andi Kleen <andi.kleen@intel.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Ying Huang <ying.huang@intel.com>, Aaron Lu <aaron.lu@intel.com>,
Proc sysctl <linux-fsdevel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [PATCH v5] mm, sysctl: make NUMA stats configurable
Date: Wed, 18 Oct 2017 08:30:53 +0200 [thread overview]
Message-ID: <082e44ef-c5f2-ae99-8672-37a678c61edd@suse.cz> (raw)
In-Reply-To: <1508290927-8518-1-git-send-email-kemi.wang@intel.com>
On 10/18/2017 03:42 AM, Kemi Wang wrote:
> This is the second step which introduces a tunable interface that allow
> numa stats configurable for optimizing zone_statistics(), as suggested by
> Dave Hansen and Ying Huang.
>
> =========================================================================
> When page allocation performance becomes a bottleneck and you can tolerate
> some possible tool breakage and decreased numa counter precision, you can
> do:
> echo 0 > /proc/sys/vm/numa_stat
> In this case, numa counter update is ignored. We can see about
> *4.8%*(185->176) drop of cpu cycles per single page allocation and reclaim
> on Jesper's page_bench01 (single thread) and *8.1%*(343->315) drop of cpu
> cycles per single page allocation and reclaim on Jesper's page_bench03 (88
> threads) running on a 2-Socket Broadwell-based server (88 threads, 126G
> memory).
>
> Benchmark link provided by Jesper D Brouer(increase loop times to
> 10000000):
> https://github.com/netoptimizer/prototype-kernel/tree/master/kernel/mm/
> bench
>
> =========================================================================
> When page allocation performance is not a bottleneck and you want all
> tooling to work, you can do:
> echo 1 > /proc/sys/vm/numa_stat
> This is system default setting.
>
> Many thanks to Michal Hocko, Dave Hansen, Ying Huang and Vlastimil Babka
> for comments to help improve the original patch.
>
> ChangeLog:
> V4->V5
> a) Scope vm_numa_stat_lock into the sysctl handler function, as suggested
> by Michal Hocko;
> b) Only allow 0/1 value when setting a value to numa_stat at userspace,
> that would keep the possibility for add auto mode in future (e.g. 2 for
> auto mode), as suggested by Michal Hocko.
>
> V3->V4
> a) Get rid of auto mode of numa stats, and may add it back if necessary,
> as alignment before;
> b) Skip NUMA_INTERLEAVE_HIT counter update when numa stats is disabled,
> as reported by Andrey Ryabinin. See commit "de55c8b2519" for details
> c) Remove extern declaration for those clear_numa_ function, and make
> them static in vmstat.c, as suggested by Vlastimil Babka.
>
> V2->V3:
> a) Propose a better way to use jump label to eliminate the overhead of
> branch selection in zone_statistics(), as inspired by Ying Huang;
> b) Add a paragraph in commit log to describe the way for branch target
> selection;
> c) Use a more descriptive name numa_stats_mode instead of vmstat_mode,
> and change the description accordingly, as suggested by Michal Hocko;
> d) Make this functionality NUMA-specific via ifdef
>
> V1->V2:
> a) Merge to one patch;
> b) Use jump label to eliminate the overhead of branch selection;
> c) Add a single-time log message at boot time to help tell users what
> happened.
>
> Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Suggested-by: Dave Hansen <dave.hansen@intel.com>
> Suggested-by: Ying Huang <ying.huang@intel.com>
> Signed-off-by: Kemi Wang <kemi.wang@intel.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-18 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 1:42 [PATCH v5] mm, sysctl: make NUMA stats configurable Kemi Wang
2017-10-18 6:30 ` Vlastimil Babka [this message]
2017-10-19 7:51 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=082e44ef-c5f2-ae99-8672-37a678c61edd@suse.cz \
--to=vbabka@suse.cz \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=aryabinin@virtuozzo.com \
--cc=bigeasy@linutronix.de \
--cc=brouer@redhat.com \
--cc=cl@linux.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=keescook@chromium.org \
--cc=kemi.wang@intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=tim.c.chen@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).