From: Josef Bacik <josef@toxicpanda.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Eric Sandeen <sandeen@redhat.com>, Christoph Hellwig <hch@lst.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
David Sterba <dsterba@suse.com>
Subject: Inverted mount options completely broken (iversion,relatime)
Date: Wed, 29 Jul 2020 14:32:30 -0400 [thread overview]
Message-ID: <0b154b9b-728f-7d57-d4c5-ec25fc9dfdf3@toxicpanda.com> (raw)
Hello,
Eric reported a problem to me where we were clearing SB_I_VERSION on remount of
a btrfs file system. After digging through I discovered it's because we expect
the proper flags that we want to be passed in via the mount() syscall, and
because we didn't have "iversion" in our show_options entry the mount binary
(form util-linux) wasn't setting MS_I_VERSION for the remount, and thus the VFS
was clearing SB_I_VERSION from our s_flags.
No big deal, I'll fix show_mount. Except Eric then noticed that mount -o
noiversion didn't do anything, we still get iversion set. That's because btrfs
just defaults to having SB_I_VERSION set. Furthermore -o noiversion doesn't get
sent into mount, it's handled by the mount binary itself, and it does this by
not having MS_I_VERSION set in the mount flags.
This happens as well for -o relatime, it's the default and so if you do mount -o
norelatime it won't do anything, you still get relatime behavior. The only time
this changes is if you do mount -o remount,norelatime.
So my question is, what do we do here? I know Christoph has the strong opinion
that we just don't expose I_VERSION at all, which frankly I'm ok with. However
more what I'm asking is what do we do with these weird inverted flags that we
all just kind of ignore on mount? The current setup is just broken if we want
to allow overriding the defaults at mount time. Are we ok with it just being
broken? Are we ok with things like mount -o noiversion not working because the
file system has decided that I_VERSION (or relatime) is the default, and we're
going to ignore what the user asks for unless we're remounting? Thanks,
Josef
next reply other threads:[~2020-07-29 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 18:32 Josef Bacik [this message]
2020-07-29 18:41 ` Inverted mount options completely broken (iversion,relatime) Eric Sandeen
2020-07-29 18:47 ` Josef Bacik
2020-07-29 20:36 ` David Howells
2020-07-29 20:58 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b154b9b-728f-7d57-d4c5-ec25fc9dfdf3@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).