From: "Sungjong Seo" <sj1557.seo@samsung.com>
To: "'Tetsuhiro Kohada'" <kohada.t2@gmail.com>
Cc: <kohada.tetsuhiro@dc.mitsubishielectric.co.jp>,
<mori.takahiro@ab.mitsubishielectric.co.jp>,
<motai.hirotaka@aj.mitsubishielectric.co.jp>,
"'Namjae Jeon'" <namjae.jeon@samsung.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/4] exfat: redefine PBR as boot_sector
Date: Fri, 29 May 2020 14:28:24 +0900 [thread overview]
Message-ID: <0bd201d63579$f9b03d00$ed10b700$@samsung.com> (raw)
In-Reply-To: <48fe0abe-8b1c-bea2-820f-71ca141af072@gmail.com>
> > [snip]
> >> +/* EXFAT: Main and Backup Boot Sector (512 bytes) */ struct
> >> +boot_sector {
> >> + __u8 jmp_boot[BOOTSEC_JUMP_BOOT_LEN];
> >> + __u8 oem_name[BOOTSEC_OEM_NAME_LEN];
> >
> > According to the exFAT specification, fs_name and BOOTSEC_FS_NAME_LEN
> > look better.
>
> Oops.
> I sent v2 patches, before I noticed this comment,
>
> I'll make another small patch, OK?
No, It make sense to make v3, because you have renamed the variables in
boot_sector on this patch.
> BTW
> I have a concern about fs_name.
> The exfat specification says that this field is "EXFAT".
>
> I think it's a important field for determining the filesystem.
> However, in this patch, I gave up checking this field.
> Because there is no similar check in FATFS.
> Do you know why Linux FATFS does not check this filed?
> And, what do you think of checking this field?
FATFS has the same field named "oem_name" and whatever is okay for its value.
However, in case of exFAT, it is an important field to determine filesystem.
I think it would be better to check this field for exFAT-fs.
Would you like to contribute new patch for checking it?
>
> BR
next prev parent reply other threads:[~2020-05-29 5:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200525115110epcas1p491bfb477b12825536e81e376f34c7a02@epcas1p4.samsung.com>
2020-05-25 11:50 ` [PATCH 1/4] exfat: redefine PBR as boot_sector Tetsuhiro Kohada
2020-05-25 11:50 ` [PATCH 2/4] exfat: separate the boot sector analysis Tetsuhiro Kohada
2020-05-25 11:50 ` [PATCH 3/4] exfat: add boot region verification Tetsuhiro Kohada
2020-05-26 7:23 ` Namjae Jeon
2020-05-29 16:51 ` kbuild test robot
2020-05-25 11:50 ` [PATCH 4/4] exfat: standardize checksum calculation Tetsuhiro Kohada
2020-05-26 7:32 ` Namjae Jeon
2020-05-27 7:39 ` Tetsuhiro Kohada
2020-05-27 11:28 ` Namjae Jeon
2020-05-28 2:00 ` Tetsuhiro Kohada
2020-05-28 5:03 ` Namjae Jeon
2020-05-28 10:09 ` Tetsuhiro Kohada
2020-05-28 11:30 ` Namjae Jeon
2020-05-28 5:31 ` [PATCH 1/4] exfat: redefine PBR as boot_sector Sungjong Seo
2020-05-28 12:27 ` Tetsuhiro Kohada
2020-05-29 5:28 ` Sungjong Seo [this message]
2020-05-29 6:32 ` Tetsuhiro Kohada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0bd201d63579$f9b03d00$ed10b700$@samsung.com' \
--to=sj1557.seo@samsung.com \
--cc=kohada.t2@gmail.com \
--cc=kohada.tetsuhiro@dc.mitsubishielectric.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mori.takahiro@ab.mitsubishielectric.co.jp \
--cc=motai.hirotaka@aj.mitsubishielectric.co.jp \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).