linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pragat Pandya <pragat.pandya@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	devel@driverdev.osuosl.org, valdis.kletnieks@vt.edu,
	linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
	linux-fsdevel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH 09/22] staging: exfat: Rename variable "Size" to "size"
Date: Wed, 29 Jan 2020 16:28:37 +0530	[thread overview]
Message-ID: <0eac2eebe812a42fd447edfeff3d2791276b655a.camel@gmail.com> (raw)
In-Reply-To: <20200129105012.GA3884393@kroah.com>

On Wed, 2020-01-29 at 11:50 +0100, Greg KH wrote:
> On Wed, Jan 29, 2020 at 04:10:39PM +0530, Pragat Pandya wrote:
> > On Mon, 2020-01-27 at 14:57 +0300, Dan Carpenter wrote:
> > > On Mon, Jan 27, 2020 at 03:43:30PM +0530, Pragat Pandya wrote:
> > > > Change all the occurences of "Size" to "size" in exfat.
> > > > 
> > > > Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
> > > > ---
> > > >  drivers/staging/exfat/exfat.h | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/staging/exfat/exfat.h
> > > > b/drivers/staging/exfat/exfat.h
> > > > index 52f314d50b91..a228350acdb4 100644
> > > > --- a/drivers/staging/exfat/exfat.h
> > > > +++ b/drivers/staging/exfat/exfat.h
> > > > @@ -233,7 +233,7 @@ struct date_time_t {
> > > >  
> > > >  struct part_info_t {
> > > >  	u32      offset;    /* start sector number of the
> > > > partition */
> > > > -	u32      Size;      /* in sectors */
> > > > +	u32      size;      /* in sectors */
> > > >  };
> > > 
> > > We just renamed all the struct members of this without changing
> > > any
> > > users.  Which suggests that this is unused and can be deleted.
> > > 
> > > regards,
> > > dan carpenter
> > > 
> > 
> > Can I just drop this commit from this patchset and do a separate
> > patch
> > to remove the unused structure?
> 
> Drop this one, and the other ones that touch this structure, and do a
> separate patch.  This series needs fixing up anyway, I can't take it
> as-is.
> 
> thanks,
> 
> greg k-h

Ok, will do that.

Regards,
pragat pandya


  reply	other threads:[~2020-01-29 10:58 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 10:13 [PATCH 00/22] staging: exfat: Fix checkpatch warning: Avoid Pragat Pandya
2020-01-27 10:13 ` [PATCH 01/22] staging: exfat: Rename variable "Year" to "year" Pragat Pandya
2020-01-27 10:13 ` [PATCH 02/22] staging: exfat: Rename variable "Month" to "mont"h Pragat Pandya
2020-02-07  9:46   ` Greg KH
2020-02-10 18:35     ` [PATCH v2 00/19] Renaming some identifiers Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 01/19] staging: exfat: Rename variable 'Year' to 'year' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 02/19] staging: exfat: Rename variable 'Month' to 'month' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 03/19] staging: exfat: Rename variable 'Day' to 'day' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 04/19] staging: exfat: Rename variable 'Hour' to 'hour' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 05/19] staging: exfat: Rename variable 'Minute' to 'minute' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 06/19] staging: exfat: Rename variable 'Second' to 'second' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 07/19] staging: exfat: Rename variable 'MilliSecond' to 'millisecond' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 08/19] staging: exfat: Rename variable 'FatType' to 'fat_type' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 09/19] staging: exfat: Rename variable 'ClusterSize' to 'cluster_size' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 10/19] staging: exfat: Rename variable 'NumClusters' to 'num_clusters' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 11/19] staging: exfat: Rename variable 'FreeClusters' to 'free_clusters' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 12/19] staging: exfat: Rename variable 'UsedClusters' to 'used_clusters' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 13/19] staging: exfat: Rename variable 'Name' to 'name' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 14/19] staging: exfat: Rename variable 'ShortName' to 'short_name' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 15/19] staging: exfat: Rename variable 'Attr' to 'attr' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 16/19] staging: exfat: Rename variable 'NumSubdirs' to 'num_subdirs' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 17/19] staging: exfat: Rename variable 'CreateTimestamp' to 'create_timestamp' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 18/19] staging: exfat: Rename variable 'ModifyTimestamp' to 'modify_timestamp' Pragat Pandya
2020-02-10 18:35       ` [PATCH v2 19/19] staging: exfat: Rename variable 'AccessTimestamp' to 'access_timestamp' Pragat Pandya
2020-02-11 19:26       ` [PATCH v2 00/19] Renaming some identifiers Greg KH
2020-01-27 10:13 ` [PATCH 03/22] staging: exfat: Rename variable "Day" to "day" Pragat Pandya
2020-01-27 10:13 ` [PATCH 04/22] staging: exfat: Rename variable "Hour" to "hour" Pragat Pandya
2020-01-27 10:13 ` [PATCH 05/22] staging: exfat: Rename variable "Minute" to "minute" Pragat Pandya
2020-01-27 10:13 ` [PATCH 06/22] staging: exfat: Rename variable "Second" to "second" Pragat Pandya
2020-01-27 10:13 ` [PATCH 07/22] staging: exfat: Rename variable "MilliSecond" to "milli_second" Pragat Pandya
2020-01-27 11:55   ` Dan Carpenter
2020-01-27 13:22     ` Greg KH
2020-02-11 21:44     ` Joe Perches
2020-01-27 10:13 ` [PATCH 08/22] staging: exfat: Rename variable "Offset" to "offset" Pragat Pandya
2020-01-27 10:13 ` [PATCH 09/22] staging: exfat: Rename variable "Size" to "size" Pragat Pandya
2020-01-27 11:57   ` Dan Carpenter
2020-01-29 10:40     ` Pragat Pandya
2020-01-29 10:50       ` Greg KH
2020-01-29 10:58         ` Pragat Pandya [this message]
2020-01-27 10:13 ` [PATCH 10/22] staging: exfat: Rename variable "SecSize" to "sec_size" Pragat Pandya
2020-01-27 11:59   ` Dan Carpenter
2020-01-27 13:22   ` Greg KH
2020-01-27 10:13 ` [PATCH 11/22] staging: exfat: Rename variable "FatType" to "fat_type" Pragat Pandya
2020-01-27 10:13 ` [PATCH 12/22] staging: exfat: Rename variable "ClusterSize" to "cluster_size" Pragat Pandya
2020-01-27 10:13 ` [PATCH 13/22] staging: exfat: Rename variable "NumClusters" to "num_clusters" Pragat Pandya
2020-01-27 10:13 ` [PATCH 14/22] staging: exfat: Rename variable "FreeClusters" to "free_clusters" Pragat Pandya
2020-01-27 10:13 ` [PATCH 15/22] staging: exfat: Rename variable "UsedClusters" to "used_clusters" Pragat Pandya
2020-01-27 10:13 ` [PATCH 16/22] staging: exfat: Rename variable "Name" to "name" Pragat Pandya
2020-01-27 10:13 ` [PATCH 17/22] staging: exfat: Rename variable "ShortName" to "short_name" Pragat Pandya
2020-01-27 10:13 ` [PATCH 18/22] staging: exfat: Rename variable "Attr" to "attr" Pragat Pandya
2020-01-27 10:13 ` [PATCH 19/22] staging: exfat: Rename variabel "NumSubdirs" to "num_subdirs" Pragat Pandya
2020-01-27 10:13 ` [PATCH 20/22] staging: exfat: Rename variabel "CreateTimestamp" to "create_timestamp" Pragat Pandya
2020-01-27 10:13 ` [PATCH 21/22] staging: exfat: Rename variable "ModifyTimestamp" to "modify_timestamp" Pragat Pandya
2020-01-27 10:13 ` [PATCH 22/22] staging: exfat: Rename variable "AccessTimestamp" to "access_timestamp" Pragat Pandya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0eac2eebe812a42fd447edfeff3d2791276b655a.camel@gmail.com \
    --to=pragat.pandya@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).