From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57CC4C3A59B for ; Sat, 17 Aug 2019 23:26:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22D8321019 for ; Sat, 17 Aug 2019 23:26:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726208AbfHQX0C convert rfc822-to-8bit (ORCPT ); Sat, 17 Aug 2019 19:26:02 -0400 Received: from lithops.sigma-star.at ([195.201.40.130]:43534 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbfHQX0C (ORCPT ); Sat, 17 Aug 2019 19:26:02 -0400 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 70CEF6083139; Sun, 18 Aug 2019 01:25:59 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id cO1ZOsJcBe06; Sun, 18 Aug 2019 01:25:59 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 094F3608311C; Sun, 18 Aug 2019 01:25:59 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id lRtR3EyXAiKz; Sun, 18 Aug 2019 01:25:58 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 63195621FCC8; Sun, 18 Aug 2019 01:25:58 +0200 (CEST) Date: Sun, 18 Aug 2019 01:25:58 +0200 (CEST) From: Richard Weinberger To: Gao Xiang Cc: Greg Kroah-Hartman , Al Viro , linux-fsdevel , devel , linux-erofs , linux-kernel , Andrew Morton , Stephen Rothwell , tytso , Pavel Machek , David Sterba , Amir Goldstein , Christoph Hellwig , Darrick , Dave Chinner , Jaegeuk Kim , Jan Kara , torvalds , Chao Yu , Miao Xie , Li Guifu , Fang Wei , Gao Xiang Message-ID: <1163995781.68824.1566084358245.JavaMail.zimbra@nod.at> In-Reply-To: <20190817220706.GA11443@hsiangkao-HP-ZHAN-66-Pro-G1> References: <20190817082313.21040-1-hsiangkao@aol.com> <1746679415.68815.1566076790942.JavaMail.zimbra@nod.at> <20190817220706.GA11443@hsiangkao-HP-ZHAN-66-Pro-G1> Subject: Re: [PATCH] erofs: move erofs out of staging MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF60 (Linux)/8.8.12_GA_3809) Thread-Topic: erofs: move erofs out of staging Thread-Index: iW3vMR6GAc7F9NKtTVkkNSt0c7Y/uQ== Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org ----- Ursprüngliche Mail ----- >> How does erofs compare to squashfs? >> IIUC it is designed to be faster. Do you have numbers? >> Feel free to point me older mails if you already showed numbers, >> I have to admit I didn't follow the development very closely. > > You can see the following related material which has microbenchmark > tested on my laptop: > https://static.sched.com/hosted_files/kccncosschn19eng/19/EROFS%20file%20system_OSS2019_Final.pdf > > which was mentioned in the related topic as well: > https://lore.kernel.org/r/20190815044155.88483-1-gaoxiang25@huawei.com/ Thanks! Will read into. While digging a little into the code I noticed that you have very few checks of the on-disk data. For example ->u.i_blkaddr. I gave it a try and created a malformed filesystem where u.i_blkaddr is 0xdeadbeef, it causes the kernel to loop forever around erofs_read_raw_page(). Thanks, //richard