From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Jan Kara <jack@suse.cz>, Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
syzbot <syzbot+9933e4476f365f5d5a1b@syzkaller.appspotmail.com>,
linux-mm@kvack.org, mgorman@techsingularity.net,
Michal Hocko <mhocko@kernel.org>,
ak@linux.intel.com, jlayton@redhat.com,
linux-kernel@vger.kernel.org, mawilcox@microsoft.com,
syzkaller-bugs@googlegroups.com, tim.c.chen@linux.intel.com,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: INFO: task hung in generic_file_write_iter
Date: Thu, 3 Jan 2019 09:46:07 +0900 [thread overview]
Message-ID: <12239545-7d8a-820f-48ba-952e2e98a05c@i-love.sakura.ne.jp> (raw)
In-Reply-To: <20190102172636.GA29127@quack2.suse.cz>
On 2019/01/03 2:26, Jan Kara wrote:
> On Thu 03-01-19 01:07:25, Tetsuo Handa wrote:
>> On 2019/01/02 23:40, Jan Kara wrote:
>>> I had a look into this and the only good explanation for this I have is
>>> that sb->s_blocksize is different from (1 << sb->s_bdev->bd_inode->i_blkbits).
>>> If that would happen, we'd get exactly the behavior syzkaller observes
>>> because grow_buffers() would populate different page than
>>> __find_get_block() then looks up.
>>>
>>> However I don't see how that's possible since the filesystem has the block
>>> device open exclusively and blkdev_bszset() makes sure we also have
>>> exclusive access to the block device before changing the block device size.
>>> So changing block device block size after filesystem gets access to the
>>> device should be impossible.
>>>
>>> Anyway, could you perhaps add to your debug patch a dump of 'size' passed
>>> to __getblk_slow() and bdev->bd_inode->i_blkbits? That should tell us
>>> whether my theory is right or not. Thanks!
>>>
>>
>> OK. Andrew, will you add (or fold into) this change?
>>
>> From e6f334380ad2c87457bfc2a4058316c47f75824a Mon Sep 17 00:00:00 2001
>> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>> Date: Thu, 3 Jan 2019 01:03:35 +0900
>> Subject: [PATCH] fs/buffer.c: dump more info for __getblk_gfp() stall problem
>>
>> We need to dump more variables on top of
>> "fs/buffer.c: add debug print for __getblk_gfp() stall problem".
>>
>> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>> Cc: Jan Kara <jack@suse.cz>
>> ---
>> fs/buffer.c | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/buffer.c b/fs/buffer.c
>> index 580fda0..a50acac 100644
>> --- a/fs/buffer.c
>> +++ b/fs/buffer.c
>> @@ -1066,9 +1066,14 @@ static sector_t blkdev_max_block(struct block_device *bdev, unsigned int size)
>> #ifdef CONFIG_DEBUG_AID_FOR_SYZBOT
>> if (!time_after(jiffies, current->getblk_stamp + 3 * HZ))
>> continue;
>> - printk(KERN_ERR "%s(%u): getblk(): executed=%x bh_count=%d bh_state=%lx\n",
>> + printk(KERN_ERR "%s(%u): getblk(): executed=%x bh_count=%d bh_state=%lx "
>> + "bdev_super_blocksize=%lu size=%u "
>> + "bdev_super_blocksize_bits=%u bdev_inode_blkbits=%u\n",
>> current->comm, current->pid, current->getblk_executed,
>> - current->getblk_bh_count, current->getblk_bh_state);
>> + current->getblk_bh_count, current->getblk_bh_state,
>> + bdev->bd_super->s_blocksize, size,
>> + bdev->bd_super->s_blocksize_bits,
>> + bdev->bd_inode->i_blkbits);
>
> Well, bd_super may be NULL if there's no filesystem mounted so it would be
> safer to check for this rather than blindly dereferencing it... Otherwise
> the change looks good to me.
I see. Let's be cautious here.
>From 317a0d0002b3d2cadae606055ad50f2926ca62d2 Mon Sep 17 00:00:00 2001
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: Thu, 3 Jan 2019 09:42:02 +0900
Subject: [PATCH v2] fs/buffer.c: dump more info for __getblk_gfp() stall problem
We need to dump more variables on top of
"fs/buffer.c: add debug print for __getblk_gfp() stall problem".
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Jan Kara <jack@suse.cz>
---
fs/buffer.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index 580fda0..784de3d 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1066,9 +1066,15 @@ static sector_t blkdev_max_block(struct block_device *bdev, unsigned int size)
#ifdef CONFIG_DEBUG_AID_FOR_SYZBOT
if (!time_after(jiffies, current->getblk_stamp + 3 * HZ))
continue;
- printk(KERN_ERR "%s(%u): getblk(): executed=%x bh_count=%d bh_state=%lx\n",
+ printk(KERN_ERR "%s(%u): getblk(): executed=%x bh_count=%d bh_state=%lx bdev_super_blocksize=%ld size=%u bdev_super_blocksize_bits=%d bdev_inode_blkbits=%d\n",
current->comm, current->pid, current->getblk_executed,
- current->getblk_bh_count, current->getblk_bh_state);
+ current->getblk_bh_count, current->getblk_bh_state,
+ IS_ERR_OR_NULL(bdev->bd_super) ? -1L :
+ bdev->bd_super->s_blocksize, size,
+ IS_ERR_OR_NULL(bdev->bd_super) ? -1 :
+ bdev->bd_super->s_blocksize_bits,
+ IS_ERR_OR_NULL(bdev->bd_inode) ? -1 :
+ bdev->bd_inode->i_blkbits);
current->getblk_executed = 0;
current->getblk_bh_count = 0;
current->getblk_bh_state = 0;
--
1.8.3.1
next prev parent reply other threads:[~2019-01-03 0:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0000000000009ce88d05714242a8@google.com>
[not found] ` <4b349bff-8ad4-6410-250d-593b13d8d496@I-love.SAKURA.ne.jp>
2018-07-20 10:36 ` INFO: task hung in generic_file_write_iter Tetsuo Handa
2018-07-20 20:06 ` Andrew Morton
2018-07-30 15:07 ` Tetsuo Handa
2018-08-06 10:09 ` Jan Kara
2018-08-06 11:56 ` Tetsuo Handa
2018-08-20 14:12 ` Tetsuo Handa
2018-12-28 13:34 ` Tetsuo Handa
2019-01-02 14:40 ` Jan Kara
2019-01-02 14:46 ` Dmitry Vyukov
2019-01-02 16:07 ` Tetsuo Handa
2019-01-02 17:26 ` Jan Kara
2019-01-03 0:46 ` Tetsuo Handa [this message]
2019-01-08 10:04 ` Tetsuo Handa
2019-01-08 11:24 ` Jan Kara
2019-01-08 11:49 ` Dmitry Vyukov
2019-01-09 13:30 ` Jan Kara
2019-01-09 13:30 ` Jan Kara
2019-01-14 15:11 ` Dmitry Vyukov
2019-01-14 15:11 ` Dmitry Vyukov
2019-01-14 15:13 ` Dmitry Vyukov
2019-01-14 15:13 ` Dmitry Vyukov
2019-01-15 9:29 ` Jan Kara
2019-01-15 9:29 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12239545-7d8a-820f-48ba-952e2e98a05c@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=syzbot+9933e4476f365f5d5a1b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tim.c.chen@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).