From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric W. Biederman" Subject: [PATCH 17/24] sysfs: Merge sysfs_rename_dir and sysfs_move_dir Date: Thu, 28 May 2009 16:00:58 -0700 Message-ID: <1243551665-23596-17-git-send-email-ebiederm@xmission.com> References: Cc: , Tejun Heo , Cornelia Huck , , Kay Sievers , Greg KH , "Eric W. Biederman" , "Eric W. Biederman" To: Andrew Morton , Greg Kroah-Hartman Return-path: Received: from out01.mta.xmission.com ([166.70.13.231]:32892 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753578AbZE1XCY (ORCPT ); Thu, 28 May 2009 19:02:24 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Eric W. Biederman These two functions do 90% of the same work and it doesn't significantly obfuscate the function to allow both the parent dir and the name to change at the same time. So merge them together to simplify maintenance, and increase testing. Acked-by: Tejun Heo Signed-off-by: Eric W. Biederman --- fs/sysfs/dir.c | 66 +++++++++++++++++++++++-------------------------------- 1 files changed, 28 insertions(+), 38 deletions(-) diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index efe8a01..1f8fb9c 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c @@ -688,30 +688,42 @@ void sysfs_remove_dir(struct kobject * kobj) __sysfs_remove_dir(sd); } -int sysfs_rename_dir(struct kobject * kobj, const char *new_name) +static int sysfs_mv_dir(struct sysfs_dirent *sd, + struct sysfs_dirent *new_parent_sd, const char *new_name) { - struct sysfs_dirent *sd = kobj->sd; const char *dup_name = NULL; int error; mutex_lock(&sysfs_mutex); error = 0; - if (strcmp(sd->s_name, new_name) == 0) + if ((sd->s_parent == new_parent_sd) && + (strcmp(sd->s_name, new_name) == 0)) goto out; /* nothing to rename */ error = -EEXIST; - if (sysfs_find_dirent(sd->s_parent, new_name)) + if (sysfs_find_dirent(new_parent_sd, new_name)) goto out; /* rename sysfs_dirent */ - error = -ENOMEM; - new_name = dup_name = kstrdup(new_name, GFP_KERNEL); - if (!new_name) - goto out; + if (strcmp(sd->s_name, new_name) != 0) { + error = -ENOMEM; + new_name = dup_name = kstrdup(new_name, GFP_KERNEL); + if (!new_name) + goto out; + + dup_name = sd->s_name; + sd->s_name = new_name; + } - dup_name = sd->s_name; - sd->s_name = new_name; + /* Remove from old parent's list and insert into new parent's list. */ + if (sd->s_parent != new_parent_sd) { + sysfs_unlink_sibling(sd); + sysfs_get(new_parent_sd); + sysfs_put(sd->s_parent); + sd->s_parent = new_parent_sd; + sysfs_link_sibling(sd); + } error = 0; out: @@ -720,36 +732,14 @@ int sysfs_rename_dir(struct kobject * kobj, const char *new_name) return error; } -int sysfs_move_dir(struct kobject *kobj, struct kobject *new_parent_kobj) +int sysfs_rename_dir(struct kobject * kobj, const char *new_name) { - struct sysfs_dirent *sd = kobj->sd; - struct sysfs_dirent *new_parent_sd; - int error; - - BUG_ON(!sd->s_parent); - - mutex_lock(&sysfs_mutex); - new_parent_sd = new_parent_kobj->sd ? new_parent_kobj->sd : &sysfs_root; - - error = 0; - if (sd->s_parent == new_parent_sd) - goto out; /* nothing to move */ - - error = -EEXIST; - if (sysfs_find_dirent(new_parent_sd, sd->s_name)) - goto out; - - /* Remove from old parent's list and insert into new parent's list. */ - sysfs_unlink_sibling(sd); - sysfs_get(new_parent_sd); - sysfs_put(sd->s_parent); - sd->s_parent = new_parent_sd; - sysfs_link_sibling(sd); + return sysfs_mv_dir(kobj->sd, kobj->sd->s_parent, new_name); +} - error = 0; -out: - mutex_unlock(&sysfs_mutex); - return error; +int sysfs_move_dir(struct kobject *kobj, struct kobject *new_parent_kobj) +{ + return sysfs_mv_dir(kobj->sd, new_parent_kobj->sd, kobj->sd->s_name); } /* Relationship between s_mode and the DT_xxx types */ -- 1.6.3.1.54.g99dd.dirty