From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: patch driver-core-use-sysfs_rename_link-in-device_rename.patch added to gregkh-2.6 tree Date: Tue, 02 Jun 2009 15:57:17 -0700 Message-ID: <12439834372586@kroah.org> References: <1243628376-22905-2-git-send-email-ebiederm@xmission.com> To: ebiederm@xmission.com, akpm@linux-foundation.org, cornelia.huck@de.ibm.com, ebiederm@aristanetworks.com, gregkh@suse.de, greg@kroah.com, kay.sievers@vrfy.org, linux-fsdevel@vger.kerne Return-path: Received: from kroah.org ([198.145.64.141]:56954 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751818AbZFBXBV (ORCPT ); Tue, 2 Jun 2009 19:01:21 -0400 In-Reply-To: <1243628376-22905-2-git-send-email-ebiederm@xmission.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled Subject: driver core: Use sysfs_rename_link in device_rename to my gregkh-2.6 tree. Its filename is driver-core-use-sysfs_rename_link-in-device_rename.patch This tree can be found at http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/ >>From ebiederm@xmission.com Tue Jun 2 15:34:29 2009 From: "Eric W. Biederman" Date: Fri, 29 May 2009 13:19:12 -0700 Subject: driver core: Use sysfs_rename_link in device_rename To: Andrew Morton , Greg Kroah-Hartman Cc: Tejun Heo , Cornelia Huck , , Kay Sievers , Greg KH , "Eric W. Biederman" , "Eric W. Biederman" Message-ID: <1243628376-22905-2-git-send-email-ebiederm@xmission.com> From: Eric W. Biederman Don't open code the renaming of symlinks in sysfs instead use the new helper function sysfs_rename_link Signed-off-by: Eric W. Biederman Signed-off-by: Greg Kroah-Hartman --- drivers/base/core.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1546,22 +1546,16 @@ int device_rename(struct device *dev, ch if (old_class_name) { new_class_name = make_class_name(dev->class->name, &dev->kobj); if (new_class_name) { - error = sysfs_create_link_nowarn(&dev->parent->kobj, - &dev->kobj, - new_class_name); - if (error) - goto out; - sysfs_remove_link(&dev->parent->kobj, old_class_name); + error = sysfs_rename_link(&dev->parent->kobj, + &dev->kobj, + old_class_name, + new_class_name); } } #else if (dev->class) { - error = sysfs_create_link_nowarn(&dev->class->p->class_subsys.kobj, - &dev->kobj, dev_name(dev)); - if (error) - goto out; - sysfs_remove_link(&dev->class->p->class_subsys.kobj, - old_device_name); + error = sysfs_rename_link(&dev->class->p->class_subsys.kobj, + &dev->kobj, old_device_name, new_name); } #endif